You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/17 01:58:40 UTC
[GitHub] [incubator-superset] pkdotson opened a new pull request #10077: chore(metricoption): remove metricoption and columntypelable dependency
pkdotson opened a new pull request #10077:
URL: https://github.com/apache/incubator-superset/pull/10077
### SUMMARY
MetricOption and ColumnTypeLable has been moved over to control-utils in superset-ui.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ x] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10077: chore(metricoption): remove metricoption and columntypelable dependency
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10077:
URL: https://github.com/apache/incubator-superset/pull/10077#issuecomment-645104622
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10077?src=pr&el=h1) Report
> Merging [#10077](https://codecov.io/gh/apache/incubator-superset/pull/10077?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/26120467af3825577a30190f42d942836b147c9f&el=desc) will **decrease** coverage by `0.42%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10077?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10077 +/- ##
==========================================
- Coverage 70.50% 70.07% -0.43%
==========================================
Files 585 184 -401
Lines 31074 18200 -12874
Branches 3185 0 -3185
==========================================
- Hits 21909 12754 -9155
+ Misses 9056 5446 -3610
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.07% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10077?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10077/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | | |
| [superset-frontend/src/welcome/DashboardTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10077/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvRGFzaGJvYXJkVGFibGUuanN4) | | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10077/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | | |
| [...ntend/src/dashboard/components/FilterIndicator.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10077/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvci5qc3g=) | | |
| [superset-frontend/src/explore/AdhocMetric.js](https://codecov.io/gh/apache/incubator-superset/pull/10077/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQWRob2NNZXRyaWMuanM=) | | |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/10077/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | | |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10077/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | | |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/incubator-superset/pull/10077/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | | |
| [...ntend/src/explore/components/AdhocFilterOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10077/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlck9wdGlvbi5qc3g=) | | |
| [...board/util/getSelectedChartIdForFilterScopeTree.js](https://codecov.io/gh/apache/incubator-superset/pull/10077/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldFNlbGVjdGVkQ2hhcnRJZEZvckZpbHRlclNjb3BlVHJlZS5qcw==) | | |
| ... and [382 more](https://codecov.io/gh/apache/incubator-superset/pull/10077/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10077?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10077?src=pr&el=footer). Last update [2612046...73365eb](https://codecov.io/gh/apache/incubator-superset/pull/10077?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10077: chore(metricoption): remove metricoption and columntypelable dependency
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10077:
URL: https://github.com/apache/incubator-superset/pull/10077#discussion_r441659131
##########
File path: superset-frontend/src/explore/components/MetricDefinitionValue.jsx
##########
@@ -19,10 +19,10 @@
import React from 'react';
import PropTypes from 'prop-types';
+import { MetricOption } from '@superset-ui/control-utils';
Review comment:
nit, group this with the above imports
##########
File path: superset-frontend/src/explore/components/AggregateOption.jsx
##########
@@ -19,7 +19,7 @@
import React from 'react';
import PropTypes from 'prop-types';
-import ColumnTypeLabel from '../../components/ColumnTypeLabel';
+import { ColumnTypeLabel } from '@superset-ui/control-utils';
Review comment:
nit, group this with the above imports
##########
File path: superset-frontend/spec/javascripts/explore/components/MetricDefinitionOption_spec.jsx
##########
@@ -20,9 +20,8 @@ import React from 'react';
import configureStore from 'redux-mock-store';
import { shallow } from 'enzyme';
-import { ColumnOption } from '@superset-ui/control-utils';
+import { ColumnOption, MetricOption } from '@superset-ui/control-utils';
Review comment:
nit, group this with the above imports
##########
File path: superset-frontend/src/explore/components/AdhocMetricStaticOption.jsx
##########
@@ -19,7 +19,7 @@
import React from 'react';
import PropTypes from 'prop-types';
-import ColumnTypeLabel from '../../components/ColumnTypeLabel';
+import { ColumnTypeLabel } from '@superset-ui/control-utils';
Review comment:
nit, group this with the above imports
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #10077: chore(metricoption): remove metricoption and columntypelable dependency
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #10077:
URL: https://github.com/apache/incubator-superset/pull/10077
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org