You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/13 07:09:41 UTC
[GitHub] [dolphinscheduler] leo65535 opened a new pull request, #12351: [Fix-12350] fix source not found error
leo65535 opened a new pull request, #12351:
URL: https://github.com/apache/dolphinscheduler/pull/12351
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
We run worker in k8s, will meet `source not found` error when submit tasks.
And, I found someone meet the same error.
Unlucky, Version 3.1.0 does not include a fix for this bug.
Also, when rolling back to 3.0.1, I found [that pr 11625](https://github.com/apache/dolphinscheduler/pull/11625) may not solve this problem, [What does the line "#!/bin/sh" mean in a UNIX shell script?](https://stackoverflow.com/questions/7366775/what-does-the-line-bin-sh-mean-in-a-unix-shell-script) may be helpful.
Please try this: `echo -e '#!/bin/bash\nsource /etc/profile' >> test.sh`
Then we execute it like a worker: `sudo -u $(whoami) sh test.sh`
We will get an error: `test.sh: 2: source: not found`.
We should do `sudo -u $(whoami) bash test.sh`
or `sudo -u $(whoami) sh -c "chmod +x test.sh && ./test.sh"`
_Originally posted by @black-06 in https://github.com/apache/dolphinscheduler/issues/10938#issuecomment-1269309737_
### Version
3.1.x
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #12351: [Fix-12350] fix source not found error
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #12351:
URL: https://github.com/apache/dolphinscheduler/pull/12351#issuecomment-1278363837
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=12351)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12351&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12351&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12351&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] leo65535 commented on pull request #12351: [Fix-12350] fix source not found error
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #12351:
URL: https://github.com/apache/dolphinscheduler/pull/12351#issuecomment-1278348809
> This problem has been fixed in pr #12180
Yeah, meet the same bug, and that pr also wont to fix another bug(`sudo`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] leo65535 closed pull request #12351: [Fix-12350] fix source not found error
Posted by GitBox <gi...@apache.org>.
leo65535 closed pull request #12351: [Fix-12350] fix source not found error
URL: https://github.com/apache/dolphinscheduler/pull/12351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] simsicon commented on pull request #12351: [Fix-12350] fix source not found error
Posted by GitBox <gi...@apache.org>.
simsicon commented on PR #12351:
URL: https://github.com/apache/dolphinscheduler/pull/12351#issuecomment-1278529814
> > > > This problem has been fixed in pr #12180
> > >
> > >
> > > Hi @zhuangchong,
> > > I meet the same bug, but that patch has been inactive for two weeks. And it also wont to fix another bug(`sudo`), it's better to fix the bug quickly. BTW, It doesn't matter to close this issue.
> >
> >
> > I found the part in PR #12180 more complete than what you modified.
>
> yeah, that patch has been inactive for a long time, and I don't understand the `sudo` bug.
Basically the default sudo will reset all envs which just initialized by dolphinscheduler, so we need to pass `-E` to reserve them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #12351: [Fix-12350] fix source not found error
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #12351:
URL: https://github.com/apache/dolphinscheduler/pull/12351#issuecomment-1277279224
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=12351)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12351&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12351&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #12351: [Fix-12350] fix source not found error
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #12351:
URL: https://github.com/apache/dolphinscheduler/pull/12351#issuecomment-1277272603
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=12351)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12351&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12351&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] leo65535 commented on pull request #12351: [Fix-12350] fix source not found error
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #12351:
URL: https://github.com/apache/dolphinscheduler/pull/12351#issuecomment-1278525614
> > > This problem has been fixed in pr #12180
> >
> >
> > Hi @zhuangchong,
> > I meet the same bug, but that patch has been inactive for two weeks. And it also wont to fix another bug(`sudo`), it's better to fix the bug quickly. BTW, It doesn't matter to close this issue.
>
> I found the part in PR #12180 more complete than what you modified.
yeah, that patch has been inactive for a long time, and I don't understand the `sudo` bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhuangchong commented on pull request #12351: [Fix-12350] fix source not found error
Posted by GitBox <gi...@apache.org>.
zhuangchong commented on PR #12351:
URL: https://github.com/apache/dolphinscheduler/pull/12351#issuecomment-1278327720
This problem has been fixed in pr #12180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] leo65535 commented on pull request #12351: [Fix-12350] fix source not found error
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #12351:
URL: https://github.com/apache/dolphinscheduler/pull/12351#issuecomment-1278348058
> Maybe it's better to modify `private static final String SH = "sh";` to `private static final String BASH = "bash";` in `ShellCommandExecutor.java`
Make sense, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhuangchong commented on pull request #12351: [Fix-12350] fix source not found error
Posted by GitBox <gi...@apache.org>.
zhuangchong commented on PR #12351:
URL: https://github.com/apache/dolphinscheduler/pull/12351#issuecomment-1278437516
> > This problem has been fixed in pr #12180
>
> Hi @zhuangchong,
>
> I meet the same bug, but that patch has been inactive for two weeks. And it also wont to fix another bug(`sudo`), it's better to fix the bug quickly. BTW, It doesn't matter to close this issue.
I found the part in PR #12180 more complete than what you modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] simsicon commented on pull request #12351: [Fix-12350] fix source not found error
Posted by GitBox <gi...@apache.org>.
simsicon commented on PR #12351:
URL: https://github.com/apache/dolphinscheduler/pull/12351#issuecomment-1278528257
> cc @simsicon, are you still working on the issue? #12180
Yes, I am waiting for the approval and the merge to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] leo65535 commented on pull request #12351: [Fix-12350] fix source not found error
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #12351:
URL: https://github.com/apache/dolphinscheduler/pull/12351#issuecomment-1278530758
thanks @SbloodyS for review, please rereview the https://github.com/apache/dolphinscheduler/pull/12180
ok @simsicon, I close the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] leo65535 commented on pull request #12351: [Fix-12350] fix source not found error
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #12351:
URL: https://github.com/apache/dolphinscheduler/pull/12351#issuecomment-1278526361
cc @simsicon, are you still working on the issue? https://github.com/apache/dolphinscheduler/pull/12180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #12351: [Fix-12350] fix source not found error
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #12351:
URL: https://github.com/apache/dolphinscheduler/pull/12351#issuecomment-1278363937
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=12351)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12351&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12351&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12351&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12351&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] black-06 commented on pull request #12351: [Fix-12350] fix source not found error
Posted by GitBox <gi...@apache.org>.
black-06 commented on PR #12351:
URL: https://github.com/apache/dolphinscheduler/pull/12351#issuecomment-1277209491
Maybe it's better to modify
`private static final String SH = "sh";`
to `private static final String BASH = "bash";`
in `ShellCommandExecutor.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org