You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/15 09:53:15 UTC
[GitHub] [incubator-doris] liutang123 opened a new pull request #3322:
Remove redundant com.baidu:jprotobuf
liutang123 opened a new pull request #3322: Remove redundant com.baidu:jprotobuf
URL: https://github.com/apache/incubator-doris/pull/3322
For #3318
* exclude jprotobuf from jprotobuf-rpc-core
* add commons-io used in fe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #3322: Remove
redundant com.baidu:jprotobuf
Posted by GitBox <gi...@apache.org>.
morningman commented on issue #3322: Remove redundant com.baidu:jprotobuf
URL: https://github.com/apache/incubator-doris/pull/3322#issuecomment-614084040
Are you sure this will not cause some other problem?
In our environment, we upgrade many clusters by replace the entire `fe/lib` directory, but none of
them encounter this problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] liutang123 commented on issue #3322: Remove
redundant com.baidu:jprotobuf
Posted by GitBox <gi...@apache.org>.
liutang123 commented on issue #3322: Remove redundant com.baidu:jprotobuf
URL: https://github.com/apache/incubator-doris/pull/3322#issuecomment-614381998
> Are you sure this will not cause some other problem?
> In our environment, we upgrade many clusters by replace the entire `fe/lib` directory, but none of
> them encounter this problem.
I am not sure, and this only appears in our 0.11 cluster.
We are testing this PR in our 0.12 cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] liutang123 commented on issue #3322: Remove
redundant com.baidu:jprotobuf
Posted by GitBox <gi...@apache.org>.
liutang123 commented on issue #3322: Remove redundant com.baidu:jprotobuf
URL: https://github.com/apache/incubator-doris/pull/3322#issuecomment-613940178
At 2020-04-15 17:00, we add this patch to our 0.12 cluster for test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] liutang123 commented on pull request #3322: Remove redundant com.baidu:jprotobuf
Posted by GitBox <gi...@apache.org>.
liutang123 commented on pull request #3322:
URL: https://github.com/apache/incubator-doris/pull/3322#issuecomment-626127660
> @liutang123
> What's your test result? Does it work fine after applying your PR?
My test is covered by other people, I will online it today again.
I will give a test result next week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on pull request #3322: Remove redundant com.baidu:jprotobuf
Posted by GitBox <gi...@apache.org>.
imay commented on pull request #3322:
URL: https://github.com/apache/incubator-doris/pull/3322#issuecomment-625884442
@liutang123
What's your test result? Does it work fine after applying your PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] liutang123 edited a comment on pull request #3322: Remove redundant com.baidu:jprotobuf
Posted by GitBox <gi...@apache.org>.
liutang123 edited a comment on pull request #3322:
URL: https://github.com/apache/incubator-doris/pull/3322#issuecomment-626127660
> @liutang123
> What's your test result? Does it work fine after applying your PR?
Our 0.12 cluster run with this pr (without jprotobuf-1.11.9.jar) for long time.
And I think this is stable for merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on pull request #3322: Remove redundant com.baidu:jprotobuf
Posted by GitBox <gi...@apache.org>.
imay commented on pull request #3322:
URL: https://github.com/apache/incubator-doris/pull/3322#issuecomment-626132389
> And I think this is stable for merge.
OK, Could you please rebase master to make regress run again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org