You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by ptgoetz <gi...@git.apache.org> on 2015/04/06 23:34:48 UTC
[GitHub] storm pull request: Storm 748 - Package Multi-Lang scripts so they...
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/509
Storm 748 - Package Multi-Lang scripts so they don't have to be duplicated
This moves storm's multi-lang components to a single location so they can be referenced from, rather than copied to other projects.
Each language implementation then becomes an optional dependency. `storm-core` uses them for unit tests, while `storm-starter` now uses them as a dependency rather than duplicating them.
Please hold off on merging until I have a chance to better document the changes. I'm putting this pull request up so others can comment on the approach I took.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ptgoetz/storm storm-748
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/509.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #509
----
commit f121e9196dfa5b5e8f2a93dfb8138bd6b3cb1df3
Author: P. Taylor Goetz <pt...@gmail.com>
Date: 2015-04-06T19:54:24Z
repackage multi-lang resources
commit 56284447b89ea70ed4eabdb8c921fde496c71f4c
Author: P. Taylor Goetz <pt...@gmail.com>
Date: 2015-04-06T21:02:39Z
sync storm.js with master
commit 9869fec70bdb06b14cc13ffca69320815950d1f5
Author: P. Taylor Goetz <pt...@gmail.com>
Date: 2015-04-06T21:03:15Z
add additional information to error message when ShellBolt dies
commit 8aa3f4086fd2949e5dbb7befb77e51271eb166d0
Author: P. Taylor Goetz <pt...@gmail.com>
Date: 2015-04-06T21:10:27Z
remove redundant multilang scripts
commit 0336c37772305f262df7bfed221ad9378bf4931d
Author: P. Taylor Goetz <pt...@gmail.com>
Date: 2015-04-06T21:19:47Z
update storm-starter to use multilang components from storm distribution; switch to maven shade plugin for uber jar creation
commit 24fe1f55b4b3b0ebd093b1d4a595def896412873
Author: P. Taylor Goetz <pt...@gmail.com>
Date: 2015-04-06T21:25:10Z
rename multilang component modules
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-748: Package Multi-Lang scripts so they ...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/509#issuecomment-90306940
@HeartSaVioR Thanks for the feedback. I'm open to either approach...
My thought behind keeping them separate was that some languages may require compilation (e.g. go, c++, etc.), or some sort of build process (maybe involving Maven filtering?). In that case keeping them separate makes more sense. We don't have that requirement now, but we could in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-748: Package Multi-Lang scripts so they ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/509
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-748: Package Multi-Lang scripts so they ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/509#issuecomment-90317604
@ptgoetz Yes, you're right. I didn't think about language which needs compilation.
Thanks for clarification.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-748: Package Multi-Lang scripts so they ...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/509#issuecomment-95336419
+1 great job.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-748: Package Multi-Lang scripts so they ...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/509#issuecomment-90778496
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-748: Package Multi-Lang scripts so they ...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/509#issuecomment-90279252
Commenting to trigger JIRA sync. Ignore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-748: Package Multi-Lang scripts so they ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/509#issuecomment-90296950
Your approach is great!
Btw, since each language contains only one source file, how about aggregating these into multilang module? pom.xml seems to be duplicated, and seems like aggregating these makes no effect on testing / using.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---