You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/10/03 18:52:49 UTC
Re: Review Request 36180: Avoid multi writers write to same file in
PortMappingIsolatorTests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/
-----------------------------------------------------------
(Updated Oct. 3, 2015, 4:52 p.m.)
Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.
Changes
-------
Rebase
Bugs: MESOS-2765
https://issues.apache.org/jira/browse/MESOS-2765
Repository: mesos
Description
-------
Avoid multi writers write to same file in PortMappingIsolatorTests.
Diffs (updated)
-----
src/tests/containerizer/port_mapping_tests.cpp feca2043503436ac9abac6017ae9059b3fcbed21
Diff: https://reviews.apache.org/r/36180/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 36180: Avoid multi writers write to same file in
PortMappingIsolatorTests.
Posted by haosdent huang <ha...@gmail.com>.
> On Oct. 6, 2015, 3:20 a.m., Cong Wang wrote:
> > src/tests/containerizer/port_mapping_tests.cpp, line 270
> > <https://reviews.apache.org/r/36180/diff/3/?file=1091526#file1091526line270>
> >
> > traffic_invalid_via_loopback is not good either, because there is no traffic from an invalid port....
how about `traffice_empty_via_loopback` and `traffic_empty_via_public`
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/#review101591
-----------------------------------------------------------
On Oct. 6, 2015, 3:13 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36180/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 3:13 a.m.)
>
>
> Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.
>
>
> Bugs: MESOS-2765
> https://issues.apache.org/jira/browse/MESOS-2765
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Avoid multi writers write to same file in PortMappingIsolatorTests.
>
>
> Diffs
> -----
>
> src/tests/containerizer/port_mapping_tests.cpp feca2043503436ac9abac6017ae9059b3fcbed21
>
> Diff: https://reviews.apache.org/r/36180/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 36180: Avoid multi writers write to same file in
PortMappingIsolatorTests.
Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/#review101591
-----------------------------------------------------------
src/tests/containerizer/port_mapping_tests.cpp (line 270)
<https://reviews.apache.org/r/36180/#comment159024>
traffic_invalid_via_loopback is not good either, because there is no traffic from an invalid port....
- Cong Wang
On Oct. 6, 2015, 3:13 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36180/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 3:13 a.m.)
>
>
> Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.
>
>
> Bugs: MESOS-2765
> https://issues.apache.org/jira/browse/MESOS-2765
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Avoid multi writers write to same file in PortMappingIsolatorTests.
>
>
> Diffs
> -----
>
> src/tests/containerizer/port_mapping_tests.cpp feca2043503436ac9abac6017ae9059b3fcbed21
>
> Diff: https://reviews.apache.org/r/36180/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 36180: Avoid multi writers write to same file in
PortMappingIsolatorTests.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/#review101625
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36180]
All tests passed.
- Mesos ReviewBot
On Oct. 6, 2015, 3:13 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36180/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 3:13 a.m.)
>
>
> Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.
>
>
> Bugs: MESOS-2765
> https://issues.apache.org/jira/browse/MESOS-2765
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Avoid multi writers write to same file in PortMappingIsolatorTests.
>
>
> Diffs
> -----
>
> src/tests/containerizer/port_mapping_tests.cpp feca2043503436ac9abac6017ae9059b3fcbed21
>
> Diff: https://reviews.apache.org/r/36180/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 36180: Avoid multi writers write to same file in
PortMappingIsolatorTests.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/
-----------------------------------------------------------
(Updated Oct. 6, 2015, 3:13 a.m.)
Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.
Changes
-------
Update according @wangcong's review
Bugs: MESOS-2765
https://issues.apache.org/jira/browse/MESOS-2765
Repository: mesos
Description
-------
Avoid multi writers write to same file in PortMappingIsolatorTests.
Diffs (updated)
-----
src/tests/containerizer/port_mapping_tests.cpp feca2043503436ac9abac6017ae9059b3fcbed21
Diff: https://reviews.apache.org/r/36180/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.
Posted by Benjamin Mahler <be...@gmail.com>.
Jie or Ian, can you shepherd this?
On Sat, Oct 3, 2015 at 5:25 PM, Mesos ReviewBot <re...@mesos.apache.org>
wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36180/#review101422
> -----------------------------------------------------------
>
>
> Patch looks great!
>
> Reviews applied: [36180]
>
> All tests passed.
>
> - Mesos ReviewBot
>
>
> On Oct. 3, 2015, 4:52 p.m., haosdent huang wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/36180/
> > -----------------------------------------------------------
> >
> > (Updated Oct. 3, 2015, 4:52 p.m.)
> >
> >
> > Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.
> >
> >
> > Bugs: MESOS-2765
> > https://issues.apache.org/jira/browse/MESOS-2765
> >
> >
> > Repository: mesos
> >
> >
> > Description
> > -------
> >
> > Avoid multi writers write to same file in PortMappingIsolatorTests.
> >
> >
> > Diffs
> > -----
> >
> > src/tests/containerizer/port_mapping_tests.cpp
> feca2043503436ac9abac6017ae9059b3fcbed21
> >
> > Diff: https://reviews.apache.org/r/36180/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > haosdent huang
> >
> >
>
>
Re: Review Request 36180: Avoid multi writers write to same file in
PortMappingIsolatorTests.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/#review101422
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36180]
All tests passed.
- Mesos ReviewBot
On Oct. 3, 2015, 4:52 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36180/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 4:52 p.m.)
>
>
> Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.
>
>
> Bugs: MESOS-2765
> https://issues.apache.org/jira/browse/MESOS-2765
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Avoid multi writers write to same file in PortMappingIsolatorTests.
>
>
> Diffs
> -----
>
> src/tests/containerizer/port_mapping_tests.cpp feca2043503436ac9abac6017ae9059b3fcbed21
>
> Diff: https://reviews.apache.org/r/36180/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 36180: Avoid multi writers write to same file in
PortMappingIsolatorTests.
Posted by haosdent huang <ha...@gmail.com>.
> On Oct. 6, 2015, 12:01 a.m., Cong Wang wrote:
> > Or simply use 'tee -a' instead? Since it should not append anything to that file when nc receives nothing.
tee -a aslo OK, but seems use different files would more clear?
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/#review101563
-----------------------------------------------------------
On Oct. 3, 2015, 4:52 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36180/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 4:52 p.m.)
>
>
> Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.
>
>
> Bugs: MESOS-2765
> https://issues.apache.org/jira/browse/MESOS-2765
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Avoid multi writers write to same file in PortMappingIsolatorTests.
>
>
> Diffs
> -----
>
> src/tests/containerizer/port_mapping_tests.cpp feca2043503436ac9abac6017ae9059b3fcbed21
>
> Diff: https://reviews.apache.org/r/36180/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 36180: Avoid multi writers write to same file in
PortMappingIsolatorTests.
Posted by Cong Wang <cw...@twopensource.com>.
> On Oct. 6, 2015, 12:01 a.m., Cong Wang wrote:
> > Or simply use 'tee -a' instead? Since it should not append anything to that file when nc receives nothing.
>
> haosdent huang wrote:
> tee -a aslo OK, but seems use different files would more clear?
I have no preference on either. BTW, names like 'trafficInViaPublic' are too confusing, actually you mean to say "invalid" by "In", spell the full word.
- Cong
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/#review101563
-----------------------------------------------------------
On Oct. 3, 2015, 4:52 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36180/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 4:52 p.m.)
>
>
> Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.
>
>
> Bugs: MESOS-2765
> https://issues.apache.org/jira/browse/MESOS-2765
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Avoid multi writers write to same file in PortMappingIsolatorTests.
>
>
> Diffs
> -----
>
> src/tests/containerizer/port_mapping_tests.cpp feca2043503436ac9abac6017ae9059b3fcbed21
>
> Diff: https://reviews.apache.org/r/36180/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 36180: Avoid multi writers write to same file in
PortMappingIsolatorTests.
Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/#review101563
-----------------------------------------------------------
Or simply use 'tee -a' instead? Since it should not append anything to that file when nc receives nothing.
- Cong Wang
On Oct. 3, 2015, 4:52 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36180/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 4:52 p.m.)
>
>
> Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.
>
>
> Bugs: MESOS-2765
> https://issues.apache.org/jira/browse/MESOS-2765
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Avoid multi writers write to same file in PortMappingIsolatorTests.
>
>
> Diffs
> -----
>
> src/tests/containerizer/port_mapping_tests.cpp feca2043503436ac9abac6017ae9059b3fcbed21
>
> Diff: https://reviews.apache.org/r/36180/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>