You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/06 02:46:33 UTC
[GitHub] [arrow] kou commented on a diff in pull request #13507: [WIP} ARROW-13160: [CI][C++] Use binary caching for vcpkg builds
kou commented on code in PR #13507:
URL: https://github.com/apache/arrow/pull/13507#discussion_r914364622
##########
dev/tasks/python-wheels/github.osx.amd64.yml:
##########
@@ -68,10 +63,23 @@ jobs:
shell: bash
run: echo ${VCPKG_ROOT} >> $GITHUB_PATH
- # workaround for https://github.com/apache/arrow/pull/11569#issuecomment-979592053
- - name: Install OpenSSL
- run: vcpkg install openssl
-
+ - name: Setup NuGet Credentials
+ shell: bash
+ env:
+ GITHUB_TOKEN: {{ '${{ secrets.GITHUB_TOKEN }}' }}
+ run: |
+ mono `vcpkg fetch nuget | tail -n 1` \
+ sources add \
Review Comment:
Could you indent continuous lines?
```bash
mono ... \
sources add \
...
```
##########
dev/tasks/python-wheels/github.osx.amd64.yml:
##########
@@ -68,10 +63,23 @@ jobs:
shell: bash
run: echo ${VCPKG_ROOT} >> $GITHUB_PATH
- # workaround for https://github.com/apache/arrow/pull/11569#issuecomment-979592053
- - name: Install OpenSSL
- run: vcpkg install openssl
-
+ - name: Setup NuGet Credentials
+ shell: bash
+ env:
+ GITHUB_TOKEN: {{ '${{ secrets.GITHUB_TOKEN }}' }}
+ run: |
+ mono `vcpkg fetch nuget | tail -n 1` \
+ sources add \
+ -source "https://nuget.pkg.github.com/ursacomputing/index.json" \
Review Comment:
Can we use `${{ github.repository_owner }}` instead of `ursacomputing`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org