You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Viknes B <vi...@msn.com> on 2012/07/23 20:35:07 UTC
Re: Review Request: Providing options for relationship status
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6095/
-----------------------------------------------------------
(Updated July 23, 2012, 6:35 p.m.)
Review request for rave and Raminder Singh.
Description
-------
Relationship status is a text box. Added a dropdown with options to choose.
This addresses bug Rave-727.
https://issues.apache.org/jira/browse/Rave-727
Diffs
-----
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java 1364737
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1364737
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/includes/new_user_form.jsp 1364737
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1364737
Diff: https://reviews.apache.org/r/6095/diff/
Testing
-------
Thanks,
Viknes B
Re: Review Request: Providing options for relationship status
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6095/#review9517
-----------------------------------------------------------
Ship it!
Ship It!
- Raminder Singh
On July 26, 2012, 3:56 p.m., Viknes B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6095/
> -----------------------------------------------------------
>
> (Updated July 26, 2012, 3:56 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Relationship status is a text box. Added a dropdown with options to choose.
>
>
> This addresses bug Rave-727.
> https://issues.apache.org/jira/browse/Rave-727
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/resources/test_data.sql 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-integration-tests/rave-default-account-tests/src/main/java/org/apache/rave/integrationtests/steps/ProfileSteps.java 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-integration-tests/rave-default-account-tests/src/main/stories/johnDoe.story 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages_es.properties 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/includes/new_user_form.jsp 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1365267
>
> Diff: https://reviews.apache.org/r/6095/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Viknes B
>
>
Re: Review Request: Providing options for relationship status
Posted by Viknes B <vi...@msn.com>.
> On July 26, 2012, 8:01 p.m., Raminder Singh wrote:
> > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/resources/test_data.sql, line 130
> > <https://reviews.apache.org/r/6095/diff/2/?file=129618#file129618line130>
> >
> > Why we need to add status to DB? Can we handle this in the model or service to set some default value?
Now that we have Relationship status as a dropdown, a value should be set for each user.I have set these values so that the integration tests don't fail.
- Viknes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6095/#review9512
-----------------------------------------------------------
On July 26, 2012, 3:56 p.m., Viknes B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6095/
> -----------------------------------------------------------
>
> (Updated July 26, 2012, 3:56 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Relationship status is a text box. Added a dropdown with options to choose.
>
>
> This addresses bug Rave-727.
> https://issues.apache.org/jira/browse/Rave-727
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/resources/test_data.sql 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-integration-tests/rave-default-account-tests/src/main/java/org/apache/rave/integrationtests/steps/ProfileSteps.java 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-integration-tests/rave-default-account-tests/src/main/stories/johnDoe.story 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages_es.properties 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/includes/new_user_form.jsp 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1365267
>
> Diff: https://reviews.apache.org/r/6095/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Viknes B
>
>
Re: Review Request: Providing options for relationship status
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6095/#review9512
-----------------------------------------------------------
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/resources/test_data.sql
<https://reviews.apache.org/r/6095/#comment20332>
Why we need to add status to DB? Can we handle this in the model or service to set some default value?
- Raminder Singh
On July 26, 2012, 3:56 p.m., Viknes B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6095/
> -----------------------------------------------------------
>
> (Updated July 26, 2012, 3:56 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Relationship status is a text box. Added a dropdown with options to choose.
>
>
> This addresses bug Rave-727.
> https://issues.apache.org/jira/browse/Rave-727
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/resources/test_data.sql 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-integration-tests/rave-default-account-tests/src/main/java/org/apache/rave/integrationtests/steps/ProfileSteps.java 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-integration-tests/rave-default-account-tests/src/main/stories/johnDoe.story 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages_es.properties 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/includes/new_user_form.jsp 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1365267
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1365267
>
> Diff: https://reviews.apache.org/r/6095/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Viknes B
>
>
Re: Review Request: Providing options for relationship status
Posted by Viknes B <vi...@msn.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6095/
-----------------------------------------------------------
(Updated July 26, 2012, 3:56 p.m.)
Review request for rave.
Description
-------
Relationship status is a text box. Added a dropdown with options to choose.
This addresses bug Rave-727.
https://issues.apache.org/jira/browse/Rave-727
Diffs (updated)
-----
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/resources/test_data.sql 1365267
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java 1365267
https://svn.apache.org/repos/asf/rave/trunk/rave-integration-tests/rave-default-account-tests/src/main/java/org/apache/rave/integrationtests/steps/ProfileSteps.java 1365267
https://svn.apache.org/repos/asf/rave/trunk/rave-integration-tests/rave-default-account-tests/src/main/stories/johnDoe.story 1365267
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1365267
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages_es.properties 1365267
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1365267
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1365267
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/includes/new_user_form.jsp 1365267
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1365267
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1365267
Diff: https://reviews.apache.org/r/6095/diff/
Testing
-------
Thanks,
Viknes B
Re: Review Request: Providing options for relationship status
Posted by Viknes B <vi...@msn.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6095/
-----------------------------------------------------------
(Updated July 25, 2012, 4:45 p.m.)
Review request for rave and Raminder Singh.
Description
-------
Relationship status is a text box. Added a dropdown with options to choose.
This addresses bug Rave-727.
https://issues.apache.org/jira/browse/Rave-727
Diffs
-----
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java 1364737
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1364737
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/includes/new_user_form.jsp 1364737
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1364737
Diff: https://reviews.apache.org/r/6095/diff/
Testing
-------
Thanks,
Viknes B
Re: Review Request: Providing options for relationship status
Posted by Kristen Legacy <kr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6095/#review9397
-----------------------------------------------------------
Ship it!
LGTM!
NOTE: The classes on the label and select will need to be updated should the patch for RAVE-452 be applied.
- Kristen Legacy
On July 23, 2012, 6:35 p.m., Viknes B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6095/
> -----------------------------------------------------------
>
> (Updated July 23, 2012, 6:35 p.m.)
>
>
> Review request for rave and Raminder Singh.
>
>
> Description
> -------
>
> Relationship status is a text box. Added a dropdown with options to choose.
>
>
> This addresses bug Rave-727.
> https://issues.apache.org/jira/browse/Rave-727
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java 1364737
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1364737
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/includes/new_user_form.jsp 1364737
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1364737
>
> Diff: https://reviews.apache.org/r/6095/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Viknes B
>
>