You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/19 13:24:04 UTC
[GitHub] [cloudstack] rohityadavcloud opened a new pull request, #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
rohityadavcloud opened a new pull request, #7114:
URL: https://github.com/apache/cloudstack/pull/7114
This masks sockets such as virtqemud.socket virtqemud-ro.socket virtqemud-admin.socket, and services virtqemud virtnetworkd virtstoraged that block libvirtd to be used a monolithic service. Useful for both EL9 and existing Ubuntu 22.04, and newer distros.
Didn't test with these changes, but after setting up a local RHEL9+KVM env I had to run these to block them from interfering with the libvirtd process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#discussion_r1082261950
##########
python/lib/cloudutils/serviceConfig.py:
##########
@@ -617,11 +617,8 @@ def config(self):
cfo.addEntry("LIBVIRTD_ARGS", "-l")
cfo.save()
if os.path.exists("/lib/systemd/system/libvirtd.socket"):
- bash("/bin/systemctl mask libvirtd.socket");
- bash("/bin/systemctl mask libvirtd-ro.socket");
- bash("/bin/systemctl mask libvirtd-admin.socket");
- bash("/bin/systemctl mask libvirtd-tls.socket");
- bash("/bin/systemctl mask libvirtd-tcp.socket");
+ bash("/bin/systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket");
+ bash("/bin/systemctl mask virtqemud.socket virtqemud-ro.socket virtqemud-admin.socket virtqemud virtnetworkd virtstoraged");
Review Comment:
Saves time and makes execution faster. For code readability, your suggestion is good I'll accept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#discussion_r1082263017
##########
python/lib/cloudutils/syscfg.py:
##########
@@ -222,6 +224,18 @@ def __init__(self, glbEnv):
nfsConfig(self),
cloudAgentConfig(self)]
+#it covers RHEL9
+class sysConfigRedhat9(sysConfigAgentRedhat8Base):
+ def __init__(self, glbEnv):
+ super(sysConfigRedhat9, self).__init__(glbEnv)
+ self.services = [hostConfig(self),
+ securityPolicyConfigRedhat(self),
+ networkConfigRedhat(self),
+ libvirtConfigRedhat(self),
+ firewallConfigAgent(self),
+ nfsConfig(self),
+ cloudAgentConfig(self)]
+
Review Comment:
I don't know - that's why I said I followed the pattern. With python there's a lot of runtime/meta programming that happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398661554
@rohityadavcloud a Trillian-Jenkins test job (ubuntu20 mgmt + kvm-ubuntu22) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#discussion_r1081254700
##########
python/lib/cloudutils/syscfg.py:
##########
@@ -45,6 +45,8 @@ def getAgent(glbEnv):
return sysConfigRedhat7(glbEnv)
elif distribution == "RHEL8":
return sysConfigRedhat8(glbEnv)
+ elif distribution == "RHEL9":
Review Comment:
cc @shwstppr I'm not sure particularly if we need this, but followed pattern used for EL7 and EL8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1401589043
I lost track of tests planned and tests done here , @rohityadavcloud are we ready to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#discussion_r1082285459
##########
python/lib/cloudutils/serviceConfig.py:
##########
@@ -694,11 +708,8 @@ def setupLiveMigration(self):
cfo = configFileOps("/etc/default/libvirtd", self)
cfo.replace_or_add_line("libvirtd_opts=","libvirtd_opts='-l'")
if os.path.exists("/lib/systemd/system/libvirtd.socket"):
- bash("/bin/systemctl mask libvirtd.socket");
- bash("/bin/systemctl mask libvirtd-ro.socket");
- bash("/bin/systemctl mask libvirtd-admin.socket");
- bash("/bin/systemctl mask libvirtd-tls.socket");
- bash("/bin/systemctl mask libvirtd-tcp.socket");
+ bash("/bin/systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket");
+ bash("/bin/systemctl mask virtqemud.socket virtqemud-ro.socket virtqemud-admin.socket virtqemud virtnetworkd virtstoraged");
Review Comment:
```suggestion
bash("/bin/systemctl mask \
libvirtd.socket \
libvirtd-ro.socket \
libvirtd-admin.socket \
libvirtd-tls.socket \
libvirtd-tcp.socket \
virtqemud.socket \
virtqemud-ro.socket \
virtqemud-admin.socket \
virtqemud \
virtnetworkd \
virtstoraged");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398660483
@rohityadavcloud a Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398662632
@rohityadavcloud a Trillian-Jenkins test job (ubuntu20 mgmt + kvm-ubuntu20) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398660948
@blueorangutan test ubuntu20 kvm-ubuntu22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#discussion_r1083673424
##########
python/lib/cloudutils/serviceConfig.py:
##########
@@ -650,11 +659,20 @@ def config(self):
configureLibvirtConfig(self.syscfg.env.secure, self)
if os.path.exists("/usr/lib/systemd/system/libvirtd.socket"):
- bash("/bin/systemctl mask libvirtd.socket");
- bash("/bin/systemctl mask libvirtd-ro.socket");
- bash("/bin/systemctl mask libvirtd-admin.socket");
- bash("/bin/systemctl mask libvirtd-tls.socket");
- bash("/bin/systemctl mask libvirtd-tcp.socket");
+ bash("/bin/systemctl mask \
+ libvirtd.socket \
+ libvirtd-ro.socket \
+ libvirtd-admin.socket \
+ libvirtd-tls.socket \
+ libvirtd-tcp.socket");
+ if os.path.exists("/usr/lib/systemd/system/virtqemud.socket"):
+ bash("/bin/systemctl mask \
+ virtqemud.socket \
+ virtqemud-ro.socket \
+ virtqemud-admin.socket \
+ virtqemud \
+ virtnetworkd \
+ virtstoraged");
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#discussion_r1081267991
##########
python/lib/cloudutils/serviceConfig.py:
##########
@@ -617,11 +617,8 @@ def config(self):
cfo.addEntry("LIBVIRTD_ARGS", "-l")
cfo.save()
if os.path.exists("/lib/systemd/system/libvirtd.socket"):
- bash("/bin/systemctl mask libvirtd.socket");
- bash("/bin/systemctl mask libvirtd-ro.socket");
- bash("/bin/systemctl mask libvirtd-admin.socket");
- bash("/bin/systemctl mask libvirtd-tls.socket");
- bash("/bin/systemctl mask libvirtd-tcp.socket");
+ bash("/bin/systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket");
+ bash("/bin/systemctl mask virtqemud.socket virtqemud-ro.socket virtqemud-admin.socket virtqemud virtnetworkd virtstoraged");
Review Comment:
@rohityadavcloud
the line 619 ensures the services exist.
```
if os.path.exists("/lib/systemd/system/libvirtd.socket"):
bash("/bin/systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket");
```
a similar check may be needed for the new services
```
bash("/bin/systemctl mask virtqemud.socket virtqemud-ro.socket virtqemud-admin.socket virtqemud virtnetworkd virtstoraged");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1396980807
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398659401
@rohityadavcloud I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv] [qemuEv]
Mgmt OS options: ['centos7', 'centos6', 'suse15', 'alma8', 'ubuntu18', 'ubuntu22', 'ubuntu20', 'rocky8']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-alma8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-ubuntu22', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
when qemuEv is passed, it will deploy KVM hyperviosr hosts with qemu-kvm-ev, else it will default to stock qemu.
Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates.
Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'nvazquez', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'rahulbcn27', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'weizhouapache', 'NuxRo', 'mlsorensen']
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398660121
@blueorangutan test rocky8 kvm-rocky8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398661854
@blueorangutan test ubuntu20 kvm-ubuntu20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1401672507
All passing @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#discussion_r1082263567
##########
python/lib/cloudutils/serviceConfig.py:
##########
@@ -617,11 +617,8 @@ def config(self):
cfo.addEntry("LIBVIRTD_ARGS", "-l")
cfo.save()
if os.path.exists("/lib/systemd/system/libvirtd.socket"):
- bash("/bin/systemctl mask libvirtd.socket");
- bash("/bin/systemctl mask libvirtd-ro.socket");
- bash("/bin/systemctl mask libvirtd-admin.socket");
- bash("/bin/systemctl mask libvirtd-tls.socket");
- bash("/bin/systemctl mask libvirtd-tcp.socket");
+ bash("/bin/systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket");
+ bash("/bin/systemctl mask virtqemud.socket virtqemud-ro.socket virtqemud-admin.socket virtqemud virtnetworkd virtstoraged");
Review Comment:
Yes, the notion is correct. We want to mask is the libvirtd.socket exists. @shwstppr can help double check this @weizhouapache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1399157080
<b>Trillian test result (tid-5924)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 50877 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7114-t5924-vmware-67u3.zip
Smoke tests completed. 107 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1399846286
cc @davidjumani is suse15 working okay?
I've reverted suse15 related changes now, let me try kicking test again.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1400204312
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-suse15) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1396979433
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398026354
@DaanHoogland a Trillian-Jenkins test job (ubuntu22 mgmt + kvm-ubuntu22) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1397054924
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398158929
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398158013
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398213153
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 5337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398274264
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398658967
@blueorangutan help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1399227779
<b>Trillian test result (tid-5939)</b>
Environment: kvm-ubuntu20 (x2), Advanced Networking with Mgmt server u20
Total time taken: 44799 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7114-t5939-kvm-ubuntu20.zip
Smoke tests completed. 106 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 614.03 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1399245339
<b>Trillian test result (tid-5937)</b>
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 53921 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7114-t5937-kvm-rocky8.zip
Smoke tests completed. 107 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1396984497
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398233480
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7114)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7114&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7114&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7114&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7114&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7114&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398290129
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#discussion_r1082261950
##########
python/lib/cloudutils/serviceConfig.py:
##########
@@ -617,11 +617,8 @@ def config(self):
cfo.addEntry("LIBVIRTD_ARGS", "-l")
cfo.save()
if os.path.exists("/lib/systemd/system/libvirtd.socket"):
- bash("/bin/systemctl mask libvirtd.socket");
- bash("/bin/systemctl mask libvirtd-ro.socket");
- bash("/bin/systemctl mask libvirtd-admin.socket");
- bash("/bin/systemctl mask libvirtd-tls.socket");
- bash("/bin/systemctl mask libvirtd-tcp.socket");
+ bash("/bin/systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket");
+ bash("/bin/systemctl mask virtqemud.socket virtqemud-ro.socket virtqemud-admin.socket virtqemud virtnetworkd virtstoraged");
Review Comment:
Saves time and makes execution faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#discussion_r1082332198
##########
python/lib/cloudutils/serviceConfig.py:
##########
@@ -617,11 +617,8 @@ def config(self):
cfo.addEntry("LIBVIRTD_ARGS", "-l")
cfo.save()
if os.path.exists("/lib/systemd/system/libvirtd.socket"):
- bash("/bin/systemctl mask libvirtd.socket");
- bash("/bin/systemctl mask libvirtd-ro.socket");
- bash("/bin/systemctl mask libvirtd-admin.socket");
- bash("/bin/systemctl mask libvirtd-tls.socket");
- bash("/bin/systemctl mask libvirtd-tcp.socket");
+ bash("/bin/systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket");
+ bash("/bin/systemctl mask virtqemud.socket virtqemud-ro.socket virtqemud-admin.socket virtqemud virtnetworkd virtstoraged");
Review Comment:
looks good @rohityadavcloud
thanks for update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1399900887
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1400705563
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-suse15) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398974738
<b>Trillian test result (tid-5912)</b>
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 47637 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7114-t5912-kvm-ubuntu22.zip
Smoke tests completed. 106 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_upgrade_kubernetes_cluster | `Failure` | 551.86 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 625.06 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1399085736
<b>Trillian test result (tid-5925)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41056 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7114-t5925-kvm-centos7.zip
Smoke tests completed. 107 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398290867
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#discussion_r1082200976
##########
python/lib/cloudutils/syscfg.py:
##########
@@ -222,6 +224,18 @@ def __init__(self, glbEnv):
nfsConfig(self),
cloudAgentConfig(self)]
+#it covers RHEL9
+class sysConfigRedhat9(sysConfigAgentRedhat8Base):
+ def __init__(self, glbEnv):
+ super(sysConfigRedhat9, self).__init__(glbEnv)
+ self.services = [hostConfig(self),
+ securityPolicyConfigRedhat(self),
+ networkConfigRedhat(self),
+ libvirtConfigRedhat(self),
+ firewallConfigAgent(self),
+ nfsConfig(self),
+ cloudAgentConfig(self)]
+
Review Comment:
this is exactly the same as sysConfigRedhat7 and sysConfigRedhat8 the extra code adds nothing here.
##########
python/lib/cloudutils/serviceConfig.py:
##########
@@ -617,11 +617,8 @@ def config(self):
cfo.addEntry("LIBVIRTD_ARGS", "-l")
cfo.save()
if os.path.exists("/lib/systemd/system/libvirtd.socket"):
- bash("/bin/systemctl mask libvirtd.socket");
- bash("/bin/systemctl mask libvirtd-ro.socket");
- bash("/bin/systemctl mask libvirtd-admin.socket");
- bash("/bin/systemctl mask libvirtd-tls.socket");
- bash("/bin/systemctl mask libvirtd-tcp.socket");
+ bash("/bin/systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket");
+ bash("/bin/systemctl mask virtqemud.socket virtqemud-ro.socket virtqemud-admin.socket virtqemud virtnetworkd virtstoraged");
Review Comment:
if making it long lines, why not all on one line. One fork instead of two.
```suggestion
bash("/bin/systemctl mask \
libvirtd.socket \
libvirtd-ro.socket \
libvirtd-admin.socket \
libvirtd-tls.socket \
libvirtd-tcp.socket \
virtqemud.socket \
virtqemud-ro.socket \
virtqemud-admin.socket \
virtqemud \
virtnetworkd \
virtstoraged");
```
##########
python/lib/cloudutils/serviceConfig.py:
##########
@@ -617,11 +617,8 @@ def config(self):
cfo.addEntry("LIBVIRTD_ARGS", "-l")
cfo.save()
if os.path.exists("/lib/systemd/system/libvirtd.socket"):
- bash("/bin/systemctl mask libvirtd.socket");
- bash("/bin/systemctl mask libvirtd-ro.socket");
- bash("/bin/systemctl mask libvirtd-admin.socket");
- bash("/bin/systemctl mask libvirtd-tls.socket");
- bash("/bin/systemctl mask libvirtd-tcp.socket");
+ bash("/bin/systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket");
+ bash("/bin/systemctl mask virtqemud.socket virtqemud-ro.socket virtqemud-admin.socket virtqemud virtnetworkd virtstoraged");
Review Comment:
These are guarded by that condition, aren´t they, @weizhouapache ?
cc @rohityadavcloud
If it is the intention to mask all if "/lib/systemd/system/libvirtd.socket" exists, this should work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1396972479
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398025675
@blueorangutan test ubuntu22 kvm-ubuntu22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1400704678
@blueorangutan test centos7 kvm-suse15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1401549999
<b>Trillian test result (tid-5974)</b>
Environment: kvm-suse15 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44156 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7114-t5974-kvm-suse15.zip
Smoke tests completed. 107 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1397086755
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7114)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7114&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7114&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7114&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7114&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7114&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1399846961
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1400209871
<b>Trillian Build Failed (tid-5957)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#discussion_r1082306922
##########
python/lib/cloudutils/serviceConfig.py:
##########
@@ -617,11 +617,8 @@ def config(self):
cfo.addEntry("LIBVIRTD_ARGS", "-l")
cfo.save()
if os.path.exists("/lib/systemd/system/libvirtd.socket"):
- bash("/bin/systemctl mask libvirtd.socket");
- bash("/bin/systemctl mask libvirtd-ro.socket");
- bash("/bin/systemctl mask libvirtd-admin.socket");
- bash("/bin/systemctl mask libvirtd-tls.socket");
- bash("/bin/systemctl mask libvirtd-tcp.socket");
+ bash("/bin/systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket");
+ bash("/bin/systemctl mask virtqemud.socket virtqemud-ro.socket virtqemud-admin.socket virtqemud virtnetworkd virtstoraged");
Review Comment:
Done @weizhouapache
##########
python/lib/cloudutils/syscfg.py:
##########
@@ -222,6 +224,18 @@ def __init__(self, glbEnv):
nfsConfig(self),
cloudAgentConfig(self)]
+#it covers RHEL9
+class sysConfigRedhat9(sysConfigAgentRedhat8Base):
+ def __init__(self, glbEnv):
+ super(sysConfigRedhat9, self).__init__(glbEnv)
+ self.services = [hostConfig(self),
+ securityPolicyConfigRedhat(self),
+ networkConfigRedhat(self),
+ libvirtConfigRedhat(self),
+ firewallConfigAgent(self),
+ nfsConfig(self),
+ cloudAgentConfig(self)]
+
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398370670
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7114](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f622506) into [main](https://codecov.io/gh/apache/cloudstack/commit/e8c32d68fcb03c0fd695aa72fb6a22de63c96db4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e8c32d6) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #7114 +/- ##
============================================
- Coverage 11.78% 11.77% -0.01%
+ Complexity 7668 7667 -1
============================================
Files 2503 2505 +2
Lines 245981 246153 +172
Branches 38380 38429 +49
============================================
+ Hits 28988 28994 +6
- Misses 213222 213387 +165
- Partials 3771 3772 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...com/cloud/agent/manager/ConnectedAgentAttache.java](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9jb20vY2xvdWQvYWdlbnQvbWFuYWdlci9Db25uZWN0ZWRBZ2VudEF0dGFjaGUuamF2YQ==) | `25.00% <0.00%> (-12.50%)` | :arrow_down: |
| [...apache/cloudstack/syslog/AlertsSyslogAppender.java](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zeXNsb2ctYWxlcnRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N5c2xvZy9BbGVydHNTeXNsb2dBcHBlbmRlci5qYXZh) | `56.49% <0.00%> (-2.26%)` | :arrow_down: |
| [...ain/java/com/cloud/consoleproxy/AgentHookBase.java](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2NvbnNvbGVwcm94eS9BZ2VudEhvb2tCYXNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...a/src/main/java/com/cloud/vm/ConsoleSessionVO.java](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC92bS9Db25zb2xlU2Vzc2lvblZPLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...n/java/com/cloud/vm/dao/ConsoleSessionDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC92bS9kYW8vQ29uc29sZVNlc3Npb25EYW9JbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...om/cloud/deploy/DeploymentPlanningManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2RlcGxveS9EZXBsb3ltZW50UGxhbm5pbmdNYW5hZ2VySW1wbC5qYXZh) | `28.92% <0.00%> (+0.75%)` | :arrow_up: |
| [...udstack/consoleproxy/ConsoleAccessManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2NvbnNvbGVwcm94eS9Db25zb2xlQWNjZXNzTWFuYWdlckltcGwuamF2YQ==) | `6.32% <0.00%> (+0.77%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1399005031
<b>Trillian Build Failed (tid-5938)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398662944
@blueorangutan suse15 kvm-suse15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1399083543
<b>Trillian test result (tid-5923)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40799 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7114-t5923-xenserver-71.zip
Smoke tests completed. 107 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by sonarcloud.
sonarcloud[bot] commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1399892475
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7114)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7114&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7114&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7114&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7114&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7114&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7114&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1400882329
<b>Trillian test result (tid-5950)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41145 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7114-t5950-kvm-centos7.zip
Smoke tests completed. 107 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#discussion_r1082285132
##########
python/lib/cloudutils/serviceConfig.py:
##########
@@ -650,11 +657,8 @@ def config(self):
configureLibvirtConfig(self.syscfg.env.secure, self)
if os.path.exists("/usr/lib/systemd/system/libvirtd.socket"):
- bash("/bin/systemctl mask libvirtd.socket");
- bash("/bin/systemctl mask libvirtd-ro.socket");
- bash("/bin/systemctl mask libvirtd-admin.socket");
- bash("/bin/systemctl mask libvirtd-tls.socket");
- bash("/bin/systemctl mask libvirtd-tcp.socket");
+ bash("/bin/systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket");
+ bash("/bin/systemctl mask virtqemud.socket virtqemud-ro.socket virtqemud-admin.socket virtqemud virtnetworkd virtstoraged");
Review Comment:
```suggestion
bash("/bin/systemctl mask \
libvirtd.socket \
libvirtd-ro.socket \
libvirtd-admin.socket \
libvirtd-tls.socket \
libvirtd-tcp.socket \
virtqemud.socket \
virtqemud-ro.socket \
virtqemud-admin.socket \
virtqemud \
virtnetworkd \
virtstoraged");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398660645
@blueorangutan test ubuntu20 kvm-ubuntu20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1400203893
@blueorangutan test centos7 kvm-suse15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1399457583
@rohityadavcloud a Trillian-Jenkins test job (rocky8 mgmt + kvm-suse15) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1399457411
@blueorangutan test rocky8 kvm-suse15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1399931195
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1399930478
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1396985551
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1397079059
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org