You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2024/03/09 02:55:04 UTC
[PR] Jetty [incubator-celeborn]
turboFei opened a new pull request, #2371:
URL: https://github.com/apache/incubator-celeborn/pull/2371
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2371:
URL: https://github.com/apache/celeborn/pull/2371#discussion_r1540543378
##########
pom.xml:
##########
@@ -497,6 +497,12 @@
<groupId>org.glassfish.jersey.test-framework</groupId>
<artifactId>jersey-test-framework-core</artifactId>
<version>${jersey.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>jakarta.activation</groupId>
+ <artifactId>jakarta.activation-api</artifactId>
+ </exclusion>
Review Comment:
but the finally dependencyList of maven and sbt are the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on PR #2371:
URL: https://github.com/apache/celeborn/pull/2371#issuecomment-2023031423
Thanks, merge to main(v0.5.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2371:
URL: https://github.com/apache/celeborn/pull/2371#issuecomment-2023049184
thanks all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [incubator-celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2371:
URL: https://github.com/apache/incubator-celeborn/pull/2371#discussion_r1529470686
##########
pom.xml:
##########
@@ -497,6 +497,12 @@
<groupId>org.glassfish.jersey.test-framework</groupId>
<artifactId>jersey-test-framework-core</artifactId>
<version>${jersey.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>jakarta.activation</groupId>
+ <artifactId>jakarta.activation-api</artifactId>
+ </exclusion>
Review Comment:
FYI:
@waitinfuture @pan3793
https://github.com/apache/incubator-celeborn/pull/2371/commits/8d715fff777d9e3254319f337354c5d0704f7239
I exclude `jakarta.activation-api` from the `test` scope dependency `jersey-test-framework-core`.
Then the `jakarta.activation-api` disappear from `dependencies-server`.
It does not make senses, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [incubator-celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2371:
URL: https://github.com/apache/incubator-celeborn/pull/2371#discussion_r1529449515
##########
dev/deps/dependencies-server:
##########
@@ -26,13 +28,44 @@ failureaccess/1.0.1//failureaccess-1.0.1.jar
guava/32.1.3-jre//guava-32.1.3-jre.jar
hadoop-client-api/3.3.6//hadoop-client-api-3.3.6.jar
hadoop-client-runtime/3.3.6//hadoop-client-runtime-3.3.6.jar
+hk2-api/2.6.1//hk2-api-2.6.1.jar
+hk2-locator/2.6.1//hk2-locator-2.6.1.jar
+hk2-utils/2.6.1//hk2-utils-2.6.1.jar
jackson-annotations/2.15.3//jackson-annotations-2.15.3.jar
jackson-core/2.15.3//jackson-core-2.15.3.jar
jackson-databind/2.15.3//jackson-databind-2.15.3.jar
+jackson-dataformat-yaml/2.13.2//jackson-dataformat-yaml-2.13.2.jar
Review Comment:
Seems there is some bug for maven dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on PR #2371:
URL: https://github.com/apache/celeborn/pull/2371#issuecomment-2022101207
> https://github.com/apache/celeborn/actions/runs/8447675312/job/23138413282?pr=2371
>
> ```
> - celeborn flink integration test - word count *** FAILED ***
> /home/runner/work/celeborn/celeborn/tests/flink-it/target/tmp/celeborn-872038908961646373/celeborn-worker/shuffle_data/1711521828518-1fce5a76b6dfbf104c5d7a224cdbc165/3/2-0-0 had length 0 instead of expected length 177 (WordCountTest.scala:90)
> 24/03/27 06:43:53,720 ERROR [data-client-137-1] TransportResponseHandler: Still have 144 requests outstanding when connection from localhost/127.0.0.1:39701 is closed
> 24/03/27 06:43:53,754 ERROR [data-client-137-3] TransportResponseHandler: Still have 128 requests outstanding when connection from localhost/127.0.0.1:33761 is closed
> 24/03/27 06:43:53,791 ERROR [data-client-137-2] TransportResponseHandler: Still have 120 requests outstanding when connection from localhost/127.0.0.1:43501 is closed
> Run completed in 2 minutes, 22 seconds.
> Total number of tests run: 5
> Suites: completed 4, aborted 0
> Tests: succeeded 4, failed 1, canceled 0, ignored 0, pending 0
> *** 1 TEST FAILED ***
> ```
I will rerun those jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [incubator-celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2371:
URL: https://github.com/apache/incubator-celeborn/pull/2371#issuecomment-1990422077
have made a self check.
1. Add metrics handler
2. remove javax.servlet-api and prefer `jakarta.servlet-api`
3. move metrics handler to service module to prevent involve dependencies to common module and impact the client dependencies
cc @RexXiong @waitinfuture @cfmcgrady
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [incubator-celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2371:
URL: https://github.com/apache/incubator-celeborn/pull/2371#issuecomment-1992329639
Confirmed, works well
<img width="1288" alt="image" src="https://github.com/apache/incubator-celeborn/assets/6757692/632424fd-ca21-4b16-b6c5-4214ebefada0">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [incubator-celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2371:
URL: https://github.com/apache/incubator-celeborn/pull/2371#discussion_r1529449515
##########
dev/deps/dependencies-server:
##########
@@ -26,13 +28,44 @@ failureaccess/1.0.1//failureaccess-1.0.1.jar
guava/32.1.3-jre//guava-32.1.3-jre.jar
hadoop-client-api/3.3.6//hadoop-client-api-3.3.6.jar
hadoop-client-runtime/3.3.6//hadoop-client-runtime-3.3.6.jar
+hk2-api/2.6.1//hk2-api-2.6.1.jar
+hk2-locator/2.6.1//hk2-locator-2.6.1.jar
+hk2-utils/2.6.1//hk2-utils-2.6.1.jar
jackson-annotations/2.15.3//jackson-annotations-2.15.3.jar
jackson-core/2.15.3//jackson-core-2.15.3.jar
jackson-databind/2.15.3//jackson-databind-2.15.3.jar
+jackson-dataformat-yaml/2.13.2//jackson-dataformat-yaml-2.13.2.jar
Review Comment:
Seems there is some bug for maven-dependency-plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2371:
URL: https://github.com/apache/celeborn/pull/2371#discussion_r1540543981
##########
pom.xml:
##########
@@ -497,6 +497,12 @@
<groupId>org.glassfish.jersey.test-framework</groupId>
<artifactId>jersey-test-framework-core</artifactId>
<version>${jersey.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>jakarta.activation</groupId>
+ <artifactId>jakarta.activation-api</artifactId>
+ </exclusion>
Review Comment:
I checked the existing dependencies involved in this pr, all of them appear in the kyuubi dependency list.
So, I think the dependencies looks fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2371:
URL: https://github.com/apache/celeborn/pull/2371#issuecomment-2022074230
https://github.com/apache/celeborn/actions/runs/8447675312/job/23138413282?pr=2371
```
- celeborn flink integration test - word count *** FAILED ***
/home/runner/work/celeborn/celeborn/tests/flink-it/target/tmp/celeborn-872038908961646373/celeborn-worker/shuffle_data/1711521828518-1fce5a76b6dfbf104c5d7a224cdbc165/3/2-0-0 had length 0 instead of expected length 177 (WordCountTest.scala:90)
24/03/27 06:43:53,720 ERROR [data-client-137-1] TransportResponseHandler: Still have 144 requests outstanding when connection from localhost/127.0.0.1:39701 is closed
24/03/27 06:43:53,754 ERROR [data-client-137-3] TransportResponseHandler: Still have 128 requests outstanding when connection from localhost/127.0.0.1:33761 is closed
24/03/27 06:43:53,791 ERROR [data-client-137-2] TransportResponseHandler: Still have 120 requests outstanding when connection from localhost/127.0.0.1:43501 is closed
Run completed in 2 minutes, 22 seconds.
Total number of tests run: 5
Suites: completed 4, aborted 0
Tests: succeeded 4, failed 1, canceled 0, ignored 0, pending 0
*** 1 TEST FAILED ***
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support to show swagger info [incubator-celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2371:
URL: https://github.com/apache/incubator-celeborn/pull/2371#issuecomment-1986991983
cc @RexXiong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [incubator-celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2371:
URL: https://github.com/apache/incubator-celeborn/pull/2371#discussion_r1520488691
##########
service/src/main/scala/org/apache/celeborn/server/common/HttpService.scala:
##########
@@ -173,18 +174,20 @@ abstract class HttpService extends Service with Logging {
def getWorkerEventInfo(): String = throw new UnsupportedOperationException()
def startHttpServer(): Unit = {
- val handlers =
- if (metricsSystem.running) {
- new HttpRequestHandler(this, metricsSystem.getServletHandlers)
Review Comment:
Missed metrics servlet. will add it back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [incubator-celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2371:
URL: https://github.com/apache/incubator-celeborn/pull/2371#issuecomment-1992309907
thanks @cfmcgrady addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [incubator-celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2371:
URL: https://github.com/apache/incubator-celeborn/pull/2371#discussion_r1520782933
##########
service/src/main/scala/org/apache/celeborn/server/common/HttpService.scala:
##########
@@ -173,18 +174,20 @@ abstract class HttpService extends Service with Logging {
def getWorkerEventInfo(): String = throw new UnsupportedOperationException()
def startHttpServer(): Unit = {
- val handlers =
- if (metricsSystem.running) {
- new HttpRequestHandler(this, metricsSystem.getServletHandlers)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [incubator-celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2371:
URL: https://github.com/apache/incubator-celeborn/pull/2371#discussion_r1524242862
##########
dev/deps/dependencies-server:
##########
@@ -26,13 +28,44 @@ failureaccess/1.0.1//failureaccess-1.0.1.jar
guava/32.1.3-jre//guava-32.1.3-jre.jar
hadoop-client-api/3.3.6//hadoop-client-api-3.3.6.jar
hadoop-client-runtime/3.3.6//hadoop-client-runtime-3.3.6.jar
+hk2-api/2.6.1//hk2-api-2.6.1.jar
+hk2-locator/2.6.1//hk2-locator-2.6.1.jar
+hk2-utils/2.6.1//hk2-utils-2.6.1.jar
jackson-annotations/2.15.3//jackson-annotations-2.15.3.jar
jackson-core/2.15.3//jackson-core-2.15.3.jar
jackson-databind/2.15.3//jackson-databind-2.15.3.jar
+jackson-dataformat-yaml/2.13.2//jackson-dataformat-yaml-2.13.2.jar
Review Comment:
checking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong closed pull request #2371: [CELEBORN-1317] Refine celeborn http server and support swagger ui
URL: https://github.com/apache/celeborn/pull/2371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Jetty [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2371:
URL: https://github.com/apache/incubator-celeborn/pull/2371#issuecomment-1986773366
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `154 lines` in your changes are missing coverage. Please review.
> Project coverage is 49.00%. Comparing base [(`b3eed34`)](https://app.codecov.io/gh/apache/incubator-celeborn/commit/b3eed34b57feeee97fa5c05d8e0f104a36c97488?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`85f6b8c`)](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: Current head 85f6b8c differs from pull request most recent head ba14b9d. Consider uploading reports for the commit ba14b9d to get more accurate results
| [Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...pache/celeborn/server/common/http/HttpServer.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmljZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2NlbGVib3JuL3NlcnZlci9jb21tb24vaHR0cC9IdHRwU2VydmVyLnNjYWxh) | 0.00% | [49 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rver/common/http/api/CelebornOpenApiResource.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmljZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2NlbGVib3JuL3NlcnZlci9jb21tb24vaHR0cC9hcGkvQ2VsZWJvcm5PcGVuQXBpUmVzb3VyY2Uuc2NhbGE=) | 0.00% | [29 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/celeborn/server/common/http/HttpUtils.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmljZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2NlbGVib3JuL3NlcnZlci9jb21tb24vaHR0cC9IdHRwVXRpbHMuc2NhbGE=) | 0.00% | [26 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...eborn/server/common/http/api/ApiBaseResource.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmljZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2NlbGVib3JuL3NlcnZlci9jb21tb24vaHR0cC9hcGkvQXBpQmFzZVJlc291cmNlLnNjYWxh) | 0.00% | [13 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/celeborn/server/common/HttpService.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmljZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2NlbGVib3JuL3NlcnZlci9jb21tb24vSHR0cFNlcnZpY2Uuc2NhbGE=) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...eborn/server/common/http/api/ApiRootResource.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmljZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2NlbGVib3JuL3NlcnZlci9jb21tb24vaHR0cC9hcGkvQXBpUm9vdFJlc291cmNlLnNjYWxh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...orn/server/common/http/api/ApiRequestContext.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmljZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2NlbGVib3JuL3NlcnZlci9jb21tb24vaHR0cC9hcGkvQXBpUmVxdWVzdENvbnRleHQuc2NhbGE=) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...eleborn/server/common/http/api/OpenAPIConfig.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmljZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2NlbGVib3JuL3NlcnZlci9jb21tb24vaHR0cC9hcGkvT3BlbkFQSUNvbmZpZy5zY2FsYQ==) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...er/common/http/api/CelebornScalaObjectMapper.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmljZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2NlbGVib3JuL3NlcnZlci9jb21tb24vaHR0cC9hcGkvQ2VsZWJvcm5TY2FsYU9iamVjdE1hcHBlci5zY2FsYQ==) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2371 +/- ##
==========================================
+ Coverage 48.72% 49.00% +0.28%
==========================================
Files 209 212 +3
Lines 13014 12942 -72
Branches 1121 1113 -8
==========================================
+ Hits 6340 6341 +1
+ Misses 6263 6190 -73
Partials 411 411
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2371?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [incubator-celeborn]
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #2371:
URL: https://github.com/apache/incubator-celeborn/pull/2371#issuecomment-1991715120
Perhaps we could consider loading the swagger-ui static resources from `swagger-ui.jar`, similar to how [Kyuubi](https://github.com/apache/kyuubi/pull/3710) does it. As there would be no requirement to modify the HTML files, this approach would simplify the maintenance of the swagger-ui resources. cc @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #2371:
URL: https://github.com/apache/incubator-celeborn/pull/2371#discussion_r1522724180
##########
dev/deps/dependencies-server:
##########
@@ -26,13 +28,44 @@ failureaccess/1.0.1//failureaccess-1.0.1.jar
guava/32.1.3-jre//guava-32.1.3-jre.jar
hadoop-client-api/3.3.6//hadoop-client-api-3.3.6.jar
hadoop-client-runtime/3.3.6//hadoop-client-runtime-3.3.6.jar
+hk2-api/2.6.1//hk2-api-2.6.1.jar
+hk2-locator/2.6.1//hk2-locator-2.6.1.jar
+hk2-utils/2.6.1//hk2-utils-2.6.1.jar
jackson-annotations/2.15.3//jackson-annotations-2.15.3.jar
jackson-core/2.15.3//jackson-core-2.15.3.jar
jackson-databind/2.15.3//jackson-databind-2.15.3.jar
+jackson-dataformat-yaml/2.13.2//jackson-dataformat-yaml-2.13.2.jar
Review Comment:
Lot of new dependencies added, are all of these required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [incubator-celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2371:
URL: https://github.com/apache/incubator-celeborn/pull/2371#discussion_r1529470686
##########
pom.xml:
##########
@@ -497,6 +497,12 @@
<groupId>org.glassfish.jersey.test-framework</groupId>
<artifactId>jersey-test-framework-core</artifactId>
<version>${jersey.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>jakarta.activation</groupId>
+ <artifactId>jakarta.activation-api</artifactId>
+ </exclusion>
Review Comment:
FYI:
@waitinfuture @pan3793
I exclude `jakarta.activation-api` from the `test` scope dependency `jersey-test-framework-core`.
Then the `jakarta.activation-api` disappear from `dependencies-server`.
It does not make senses, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1317] Refine celeborn http server and support swagger ui [incubator-celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2371:
URL: https://github.com/apache/incubator-celeborn/pull/2371#discussion_r1529450132
##########
dev/deps/dependencies-server:
##########
@@ -26,13 +28,44 @@ failureaccess/1.0.1//failureaccess-1.0.1.jar
guava/32.1.3-jre//guava-32.1.3-jre.jar
hadoop-client-api/3.3.6//hadoop-client-api-3.3.6.jar
hadoop-client-runtime/3.3.6//hadoop-client-runtime-3.3.6.jar
+hk2-api/2.6.1//hk2-api-2.6.1.jar
+hk2-locator/2.6.1//hk2-locator-2.6.1.jar
+hk2-utils/2.6.1//hk2-utils-2.6.1.jar
jackson-annotations/2.15.3//jackson-annotations-2.15.3.jar
jackson-core/2.15.3//jackson-core-2.15.3.jar
jackson-databind/2.15.3//jackson-databind-2.15.3.jar
+jackson-dataformat-yaml/2.13.2//jackson-dataformat-yaml-2.13.2.jar
Review Comment:
For a dependency with `test` scope, it will copy the sub dependencies of that `test` dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org