[jira] [Commented] (OPENNLP-1476) Modernize DictionaryEntryPersistor to create XMLReader via javax.xml.parsers.SAXParserFactory

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696326#comment-17696326 ] 

ASF GitHub Bot commented on OPENNLP-1476:
-----------------------------------------

mawiesne opened a new pull request, #512:
URL: https://github.com/apache/opennlp/pull/512

   Notes:
   -
   - I experienced a lower built-time when compared with the latest main branch (MacOS, M1)
   - main: ~ 60s, with this change/PR: ~ 55s 
   
   Tasks
   -
   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
   




> Modernize DictionaryEntryPersistor to create XMLReader via javax.xml.parsers.SAXParserFactory
> ---------------------------------------------------------------------------------------------
>
>                 Key: OPENNLP-1476
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1476
>             Project: OpenNLP
>          Issue Type: Improvement
>    Affects Versions: 2.1.0, 2.1.1
>            Reporter: Martin Wiesner
>            Assignee: Martin Wiesner
>            Priority: Minor
>             Fix For: 2.1.2
>
>
> Atm, {{org.xml.sax.helpers.XMLReaderFactory}} is used in {{DictionaryEntryPersistor}}. However, this the use of XMLReaderFactory is deprecated since Java 9, that is:
> {code:java}
> Deprecated
> It is recommended to use javax.xml.parsers.SAXParserFactory instead.
> {code}
> Aim(s):
> * Switch to {{SAXParserFactory}} to obtain instances of {{XMLReader}} to modern way.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)