You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-dev@hadoop.apache.org by Todd Lipcon <to...@apache.org> on 2010/12/22 21:19:23 UTC
Review Request: MAPREDUCE-2224. Fix sync bugs in JvmManager
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/190/
-----------------------------------------------------------
Review request for hadoop-mapreduce and Scott Chen.
Summary
-------
See JIRA
This addresses bug MAPREDUCE-2224.
https://issues.apache.org/jira/browse/MAPREDUCE-2224
Diffs
-----
trunk/src/java/org/apache/hadoop/mapred/JvmManager.java 1052055
trunk/src/test/mapred/org/apache/hadoop/mapred/TestJvmManager.java 1052055
Diff: https://reviews.apache.org/r/190/diff
Testing
-------
Thanks,
Todd
Re: Review Request: MAPREDUCE-2224. Fix sync bugs in JvmManager
Posted by Scott Chen <sc...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/190/#review80
-----------------------------------------------------------
I like the approach. This makes the code cleaner. Just a few nitpick in line.
trunk/src/java/org/apache/hadoop/mapred/JvmManager.java
<https://reviews.apache.org/r/190/#comment137>
This may not be necessary because one of them is immutable the other is volatile.
trunk/src/java/org/apache/hadoop/mapred/JvmManager.java
<https://reviews.apache.org/r/190/#comment135>
Maybe we can call this setTaskRunner to make it more specific.
trunk/src/java/org/apache/hadoop/mapred/JvmManager.java
<https://reviews.apache.org/r/190/#comment136>
Is this necessary? It seems busy is volatile.
- Scott
On 2010-12-22 12:19:22, Todd Lipcon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/190/
> -----------------------------------------------------------
>
> (Updated 2010-12-22 12:19:22)
>
>
> Review request for hadoop-mapreduce and Scott Chen.
>
>
> Summary
> -------
>
> See JIRA
>
>
> This addresses bug MAPREDUCE-2224.
> https://issues.apache.org/jira/browse/MAPREDUCE-2224
>
>
> Diffs
> -----
>
> trunk/src/java/org/apache/hadoop/mapred/JvmManager.java 1052055
> trunk/src/test/mapred/org/apache/hadoop/mapred/TestJvmManager.java 1052055
>
> Diff: https://reviews.apache.org/r/190/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Todd
>
>
Re: Review Request: MAPREDUCE-2224. Fix sync bugs in JvmManager
Posted by Todd Lipcon <to...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/190/
-----------------------------------------------------------
(Updated 2010-12-24 12:52:43.654845)
Review request for hadoop-mapreduce and Scott Chen.
Changes
-------
Addressed the nits - got rid of the 'busy' boolean entirely and just checked for task != null, which should be an invariant.
Tested run-commit-tests.
Summary
-------
See JIRA
This addresses bug MAPREDUCE-2224.
https://issues.apache.org/jira/browse/MAPREDUCE-2224
Diffs (updated)
-----
trunk/src/java/org/apache/hadoop/mapred/JvmManager.java 1052611
trunk/src/test/mapred/org/apache/hadoop/mapred/TestJvmManager.java 1052611
Diff: https://reviews.apache.org/r/190/diff
Testing
-------
Thanks,
Todd