You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/25 12:41:40 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #6401: [AIRFLOW-5732] Add unit test for the version command

mik-laj commented on a change in pull request #6401: [AIRFLOW-5732] Add unit test for the version command
URL: https://github.com/apache/airflow/pull/6401#discussion_r339031390
 
 

 ##########
 File path: tests/core.py
 ##########
 @@ -1795,6 +1796,12 @@ def test_variables(self):
         os.remove('variables2.json')
         os.remove('variables3.json')
 
+    def test_cli_version(self):
 
 Review comment:
   I'm afraid this test is in the wrong place. tests/cli/test_cli.py is a better file.
   
   I am also afraid of sys.stdout mocking. Python has a special mechanism for this. 
   https://github.com/sekikn/incubator-airflow/blob/9ff0c4f79a009618215a2af60418f664168456f4/tests/cli/test_cli.py#L344-L352

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services