You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/08/31 16:00:24 UTC
[GitHub] [cordova-electron] erisu opened a new pull request #205: feat!(Api): remove unused locations data
erisu opened a new pull request #205:
URL: https://github.com/apache/cordova-electron/pull/205
### Motivation and Context
While cleaning up, saw these unused location paths. Removing them but flaging as a breaking change.
### Description
* `Api.js`
* The `cordovaJs` location was removed as it was not used anywhere in code except for tests.
* Appears to be leftover code from other platforms but also not used in those platforms as well
* path is also old and not correct anymore. It changed in an earlier PR which restructured the platform.
* The `cordovaJsSrc` location was removed as it was not used anywhere in code except for tests.
* Appears to be leftover code from other platforms but also not used in those platforms as well
### Testing
- `npm t`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-electron] erisu merged pull request #205: feat!(Api): remove unused locations data
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #205:
URL: https://github.com/apache/cordova-electron/pull/205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-electron] erisu merged pull request #205: feat!(Api): remove unused locations data
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #205:
URL: https://github.com/apache/cordova-electron/pull/205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org