You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by radarwave <gi...@git.apache.org> on 2015/11/04 14:41:24 UTC
[GitHub] incubator-hawq pull request: HAWQ-100. Code Cleanup: gpmapreduce.
GitHub user radarwave opened a pull request:
https://github.com/apache/incubator-hawq/pull/74
HAWQ-100. Code Cleanup: gpmapreduce.
Remove gpmapreduce.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radarwave/incubator-hawq HAWQ-100
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/74.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #74
----
commit 223468ce43d739ac93f099942d43c91a4adc2eff
Author: rlei <rl...@pivotal.io>
Date: 2015-11-04T10:08:11Z
HAWQ-100. Code Cleanup: gpmapreduce.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-100. Code Cleanup: gpmapreduce.
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the pull request:
https://github.com/apache/incubator-hawq/pull/74#issuecomment-153723483
BTW, with this change installcheck-good and sanity tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-100. Code Cleanup: gpmapreduce.
Posted by cwelton <gi...@git.apache.org>.
Github user cwelton commented on the pull request:
https://github.com/apache/incubator-hawq/pull/74#issuecomment-153817122
Overall looks good to me, but git doesn't seem to be able to do a diff this large making the review difficult to complete here on github. I wonder if the apache review tool might do a better job?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-100. Code Cleanup: gpmapreduce.
Posted by yaoj2 <gi...@git.apache.org>.
Github user yaoj2 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/74#issuecomment-153933905
+1 for remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-100. Code Cleanup: gpmapreduce.
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave closed the pull request at:
https://github.com/apache/incubator-hawq/pull/74
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---