You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2024/08/19 03:03:35 UTC

[PR] [CELEBORN-1570] Fix flaky test - monitor non-critical error metrics in DeviceMonitorSuite [celeborn]

cxzl25 opened a new pull request, #2694:
URL: https://github.com/apache/celeborn/pull/2694

   ### What changes were proposed in this pull request?
   
   
   
   ### Why are the changes needed?
   https://github.com/apache/celeborn/actions/runs/10441850633/job/28913478820?pr=2692
   
   ```
   - monitor non-critical error metrics *** FAILED ***
     java.lang.AssertionError: expected:<2> but was:<1>
     at org.junit.Assert.fail(Assert.java:89)
     at org.junit.Assert.failNotEquals(Assert.java:835)
     at org.junit.Assert.assertEquals(Assert.java:120)
     at org.junit.Assert.assertEquals(Assert.java:146)
     at org.apache.celeborn.service.deploy.worker.storage.DeviceMonitorSuite.$anonfun$new$22(DeviceMonitorSuite.scala:405)
   ```
   
   Because calling `System.currentTimeMillis()` twice may get the same value. Gauge uses the size of the set, and the same value will be deduplicated.
   
   https://github.com/apache/celeborn/blob/0ee3c3a4bdef3b97fca6be04f03ac36c2e12e1a6/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/ObservedDevice.scala#L81-L91
   
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   GA
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1570] Fix flaky test - monitor non-critical error metrics in DeviceMonitorSuite [celeborn]

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #2694:
URL: https://github.com/apache/celeborn/pull/2694#issuecomment-2298095520

   The method `System.currentTimeMillis` might return the same value for two invokes. I think changing this UT is not the correct approach to fix this problem. Changing the definition of nonCriticalErrors to List will be better.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1570] Fix flaky test - monitor non-critical error metrics in DeviceMonitorSuite [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #2694: [CELEBORN-1570] Fix flaky test - monitor non-critical error metrics in DeviceMonitorSuite
URL: https://github.com/apache/celeborn/pull/2694


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org