You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jmeter.apache.org by "vlsi (via GitHub)" <gi...@apache.org> on 2023/05/17 14:38:48 UTC

[GitHub] [jmeter] vlsi commented on pull request #693: ci: add randomized matrix for better test coverage

vlsi commented on PR #693:
URL: https://github.com/apache/jmeter/pull/693#issuecomment-1551525295

   I'm going to merge this PR shortly unless there are objections.
   An alternative https://github.com/apache/jmeter/pull/5727 is not dramatically smaller, and it breaks backward compatibility.
   
   It looks like external users have much fewer usages for `Map<TestElement, ...>` than JMeter core, and `TestElement#equals` was probably used much more often for "comparing contents" in plugin code.
   
   Unfortunately, the PR adds new usages of `synchronizedMap`, so we might need to replace them later. I believe they should not be dramatic
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org