You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "sam-byng (via GitHub)" <gi...@apache.org> on 2023/04/27 09:46:12 UTC
[GitHub] [incubator-pekko] sam-byng opened a new pull request, #301: Update the stream-tests truststore/keystore to refer to pekko-remote
sam-byng opened a new pull request, #301:
URL: https://github.com/apache/incubator-pekko/pull/301
The same truststore/keyspace as the one generate with the Makefile at remote/src/test/resources is used here"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning merged pull request #301: Issue 203: Update the truststore/keystore for stream-tests
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #301:
URL: https://github.com/apache/incubator-pekko/pull/301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #301: Issue 203: Update the truststore/keystore for stream-tests
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #301:
URL: https://github.com/apache/incubator-pekko/pull/301#discussion_r1179607859
##########
stream-tests/src/test/resources/Makefile:
##########
@@ -0,0 +1,15 @@
+# Documents how truststore and keystore were created
Review Comment:
can you add a short(-ish) comment to the new file to highlight its similarity to remote/src/test/resources/Makefile ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #301: Issue 203: Update the truststore/keystore for stream-tests
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #301:
URL: https://github.com/apache/incubator-pekko/pull/301#discussion_r1179592891
##########
stream-tests/src/test/resources/Makefile:
##########
@@ -0,0 +1,15 @@
+# Documents how truststore and keystore were created
Review Comment:
do we need a new file? incubator-pekko/remote/src/test/resources/Makefile is very similar to this - can we update that instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] sam-byng commented on a diff in pull request #301: Issue 203: Update the truststore/keystore for stream-tests
Posted by "sam-byng (via GitHub)" <gi...@apache.org>.
sam-byng commented on code in PR #301:
URL: https://github.com/apache/incubator-pekko/pull/301#discussion_r1179601296
##########
stream-tests/src/test/resources/Makefile:
##########
@@ -0,0 +1,15 @@
+# Documents how truststore and keystore were created
Review Comment:
The difference in this case is that there is no SAN extension for stream-tests - that tripped me up during dev here since i originally used the same makefile for both remote and stream-tests. I think it's worth highlighting that difference and a new file was an easy way to make that clear.
Agree that alternative could be done in a shared file , in this case i think we should use a symlink from stream-tests/..../resources to make it clear..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] sam-byng commented on a diff in pull request #301: Issue 203: Update the truststore/keystore for stream-tests
Posted by "sam-byng (via GitHub)" <gi...@apache.org>.
sam-byng commented on code in PR #301:
URL: https://github.com/apache/incubator-pekko/pull/301#discussion_r1179601296
##########
stream-tests/src/test/resources/Makefile:
##########
@@ -0,0 +1,15 @@
+# Documents how truststore and keystore were created
Review Comment:
The difference in this case is that there is no SAN extension for stream-tests - that tripped me up during dev here since i originally used the same makefile for both remote and stream-tests. I think it's worth highlighting that difference and a new file was an easy way to make that clear.
Agree that alternative could be done in a shared file and then we should use a symlink to make it clear..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] sam-byng commented on a diff in pull request #301: Issue 203: Update the truststore/keystore for stream-tests
Posted by "sam-byng (via GitHub)" <gi...@apache.org>.
sam-byng commented on code in PR #301:
URL: https://github.com/apache/incubator-pekko/pull/301#discussion_r1179601296
##########
stream-tests/src/test/resources/Makefile:
##########
@@ -0,0 +1,15 @@
+# Documents how truststore and keystore were created
Review Comment:
The difference in this case is that there is no SAN extension for stream-tests. I think it's worth highlighting that. Agree this could be done in a shared file but then it would have to go in a logical location / we should use a symlink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] sam-byng commented on a diff in pull request #301: Issue 203: Update the truststore/keystore for stream-tests
Posted by "sam-byng (via GitHub)" <gi...@apache.org>.
sam-byng commented on code in PR #301:
URL: https://github.com/apache/incubator-pekko/pull/301#discussion_r1180112321
##########
stream-tests/src/test/resources/Makefile:
##########
@@ -0,0 +1,15 @@
+# Documents how truststore and keystore were created
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org