You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/29 11:03:22 UTC
[GitHub] [bookkeeper] StevenLuMT opened a new pull request, #3376: fix testcase problem: always run fail for zk connect
StevenLuMT opened a new pull request, #3376:
URL: https://github.com/apache/bookkeeper/pull/3376
Descriptions of the changes in this PR:
### Motivation
[fix testcase problem: always run fail for zk connect](https://github.com/apache/bookkeeper/commit/df1d5bc1fbd38fb219626957c1fdf802daee3fb7)
### Changes
1. update zkRetryBackoffMaxRetries in testcase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1171401298
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1169986895
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1171850403
rerun failure checks
> @StevenLuMT Which testcase are you trying to solve?
@Shoothzj thanks for your relay, I have added in the pr description:
<img width="1162" alt="image" src="https://user-images.githubusercontent.com/42990025/176809783-7fe42b6c-a9f9-4ff5-8d0f-bf4aef0ee67d.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1170675621
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1170719990
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1170232294
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1172839018
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1171105307
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1171447383
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1170192570
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a diff in pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on code in PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#discussion_r912319527
##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/conf/TestBKConfiguration.java:
##########
@@ -61,9 +61,9 @@ public static ServerConfiguration newServerConfiguration() {
confReturn.setProperty(DbLedgerStorage.WRITE_CACHE_MAX_SIZE_MB, 4);
confReturn.setProperty(DbLedgerStorage.READ_AHEAD_CACHE_MAX_SIZE_MB, 4);
/**
- * if testcase has zk error,just try 0 time for fast running
+ * if testcase has zk error,just try 3 time for fast running
*/
- confReturn.setZkRetryBackoffMaxRetries(0);
+ confReturn.setZkRetryBackoffMaxRetries(3);
Review Comment:
ok,add a new commit @hangc0276
1.The serial execution to close more auditor is easy timeout,change it concurrent processiing
2.Removing config's zkRetryBackoffMaxRetries,use the default value is Integer.MAX_VALUE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on code in PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#discussion_r911583242
##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/conf/TestBKConfiguration.java:
##########
@@ -61,9 +61,9 @@ public static ServerConfiguration newServerConfiguration() {
confReturn.setProperty(DbLedgerStorage.WRITE_CACHE_MAX_SIZE_MB, 4);
confReturn.setProperty(DbLedgerStorage.READ_AHEAD_CACHE_MAX_SIZE_MB, 4);
/**
- * if testcase has zk error,just try 0 time for fast running
+ * if testcase has zk error,just try 3 time for fast running
*/
- confReturn.setZkRetryBackoffMaxRetries(0);
+ confReturn.setZkRetryBackoffMaxRetries(3);
Review Comment:
Before this PR https://github.com/apache/bookkeeper/pull/2958, the ZK default retry count is `Integer.MAX_VALUE`, I wonder why not use `Integer.MAX_VALUE` instead of 3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1171502306
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1170088125
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1170765202
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1171984852
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1169884833
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1170804567
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1170269415
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1169919820
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a diff in pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on code in PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#discussion_r911590812
##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/conf/TestBKConfiguration.java:
##########
@@ -61,9 +61,9 @@ public static ServerConfiguration newServerConfiguration() {
confReturn.setProperty(DbLedgerStorage.WRITE_CACHE_MAX_SIZE_MB, 4);
confReturn.setProperty(DbLedgerStorage.READ_AHEAD_CACHE_MAX_SIZE_MB, 4);
/**
- * if testcase has zk error,just try 0 time for fast running
+ * if testcase has zk error,just try 3 time for fast running
*/
- confReturn.setZkRetryBackoffMaxRetries(0);
+ confReturn.setZkRetryBackoffMaxRetries(3);
Review Comment:
@hangc0276 set zkRetryBackoffMaxRetries to Integer.MAX_VALUE is ok, I have changed it ,thanks
<img width="2496" alt="image" src="https://user-images.githubusercontent.com/42990025/176818886-0a47bd6b-ceb0-4c5c-b60c-fcd430930c7e.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1173227796
This PR also suffers ZK timeout exception.
```
Error: Failures:
Error: org.apache.bookkeeper.test.OpStatTest.testTopLevelBookieWriteCounters
Error: Run 1: OpStatTest.testTopLevelBookieWriteCounters:98->validateOpStat:75->validateOpStat:70->lambda$testTopLevelBookieWriteCounters$0:105
Error: Run 2: OpStatTest.testTopLevelBookieWriteCounters:98->validateOpStat:75->validateOpStat:70->lambda$testTopLevelBookieWriteCounters$0:105
Error: Run 3: OpStatTest.testTopLevelBookieWriteCounters:98->validateOpStat:75->validateOpStat:70->lambda$testTopLevelBookieWriteCounters$0:105
[INFO]
Error: Errors:
Error: org.apache.bookkeeper.test.LedgerCreateDeleteTest.testCreateLedgerWithZKException
Error: Run 1: LedgerCreateDeleteTest.testCreateLedgerWithZKException:92 » TestTimedOut test ...
Error: Run 2: LedgerCreateDeleteTest.testCreateLedgerWithZKException:92 » TestTimedOut test ...
Error: Run 3: LedgerCreateDeleteTest.testCreateLedgerWithZKException:92 » TestTimedOut test ...
[INFO]
Warning: Flakes:
Warning: org.apache.bookkeeper.test.AsyncLedgerOpsTest.testAsyncCreateClose
Error: Run 1: AsyncLedgerOpsTest.testAsyncCreateClose:154->Object.wait:328->Object.wait:-2 » TestTimedOut
```
https://github.com/apache/bookkeeper/runs/7159965531?check_suite_focus=true
I'm not sure whether this PR can fix the ZK session timeout problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT closed pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT closed pull request #3376: fix testcase problem: always run fail for zk connect
URL: https://github.com/apache/bookkeeper/pull/3376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1174505959
> This PR also suffers ZK timeout exception.
>
> ```
> Error: Failures:
> Error: org.apache.bookkeeper.test.OpStatTest.testTopLevelBookieWriteCounters
> Error: Run 1: OpStatTest.testTopLevelBookieWriteCounters:98->validateOpStat:75->validateOpStat:70->lambda$testTopLevelBookieWriteCounters$0:105
> Error: Run 2: OpStatTest.testTopLevelBookieWriteCounters:98->validateOpStat:75->validateOpStat:70->lambda$testTopLevelBookieWriteCounters$0:105
> Error: Run 3: OpStatTest.testTopLevelBookieWriteCounters:98->validateOpStat:75->validateOpStat:70->lambda$testTopLevelBookieWriteCounters$0:105
> [INFO]
> Error: Errors:
> Error: org.apache.bookkeeper.test.LedgerCreateDeleteTest.testCreateLedgerWithZKException
> Error: Run 1: LedgerCreateDeleteTest.testCreateLedgerWithZKException:92 » TestTimedOut test ...
> Error: Run 2: LedgerCreateDeleteTest.testCreateLedgerWithZKException:92 » TestTimedOut test ...
> Error: Run 3: LedgerCreateDeleteTest.testCreateLedgerWithZKException:92 » TestTimedOut test ...
> [INFO]
> Warning: Flakes:
> Warning: org.apache.bookkeeper.test.AsyncLedgerOpsTest.testAsyncCreateClose
> Error: Run 1: AsyncLedgerOpsTest.testAsyncCreateClose:154->Object.wait:328->Object.wait:-2 » TestTimedOut
> ```
>
> https://github.com/apache/bookkeeper/runs/7159965531?check_suite_focus=true
>
> I'm not sure whether this PR can fix the ZK session timeout problem.
@hangc0276
I have located the problem and I am trying to fix it. I will submit the code later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1170894905
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1170094431
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1171848592
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1171354068
@StevenLuMT Which testcase are you trying to solve?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1171352151
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1172830961
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on code in PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#discussion_r911599411
##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/conf/TestBKConfiguration.java:
##########
@@ -61,9 +61,9 @@ public static ServerConfiguration newServerConfiguration() {
confReturn.setProperty(DbLedgerStorage.WRITE_CACHE_MAX_SIZE_MB, 4);
confReturn.setProperty(DbLedgerStorage.READ_AHEAD_CACHE_MAX_SIZE_MB, 4);
/**
- * if testcase has zk error,just try 0 time for fast running
+ * if testcase has zk error,just try 3 time for fast running
*/
- confReturn.setZkRetryBackoffMaxRetries(0);
+ confReturn.setZkRetryBackoffMaxRetries(3);
Review Comment:
Removing this configuration is better because the default value is Integer.MAX_VALUE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1170650537
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1170085379
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1171827299
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1171895207
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1171949134
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1172051767
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3376: fix testcase problem: always run fail for zk connect
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#issuecomment-1171871240
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org