You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ojb-dev@db.apache.org by to...@apache.org on 2004/04/06 22:37:38 UTC

cvs commit: db-ojb/src/java/org/apache/ojb/broker/accesslayer IndirectionHandler.java

tomdz       2004/04/06 13:37:38

  Modified:    src/java/org/apache/ojb/broker/accesslayer
                        IndirectionHandler.java
  Log:
  Undid a previous fix that implemented specific toString handling for proxies that did not materialize them; since the toString method should be a normal business method, the special ProxyHelper.toString method should be used in situations where materialization of the proxy is not desired
  
  Revision  Changes    Path
  1.26      +10 -3     db-ojb/src/java/org/apache/ojb/broker/accesslayer/IndirectionHandler.java
  
  Index: IndirectionHandler.java
  ===================================================================
  RCS file: /home/cvs/db-ojb/src/java/org/apache/ojb/broker/accesslayer/IndirectionHandler.java,v
  retrieving revision 1.25
  retrieving revision 1.26
  diff -u -r1.25 -r1.26
  --- IndirectionHandler.java	4 Apr 2004 23:53:30 -0000	1.25
  +++ IndirectionHandler.java	6 Apr 2004 20:37:38 -0000	1.26
  @@ -235,12 +235,19 @@
                   return new Integer(id.hashCode());
               }
   
  -            // handle toString differently for non-materialized proxies
  -            // to avoid materialization due to logging.
  +            // [tomdz]
  +            // this would handle toString differently for non-materialized proxies
  +            // (to avoid materialization due to logging)
  +            // however toString should be a normal business method which
  +            // materializes the proxy
  +            // if this is not desired, then the ProxyHandler.toString(Object) method
  +            // should be used instead (e.g. for logging within OJB)
  +            /*
               if ((realSubject == null) && "toString".equals(methodName))
               {
                   return "unmaterialized proxy for " + id;
               }
  +            */
   
               subject = getRealSubject();
               return method.invoke(subject, args);
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org