You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/10 17:28:10 UTC
[GitHub] [dolphinscheduler] EricGao888 opened a new issue, #11405: [Improvement][Test] Remove dependency of powermock
EricGao888 opened a new issue, #11405:
URL: https://github.com/apache/dolphinscheduler/issues/11405
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
* As stated in https://github.com/apache/dolphinscheduler/issues/10976#issuecomment-1207427898, `Powermock` does not and will not support `jUnit 5`. We need to remove the dependency on `Powermock`.
* One possible way is to use a high version (greater than 3.4.0) of `Mockito` to mock `static` method, see: https://wttech.blog/blog/2020/mocking-static-methods-made-possible-in-mockito-3.4.0/
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #11405: [Improvement][Test] Remove dependency of powermock
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #11405:
URL: https://github.com/apache/dolphinscheduler/issues/11405#issuecomment-1255986382
I will try to finish all the sub-tasks in Sept. and Oct. However, anyone interested and willing to help are very welcome to pick those sub-tasks. To help with this issue, just create an issue for the sub-task you want to pick and comment with the issue link below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 closed issue #11405: [Improvement][Test] Remove dependency of powermock
Posted by GitBox <gi...@apache.org>.
EricGao888 closed issue #11405: [Improvement][Test] Remove dependency of powermock
URL: https://github.com/apache/dolphinscheduler/issues/11405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #11405: [Improvement][Test] Remove dependency of powermock
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #11405:
URL: https://github.com/apache/dolphinscheduler/issues/11405#issuecomment-1211572090
FYI here is a list of UT files which uses `Powermock`:
```txt
Found Occurrences in Directory dolphinscheduler with mask '*.java' (192 usages found)
Unclassified (192 usages found)
dolphinscheduler-alert-server (1 usage found)
org.apache.dolphinscheduler.alert (1 usage found)
AlertServerTest.java (1 usage found)
dolphinscheduler-api (27 usages found)
org.apache.dolphinscheduler.api.controller (5 usages found)
DataAnalysisControllerTest.java (1 usage found)
ProcessInstanceControllerTest.java (1 usage found)
ProcessTaskRelationControllerTest.java (1 usage found)
ResourcesControllerTest.java (1 usage found)
WorkerGroupControllerTest.java (1 usage found)
org.apache.dolphinscheduler.api.interceptor (2 usages found)
RateLimitInterceptorTest.java (2 usages found)
org.apache.dolphinscheduler.api.service (20 usages found)
BaseServiceTest.java (3 usages found)
DataAnalysisServiceTest.java (2 usages found)
DataSourceServiceTest.java (4 usages found)
LoggerServiceTest.java (1 usage found)
ResourcesServiceTest.java (4 usages found)
SchedulerServiceTest.java (2 usages found)
TenantServiceTest.java (1 usage found)
UdfFuncServiceTest.java (3 usages found)
dolphinscheduler-common (10 usages found)
org.apache.dolphinscheduler.common.utils (10 usages found)
CommonUtilsTest.java (2 usages found)
FileUtilsTest.java (3 usages found)
HadoopUtilsTest.java (4 usages found)
NetUtilsTest.java (1 usage found)
dolphinscheduler-datasource-api (9 usages found)
org.apache.dolphinscheduler.plugin.datasource.api.client (4 usages found)
CommonDataSourceClientTest.java (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.api.utils (5 usages found)
CommonUtilsTest.java (5 usages found)
dolphinscheduler-datasource-clickhouse (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.clickhouse (4 usages found)
ClickHouseDataSourceChannelTest.java (4 usages found)
dolphinscheduler-datasource-db2 (7 usages found)
org.apache.dolphinscheduler.plugin.datasource.db2 (4 usages found)
DB2DataSourceChannelTest.java (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.db2.param (3 usages found)
Db2DataSourceProcessorTest.java (3 usages found)
dolphinscheduler-datasource-hive (7 usages found)
org.apache.dolphinscheduler.plugin.datasource.hive (4 usages found)
HiveDataSourceChannelTest.java (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.hive.param (3 usages found)
HiveDataSourceProcessorTest.java (3 usages found)
dolphinscheduler-datasource-mysql (14 usages found)
org.apache.dolphinscheduler.plugin.datasource.mysql (4 usages found)
MySQLDataSourceChannelTest.java (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.mysql.param (3 usages found)
MySQLDataSourceProcessorTest.java (3 usages found)
org.apache.dolphinscheduler.plugin.datasource.mysql.provider (3 usages found)
JDBCDataSourceProviderTest.java (3 usages found)
org.apache.dolphinscheduler.plugin.datasource.mysql.utils (4 usages found)
DataSourceUtilsTest.java (4 usages found)
dolphinscheduler-datasource-oracle (7 usages found)
org.apache.dolphinscheduler.plugin.datasource.oracle (4 usages found)
OracleDataSourceChannelTest.java (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.oracle.param (3 usages found)
OracleDataSourceProcessorTest.java (3 usages found)
dolphinscheduler-datasource-postgresql (7 usages found)
org.apache.dolphinscheduler.plugin.datasource.postgresql (4 usages found)
PostgreSQLDataSourceChannelTest.java (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.postgresql.param (3 usages found)
PostgreSQLDataSourceProcessorTest.java (3 usages found)
dolphinscheduler-datasource-presto (7 usages found)
org.apache.dolphinscheduler.plugin.datasource.presto (4 usages found)
PrestoDataSourceChannelTest.java (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.presto.param (3 usages found)
PrestoDataSourceProcessorTest.java (3 usages found)
dolphinscheduler-datasource-redshift (3 usages found)
org.apache.dolphinscheduler.plugin.datasource.redshift.param (3 usages found)
RedshiftDataSourceProcessorTest.java (3 usages found)
dolphinscheduler-datasource-spark (7 usages found)
org.apache.dolphinscheduler.plugin.datasource.spark (4 usages found)
SparkDataSourceChannelTest.java (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.spark.param (3 usages found)
SparkDataSourceProcessorTest.java (3 usages found)
dolphinscheduler-datasource-sqlserver (7 usages found)
org.apache.dolphinscheduler.plugin.datasource.sqlserver (4 usages found)
SQLServerDataSourceChannelTest.java (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.sqlserver.param (3 usages found)
SQLServerDataSourceProcessorTest.java (3 usages found)
dolphinscheduler-log-server (3 usages found)
org.apache.dolphinscheduler.server.log (3 usages found)
LoggerRequestProcessorTest.java (3 usages found)
dolphinscheduler-master (18 usages found)
org.apache.dolphinscheduler.server.master (3 usages found)
SubProcessTaskTest.java (3 usages found)
org.apache.dolphinscheduler.server.master.processor (5 usages found)
CacheProcessorTest.java (1 usage found)
TaskAckProcessorTest.java (3 usages found)
TaskKillResponseProcessorTest.java (1 usage found)
org.apache.dolphinscheduler.server.master.registry (3 usages found)
MasterRegistryClientTest.java (3 usages found)
org.apache.dolphinscheduler.server.master.runner (4 usages found)
MasterTaskExecThreadTest.java (1 usage found)
WorkflowExecuteRunnableTest.java (3 usages found)
org.apache.dolphinscheduler.server.master.service (3 usages found)
FailoverServiceTest.java (3 usages found)
dolphinscheduler-server (4 usages found)
org.apache.dolphinscheduler.server.utils (4 usages found)
ProcessUtilsTest.java (4 usages found)
dolphinscheduler-service (8 usages found)
org.apache.dolphinscheduler.service.alert (4 usages found)
AlertClientServiceTest.java (3 usages found)
ProcessAlertManagerTest.java (1 usage found)
org.apache.dolphinscheduler.service.log (3 usages found)
LogClientServiceTest.java (3 usages found)
org.apache.dolphinscheduler.service.process (1 usage found)
ProcessServiceTest.java (1 usage found)
dolphinscheduler-task-dvc (5 usages found)
org.apache.dolphinscheduler.plugin.task.dvc (5 usages found)
DvcTaskTest.java (5 usages found)
dolphinscheduler-task-emr (8 usages found)
org.apache.dolphinscheduler.plugin.task.emr (8 usages found)
EmrAddStepsTaskTest.java (4 usages found)
EmrJobFlowTaskTest.java (4 usages found)
dolphinscheduler-task-jupyter (5 usages found)
org.apache.dolphinscheduler.plugin.task.jupyter (5 usages found)
JupyterTaskTest.java (5 usages found)
dolphinscheduler-task-mlflow (5 usages found)
org.apache.dolphinler.plugin.task.mlflow (5 usages found)
MlflowTaskTest.java (5 usages found)
dolphinscheduler-task-openmldb (1 usage found)
org.apache.dolphinscheduler.plugin.task.openmldb (1 usage found)
OpenmldbTaskTest.java (1 usage found)
dolphinscheduler-task-python (1 usage found)
org.apache.dolphinscheduler.plugin.task.python (1 usage found)
PythonTaskTest.java (1 usage found)
dolphinscheduler-task-sagemaker (5 usages found)
org.apache.dolphinscheduler.plugin.task.sagemaker (5 usages found)
SagemakerTaskTest.java (5 usages found)
dolphinscheduler-task-spark (4 usages found)
org.apache.dolphinscheduler.plugin.task.spark (4 usages found)
SparkTaskTest.java (4 usages found)
dolphinscheduler-task-zeppelin (4 usages found)
org.apache.dolphinscheduler.plugin.task.zeppelin (4 usages found)
ZeppelinTaskTest.java (4 usages found)
dolphinscheduler-worker (4 usages found)
org.apache.dolphinscheduler.server.worker.processor (3 usages found)
TaskDispatchProcessorTest.java (3 usages found)
org.apache.dolphinscheduler.server.worker.runner (1 usage found)
TaskExecuteThreadTest.java (1 usage found)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #11405: [Improvement][Test] Remove dependency of powermock
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #11405:
URL: https://github.com/apache/dolphinscheduler/issues/11405#issuecomment-1257860110
> Are you fixing the dolphinscheduler-common module @EricGao888
Yes, I will take care of the rest ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11405: [Improvement][Test] Remove dependency of powermock
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11405:
URL: https://github.com/apache/dolphinscheduler/issues/11405#issuecomment-1211028440
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on issue #11405: [Improvement][Test] Remove dependency of powermock
Posted by GitBox <gi...@apache.org>.
fuchanghai commented on issue #11405:
URL: https://github.com/apache/dolphinscheduler/issues/11405#issuecomment-1257816606
Are you fixing the dolphinscheduler-common module @EricGao888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org