You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ijuma (via GitHub)" <gi...@apache.org> on 2023/02/26 20:12:05 UTC
[GitHub] [kafka] ijuma opened a new pull request, #13311: MINOR: Enable spotless for streams-scala when Java 11+ is used
ijuma opened a new pull request, #13311:
URL: https://github.com/apache/kafka/pull/13311
Also re-enable it in CI. We do this by adjusting the `Jenkinsfile` to use a more general task (`./gradlew check -x test`).
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma merged pull request #13311: MINOR: Enable spotless for streams-scala when Java 11+ is used
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma merged PR #13311:
URL: https://github.com/apache/kafka/pull/13311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a diff in pull request #13311: MINOR: Enable spotless for streams-scala when Java 11+ is used
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on code in PR #13311:
URL: https://github.com/apache/kafka/pull/13311#discussion_r1118150302
##########
build.gradle:
##########
@@ -2116,6 +2109,17 @@ project(':streams:streams-scala') {
dependsOn 'copyDependantLibs'
}
+ // spotless 6.14 requires Java 11 at runtime
+ if (JavaVersion.current().isJava11Compatible()) {
Review Comment:
CI will check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a diff in pull request #13311: MINOR: Enable spotless for streams-scala when Java 11+ is used
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on code in PR #13311:
URL: https://github.com/apache/kafka/pull/13311#discussion_r1118155329
##########
build.gradle:
##########
@@ -2116,6 +2109,17 @@ project(':streams:streams-scala') {
dependsOn 'copyDependantLibs'
}
+ // spotless 6.14 requires Java 11 at runtime
+ if (JavaVersion.current().isJava11Compatible()) {
Review Comment:
I mean, developers don't have to use Java 11. They can rely on CI for the rare case where this module is being updated and they didn't follow the style rules. It is more practical to use Java 11 or newer though. I don't think it's a problem - Java 8 support is more for deployments than for contributors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a diff in pull request #13311: MINOR: Enable spotless for streams-scala when Java 11+ is used
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #13311:
URL: https://github.com/apache/kafka/pull/13311#discussion_r1118148218
##########
build.gradle:
##########
@@ -2116,6 +2109,17 @@ project(':streams:streams-scala') {
dependsOn 'copyDependantLibs'
}
+ // spotless 6.14 requires Java 11 at runtime
+ if (JavaVersion.current().isJava11Compatible()) {
Review Comment:
Does it imply the developers who want to contribute code to streams-scala must use JDK11 as our Ci will check that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13311: MINOR: Enable spotless for streams-scala when Java 11+ is used
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #13311:
URL: https://github.com/apache/kafka/pull/13311#issuecomment-1445676471
CI build looks good, there were unrelated failures. Restarted just in case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org