[PR] Tighten blocker proof gates [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu opened a new pull request, #38944:
URL: https://github.com/apache/shardingsphere/pull/38944

   - add a correct-mergeability principle and blocker proof gate
   - add focused gates for test coverage, native metadata, and release-note necessity
   - require confirmed ledger findings to record proof, counter-evidence, necessity, and PR scope


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Tighten blocker proof gates [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu merged PR #38944:
URL: https://github.com/apache/shardingsphere/pull/38944


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Tighten blocker proof gates [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu commented on PR #38944:
URL: https://github.com/apache/shardingsphere/pull/38944#issuecomment-4826543081

   ### Summary
   
   **Review Result: Mergeable**
   
   Reason: The PR is scoped to the `review-pr` skill and its ledger helper. It adds the intended blocker-proof discipline, keeps the full-coverage review path, and the ledger helper now enforces the new proof fields for confirmed findings.
   
   ### Evidence
   
   - The PR scope is limited to:
     - `.codex/skills/review-pr/SKILL.md`
     - `.codex/skills/review-pr/scripts/review_ledger.py`
   - The skill now clearly separates candidate concerns from confirmed blockers through `Core Verdict Principle`, `Blocker Proof Gate`, and specialized mini-gates for test coverage, generated/native metadata, and docs/release-note necessity.
   - `Full Coverage Ledger Mode` remains available and is strengthened: confirmed findings must record direct evidence, counter-evidence checked, necessity, scope proof, and the proof-gate result.
   - `review_ledger.py` now stores the new fields and rejects confirmed findings that lack proof-gate closure.
   - Local PR-head validation passed:
     - Python syntax compile for `review_ledger.py`
     - `add-finding --help`
     - negative ledger case: incomplete confirmed finding fails validation as expected
     - positive ledger case: fully documented confirmed finding passes validation
     - line-length check for changed PR-head files
     - `git diff --check`
   - GitHub check-runs inspected for head `95ae5802501540400d5b8b08d8ad8cbbc4c06fa3`: Spotless, License, CheckStyle, and changed-file detection succeeded. E2E jobs were skipped, which is reasonable for this `.codex` skill-only change.
   
   ### Review Details
   
   Reviewed Scope: Latest PR head `95ae5802501540400d5b8b08d8ad8cbbc4c06fa3`; base `master` at `1c3c0f336c4ef6d52038f48e2179e5829697bc63`; local merge-base matched the base SHA. Local triple-dot file list matched GitHub `/pulls/38944/files`.
   
   Not Reviewed Scope: Runtime ShardingSphere production code, parser behavior, JDBC/Proxy behavior, and E2E runtime behavior, because this PR only changes Codex review-skill files.
   
   Verification: `git fetch` exit 0; `git diff --check` exit 0; PR-head Python compile/help checks exit 0; ledger negative/positive validation exit 0; GitHub reviews/comments endpoints showed no prior review rounds or comments.
   
   Release Note / User Docs: Not required. This is internal Codex review-skill behavior, not a ShardingSphere user-facing release behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org