You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/12 22:00:49 UTC

[GitHub] [incubator-superset] mistercrunch opened a new pull request #11242: docs: don't link to database engine pages

mistercrunch opened a new pull request #11242:
URL: https://github.com/apache/incubator-superset/pull/11242


   Per ASF raised concerned, removing links to database pages from our main docs page


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11242: docs: don't link to database engine pages

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11242:
URL: https://github.com/apache/incubator-superset/pull/11242#issuecomment-707372073


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=h1) Report
   > Merging [#11242](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11242/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11242      +/-   ##
   ==========================================
   - Coverage   61.39%   61.39%   -0.01%     
   ==========================================
     Files         832      832              
     Lines       39390    39391       +1     
     Branches     3592     3592              
   ==========================================
     Hits        24184    24184              
   - Misses      15025    15026       +1     
     Partials      181      181              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.40% <ø> (ø)` | |
   | #python | `60.79% <ø> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.74% <0.00%> (-0.17%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.52% <0.00%> (+0.07%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=footer). Last update [dcdf15f...5241d4c](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on a change in pull request #11242: docs: don't link to database engine pages

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11242:
URL: https://github.com/apache/incubator-superset/pull/11242#discussion_r503693597



##########
File path: docs/src/pages/index.tsx
##########
@@ -445,44 +446,34 @@ const Theme = () => {
                 </div>
               </Carousel>
             </div>
-          </div>
-          <div css={integrationSection}>
-            <h2 css={secondaryHeading}>Supported Databases</h2>
+            <div css={integrationSection}>
+              <h2 css={secondaryHeading}>Supported Databases</h2>
 
-            <ul className="database-list">
-              {Databases.map(
-                ({
-                  title, href, imgName: imageName, width, height,
-                }) => (
-                  <a
-                    href={href}
-                    target="_blank"
-                    key={imageName}
-                    rel="noreferrer nofollow"
-                  >
-                    <DbImage
-                      {...{
-                        imageName,
-                        width,
-                        height,
-                        alt: title,
-                      }}
-                    />
-                  </a>
-                ),
-              )}
-            </ul>
-            <span className="databaseSub">
-              {' '}
-              ... and any other SQLAlchemy
-              {' '}
-              <a href="https://superset.incubator.apache.org/installation.html#database-dependencies">
-                {' '}
-                compatible databases
-                {' '}
-              </a>
-              {' '}
-            </span>
+              <ul className="database-list">
+                {Databases.map(
+                  ({
+                    title, href, imgName: imageName, width, height,
+                  }) => (
+                    <li>
+                      <DbImage
+                        {...{
+                          imageName,
+                          width,
+                          height,
+                          alt: title,
+                        }}
+                      />
+                    </li>
+                  ),
+                )}
+              </ul>
+              <span className="databaseSub">
+                ... and any other
+                <a href="https://superset.incubator.apache.org/installation.html#database-dependencies">

Review comment:
       Seems perfectly reasonable to me. Making the change on behalf of @mistercrunch - feel free to roll it back if you're not into it ;)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11242: docs: don't link to database engine pages

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11242:
URL: https://github.com/apache/incubator-superset/pull/11242#issuecomment-707372073


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=h1) Report
   > Merging [#11242](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **increase** coverage by `4.16%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11242/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11242      +/-   ##
   ==========================================
   + Coverage   61.39%   65.56%   +4.16%     
   ==========================================
     Files         832      832              
     Lines       39390    39394       +4     
     Branches     3592     3592              
   ==========================================
   + Hits        24184    25829    +1645     
   + Misses      15025    13456    -1569     
   + Partials      181      109      -72     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.89% <ø> (?)` | |
   | #javascript | `62.40% <ø> (ø)` | |
   | #python | `60.79% <ø> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
   | [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `73.21% <0.00%> (-1.34%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.74% <0.00%> (-0.17%)` | :arrow_down: |
   | [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.52% <0.00%> (+0.07%)` | :arrow_up: |
   | [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `60.75% <0.00%> (+1.26%)` | :arrow_up: |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `79.16% <0.00%> (+1.38%)` | :arrow_up: |
   | [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `36.36% <0.00%> (+1.51%)` | :arrow_up: |
   | [...rset-frontend/src/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `92.30% <0.00%> (+1.53%)` | :arrow_up: |
   | [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (+1.56%)` | :arrow_up: |
   | ... and [167 more](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=footer). Last update [dcdf15f...5241d4c](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io commented on pull request #11242: docs: don't link to database engine pages

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11242:
URL: https://github.com/apache/incubator-superset/pull/11242#issuecomment-707372073


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=h1) Report
   > Merging [#11242](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `1.36%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11242/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11242      +/-   ##
   ==========================================
   - Coverage   61.39%   60.02%   -1.37%     
   ==========================================
     Files         832      394     -438     
     Lines       39390    24699   -14691     
     Branches     3592        0    -3592     
   ==========================================
   - Hits        24184    14826    -9358     
   + Misses      15025     9873    -5152     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `60.02% <ø> (-0.77%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.74% <0.00%> (-1.66%)` | :arrow_down: |
   | ... and [447 more](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=footer). Last update [dcdf15f...5241d4c](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11242: docs: don't link to database engine pages

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11242:
URL: https://github.com/apache/incubator-superset/pull/11242#issuecomment-707372073


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=h1) Report
   > Merging [#11242](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `1.38%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11242/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11242      +/-   ##
   ==========================================
   - Coverage   61.39%   60.01%   -1.39%     
   ==========================================
     Files         832      394     -438     
     Lines       39390    24710   -14680     
     Branches     3592        0    -3592     
   ==========================================
   - Hits        24184    14829    -9355     
   + Misses      15025     9881    -5144     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `60.01% <ø> (-0.79%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.74% <0.00%> (-1.66%)` | :arrow_down: |
   | ... and [443 more](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=footer). Last update [dcdf15f...5241d4c](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11242: docs: don't link to database engine pages

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11242:
URL: https://github.com/apache/incubator-superset/pull/11242#issuecomment-707372073


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=h1) Report
   > Merging [#11242](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **increase** coverage by `4.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11242/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11242      +/-   ##
   ==========================================
   + Coverage   61.39%   65.42%   +4.02%     
   ==========================================
     Files         832      832              
     Lines       39390    39394       +4     
     Branches     3592     3592              
   ==========================================
   + Hits        24184    25773    +1589     
   + Misses      15025    13508    -1517     
   + Partials      181      113      -68     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.24% <ø> (?)` | |
   | #javascript | `62.40% <ø> (ø)` | |
   | #python | `60.79% <ø> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
   | [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `73.21% <0.00%> (-1.34%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.74% <0.00%> (-0.17%)` | :arrow_down: |
   | [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.52% <0.00%> (+0.07%)` | :arrow_up: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (+0.64%)` | :arrow_up: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `52.12% <0.00%> (+1.21%)` | :arrow_up: |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `79.16% <0.00%> (+1.38%)` | :arrow_up: |
   | [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `36.36% <0.00%> (+1.51%)` | :arrow_up: |
   | [...rset-frontend/src/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `92.30% <0.00%> (+1.53%)` | :arrow_up: |
   | ... and [165 more](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=footer). Last update [dcdf15f...5241d4c](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11242: docs: don't link to database engine pages

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11242:
URL: https://github.com/apache/incubator-superset/pull/11242#issuecomment-707372073


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=h1) Report
   > Merging [#11242](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `1.32%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11242/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11242      +/-   ##
   ==========================================
   - Coverage   61.39%   60.06%   -1.33%     
   ==========================================
     Files         832      394     -438     
     Lines       39390    24710   -14680     
     Branches     3592        0    -3592     
   ==========================================
   - Hits        24184    14843    -9341     
   + Misses      15025     9867    -5158     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `60.06% <ø> (-0.73%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.06% <0.00%> (-0.84%)` | :arrow_down: |
   | ... and [441 more](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=footer). Last update [dcdf15f...5241d4c](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch commented on pull request #11242: docs: don't link to database engine pages

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #11242:
URL: https://github.com/apache/incubator-superset/pull/11242#issuecomment-708010969


   Merged! thanks you 2!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #11242: docs: don't link to database engine pages

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11242:
URL: https://github.com/apache/incubator-superset/pull/11242#discussion_r503567935



##########
File path: docs/src/pages/index.tsx
##########
@@ -445,44 +446,34 @@ const Theme = () => {
                 </div>
               </Carousel>
             </div>
-          </div>
-          <div css={integrationSection}>
-            <h2 css={secondaryHeading}>Supported Databases</h2>
+            <div css={integrationSection}>
+              <h2 css={secondaryHeading}>Supported Databases</h2>
 
-            <ul className="database-list">
-              {Databases.map(
-                ({
-                  title, href, imgName: imageName, width, height,
-                }) => (
-                  <a
-                    href={href}
-                    target="_blank"
-                    key={imageName}
-                    rel="noreferrer nofollow"
-                  >
-                    <DbImage
-                      {...{
-                        imageName,
-                        width,
-                        height,
-                        alt: title,
-                      }}
-                    />
-                  </a>
-                ),
-              )}
-            </ul>
-            <span className="databaseSub">
-              {' '}
-              ... and any other SQLAlchemy
-              {' '}
-              <a href="https://superset.incubator.apache.org/installation.html#database-dependencies">
-                {' '}
-                compatible databases
-                {' '}
-              </a>
-              {' '}
-            </span>
+              <ul className="database-list">
+                {Databases.map(
+                  ({
+                    title, href, imgName: imageName, width, height,
+                  }) => (
+                    <li>
+                      <DbImage
+                        {...{
+                          imageName,
+                          width,
+                          height,
+                          alt: title,
+                        }}
+                      />
+                    </li>
+                  ),
+                )}
+              </ul>
+              <span className="databaseSub">
+                ... and any other
+                <a href="https://superset.incubator.apache.org/installation.html#database-dependencies">

Review comment:
       Can we update this link to https://superset.apache.org/docs/databases/installing-database-drivers as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11242: docs: don't link to database engine pages

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11242:
URL: https://github.com/apache/incubator-superset/pull/11242#issuecomment-707372073


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=h1) Report
   > Merging [#11242](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `1.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11242/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11242      +/-   ##
   ==========================================
   - Coverage   61.39%   60.38%   -1.02%     
   ==========================================
     Files         832      394     -438     
     Lines       39390    24710   -14680     
     Branches     3592        0    -3592     
   ==========================================
   - Hits        24184    14920    -9264     
   + Misses      15025     9790    -5235     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `60.38% <ø> (-0.42%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.74% <0.00%> (-0.17%)` | :arrow_down: |
   | [...end/src/components/Select/WindowedSelect/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L2luZGV4LnRzeA==) | | |
   | [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | | |
   | [superset-frontend/src/components/ListView/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvaW5kZXgudHM=) | | |
   | [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | | |
   | [superset-frontend/src/components/AnchorLink.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQW5jaG9yTGluay5qc3g=) | | |
   | [superset-frontend/src/setup/setupClient.js](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ2xpZW50Lmpz) | | |
   | ... and [433 more](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=footer). Last update [dcdf15f...5241d4c](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11242: docs: don't link to database engine pages

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11242:
URL: https://github.com/apache/incubator-superset/pull/11242#issuecomment-707372073


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=h1) Report
   > Merging [#11242](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `1.04%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11242/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11242      +/-   ##
   ==========================================
   - Coverage   61.39%   60.35%   -1.05%     
   ==========================================
     Files         832      394     -438     
     Lines       39390    24710   -14680     
     Branches     3592        0    -3592     
   ==========================================
   - Hits        24184    14914    -9270     
   + Misses      15025     9796    -5229     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `60.35% <ø> (-0.44%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.74% <0.00%> (-0.17%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Column.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NvbHVtbi5qc3g=) | | |
   | [superset-frontend/src/SqlLab/reducers/common.js](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9jb21tb24uanM=) | | |
   | [superset-frontend/src/common/components/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRz) | | |
   | ... and [436 more](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=footer). Last update [dcdf15f...5241d4c](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on pull request #11242: docs: don't link to database engine pages

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #11242:
URL: https://github.com/apache/incubator-superset/pull/11242#issuecomment-707518332


   Excited to see this one go through, @mistercrunch so I made the edit @ktmud suggested, and fixed up the linting so it'll pass CI.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch merged pull request #11242: docs: don't link to database engine pages

Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #11242:
URL: https://github.com/apache/incubator-superset/pull/11242


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11242: docs: don't link to database engine pages

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11242:
URL: https://github.com/apache/incubator-superset/pull/11242#issuecomment-707372073


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=h1) Report
   > Merging [#11242](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `0.26%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11242/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11242      +/-   ##
   ==========================================
   - Coverage   61.39%   61.13%   -0.27%     
   ==========================================
     Files         832      832              
     Lines       39390    39391       +1     
     Branches     3592     3592              
   ==========================================
   - Hits        24184    24082     -102     
   - Misses      15025    15128     +103     
     Partials      181      181              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.40% <ø> (ø)` | |
   | #python | `60.38% <ø> (-0.42%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.74% <0.00%> (-0.17%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11242/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.52% <0.00%> (+0.07%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=footer). Last update [dcdf15f...5241d4c](https://codecov.io/gh/apache/incubator-superset/pull/11242?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org