You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "villebro (via GitHub)" <gi...@apache.org> on 2023/09/13 15:55:56 UTC

[GitHub] [superset] villebro commented on a diff in pull request #25282: fix(nativeFilters): Speed up native filters by removing unnecessary rerenders

villebro commented on code in PR #25282:
URL: https://github.com/apache/superset/pull/25282#discussion_r1324733271


##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx:
##########
@@ -123,6 +123,7 @@ const FilterBar: React.FC<FiltersBarProps> = ({
   verticalConfig,
   hidden = false,
 }) => {
+  console.log('rerender');

Review Comment:
   Oops
   ```suggestion
     console.log('rerender');
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org