You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by GitBox <gi...@apache.org> on 2022/11/08 13:29:16 UTC
[GitHub] [axis-axis2-java-core] yoadey opened a new pull request, #384: AXIS2-6049 static serialVersionUID for Exception
yoadey opened a new pull request, #384:
URL: https://github.com/apache/axis-axis2-java-core/pull/384
serialVersionUID would change every generation and won't be useful then. Also not needed for SOAP. Use static 1L as serialVersionUID for Exception. This also allows build caches to be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[GitHub] [axis-axis2-java-core] veithen commented on pull request #384: AXIS2-6049 static serialVersionUID for Exception
Posted by GitBox <gi...@apache.org>.
veithen commented on PR #384:
URL: https://github.com/apache/axis-axis2-java-core/pull/384#issuecomment-1307856104
Looks like there is a problem with this change because tests are failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[GitHub] [axis-axis2-java-core] codecov-commenter commented on pull request #384: AXIS2-6049 static serialVersionUID for Exception
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #384:
URL: https://github.com/apache/axis-axis2-java-core/pull/384#issuecomment-1320850126
# [Codecov](https://codecov.io/gh/apache/axis-axis2-java-core/pull/384?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#384](https://codecov.io/gh/apache/axis-axis2-java-core/pull/384?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (02669a3) into [master](https://codecov.io/gh/apache/axis-axis2-java-core/commit/ecfe305a0a26e73d14d1e0c4c9c4b291e8dc5784?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ecfe305) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #384 +/- ##
=======================================
Coverage 42.56% 42.56%
=======================================
Files 1500 1500
Lines 115008 115011 +3
Branches 22586 22587 +1
=======================================
+ Hits 48958 48960 +2
+ Misses 58290 58288 -2
- Partials 7760 7763 +3
```
| [Impacted Files](https://codecov.io/gh/apache/axis-axis2-java-core/pull/384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../emitter/AxisServiceBasedMultiLanguageEmitter.java](https://codecov.io/gh/apache/axis-axis2-java-core/pull/384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kdWxlcy9jb2RlZ2VuL3NyYy9vcmcvYXBhY2hlL2F4aXMyL3dzZGwvY29kZWdlbi9lbWl0dGVyL0F4aXNTZXJ2aWNlQmFzZWRNdWx0aUxhbmd1YWdlRW1pdHRlci5qYXZh) | `54.70% <100.00%> (ø)` | |
| [...port/http/server/DefaultHttpConnectionManager.java](https://codecov.io/gh/apache/axis-axis2-java-core/pull/384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kdWxlcy90cmFuc3BvcnQvaHR0cC9zcmMvb3JnL2FwYWNoZS9heGlzMi90cmFuc3BvcnQvaHR0cC9zZXJ2ZXIvRGVmYXVsdEh0dHBDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `66.17% <0.00%> (-2.95%)` | :arrow_down: |
| [...ransport/http/impl/httpclient4/HTTPSenderImpl.java](https://codecov.io/gh/apache/axis-axis2-java-core/pull/384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kdWxlcy90cmFuc3BvcnQvaHR0cC9zcmMvb3JnL2FwYWNoZS9heGlzMi90cmFuc3BvcnQvaHR0cC9pbXBsL2h0dHBjbGllbnQ0L0hUVFBTZW5kZXJJbXBsLmphdmE=) | `82.60% <0.00%> (-2.18%)` | :arrow_down: |
| [...jaxws/marshaller/impl/alt/LegacyExceptionUtil.java](https://codecov.io/gh/apache/axis-axis2-java-core/pull/384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kdWxlcy9qYXh3cy9zcmMvb3JnL2FwYWNoZS9heGlzMi9qYXh3cy9tYXJzaGFsbGVyL2ltcGwvYWx0L0xlZ2FjeUV4Y2VwdGlvblV0aWwuamF2YQ==) | `77.31% <0.00%> (-0.85%)` | :arrow_down: |
| [...apache/axis2/kernel/http/SOAPMessageFormatter.java](https://codecov.io/gh/apache/axis-axis2-java-core/pull/384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kdWxlcy9rZXJuZWwvc3JjL29yZy9hcGFjaGUvYXhpczIva2VybmVsL2h0dHAvU09BUE1lc3NhZ2VGb3JtYXR0ZXIuamF2YQ==) | `84.76% <0.00%> (+0.44%)` | :arrow_up: |
| [...rnel/src/org/apache/axis2/builder/BuilderUtil.java](https://codecov.io/gh/apache/axis-axis2-java-core/pull/384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kdWxlcy9rZXJuZWwvc3JjL29yZy9hcGFjaGUvYXhpczIvYnVpbGRlci9CdWlsZGVyVXRpbC5qYXZh) | `49.60% <0.00%> (+1.18%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[GitHub] [axis-axis2-java-core] yoadey commented on pull request #384: AXIS2-6049 static serialVersionUID for Exception
Posted by GitBox <gi...@apache.org>.
yoadey commented on PR #384:
URL: https://github.com/apache/axis-axis2-java-core/pull/384#issuecomment-1330194449
@veithen could you take a look at this PR whether it's ok and merge it if nothing is preventing it? Would help us a lot to improve build time and make more reproducable builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[GitHub] [axis-axis2-java-core] veithen closed pull request #384: AXIS2-6049 static serialVersionUID for Exception
Posted by GitBox <gi...@apache.org>.
veithen closed pull request #384: AXIS2-6049 static serialVersionUID for Exception
URL: https://github.com/apache/axis-axis2-java-core/pull/384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org