You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/01/25 09:57:44 UTC

[GitHub] [iceberg] singhpk234 opened a new pull request #3979: Handle CaseSenstivity in runtimeFiltering of Spark

singhpk234 opened a new pull request #3979:
URL: https://github.com/apache/iceberg/pull/3979


   Closes #3978


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on pull request #3979: Spark: Handle CaseSenstivity in runtimeFiltering of Spark

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3979:
URL: https://github.com/apache/iceberg/pull/3979#issuecomment-1024585288


   @jackye1995 should this be in the 0.13.0 release?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue merged pull request #3979: Spark: Handle CaseSenstivity in runtimeFiltering of Spark

Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #3979:
URL: https://github.com/apache/iceberg/pull/3979


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] kbendick commented on a change in pull request #3979: Spark: Handle CaseSenstivity in runtimeFiltering of Spark

Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #3979:
URL: https://github.com/apache/iceberg/pull/3979#discussion_r792204394



##########
File path: spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestRuntimeFiltering.java
##########
@@ -177,13 +177,21 @@ public void testMultipleRuntimeFilters() throws NoSuchTableException {
         "SELECT f.* FROM %s f JOIN dim d ON f.id = d.id AND f.data = d.data AND d.date = DATE '1970-01-02'",
         tableName);
 
+    String caseInsensitiveQuery = String.format(
+        "SELECT f.* FROM %s f JOIN dim d ON f.Id = d.id AND f.Data = d.data AND d.date = DATE '1970-01-02'",

Review comment:
       Can you please go all out in making this case insensitivity check a bit more clear?
   
   Namely, finding the characters that were different from the above wasn't that quickly obvious.
   
   I would say go wild and make as much of it as you can have funky non-standard casing. Like `select f.* from %s F join dim d ON f.Id = d.iD and f.DaTa = d.dAtA and d.dAtE = date '1970-01--02'`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on pull request #3979: Spark: Handle CaseSenstivity in runtimeFiltering of Spark

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3979:
URL: https://github.com/apache/iceberg/pull/3979#issuecomment-1024585042


   Thanks, @singhpk234. Good catch!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org