[jira] [Commented] (VFS-620) FileObject.moveTo(FileObject) API doesn't work well for a Linux FTP

["stevezhuang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VFS-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402725#comment-15402725 ] 

stevezhuang commented on VFS-620:
---------------------------------

Suggested fix,

In the FtpClient.java, adding a new interface,
String printWorkingDirectory() throws IOException; 

Then in the FTPClientWrapper.java,
@Override 
 public String printWorkingDirectory() throws IOException  
 { 
    return getFtpClient().printWorkingDirectory(); 
} 

private String remoteAbsolutePath(String path) throws IOException  
{
    String workingDir = printWorkingDirectory(); 
    if ("/".equals(workingDir)) { 
        return path; 
    }
    return workingDir + path; 
}

@Override
    public boolean rename(final String oldName, final String newName) throws IOException
    {
        try
        {
            return getFtpClient().rename(remoteAbsolutePath(oldName), remoteAbsolutePath(newName));
        }
        catch (final IOException e)
        {
            disconnect();
            return getFtpClient().rename(remoteAbsolutePath(oldName), remoteAbsolutePath(newName));
        }
    }

> FileObject.moveTo(FileObject) API doesn't work well for a Linux FTP
> -------------------------------------------------------------------
>
>                 Key: VFS-620
>                 URL: https://issues.apache.org/jira/browse/VFS-620
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.1
>         Environment: ubuntu vsftpd
>            Reporter: stevezhuang
>
> FileObject.moveTo(FileObject) API doesn't work well for a Linux FTP, especially for setting a user directory as its root directory case,
> For example, for a ubuntu vsftpd, which is having "/home/user1" as its root directory, when renaming "/test/test1.txt" to "/test1/test1.txt", it will throw an exception.
> In this case, it should consider the workingDirectory(would be "/home/user1") together and append it to the from/to path to make the API work.
> Sample codes,
> FileObject fileObject = null;
>         FileObject toFileObject = null;
>         try {
>             StandardFileSystemManager fsManager = new StandardFileSystemManager();
>             fsManager.init();
>             FileSystemOptions fsOpts = new FileSystemOptions();
>             FtpFileSystemConfigBuilder.getInstance().setPassiveMode(fsOpts, true);
>             FtpFileSystemConfigBuilder.getInstance().setUserDirIsRoot(fsOpts, true);
>             UserAuthenticator auth = new StaticUserAuthenticator(null, "*", "*");
>             DefaultFileSystemConfigBuilder.getInstance().setUserAuthenticator(fsOpts, auth);
>             fileObject = fsManager.resolveFile("ftp://*/test/test.txt", fsOpts);
>             System.out.println("File exists:" + fileObject.exists());
>             toFileObject = fsManager.resolveFile("ftp://*/test1/test1.txt", fsOpts);
>             System.out.println("File exists:" + toFileObject.exists());
>             if (!toFileObject.exists()) {
>                 toFileObject.createFile();
>             }
>             fileObject.moveTo(toFileObject);
>         } catch (FileSystemException ex) {
>             ex.printStackTrace();
>         } finally {
>             if (fileObject != null) {
>                 try {
>                     fileObject.close();
>                 } catch (FileSystemException ex) {
>                 }
>             }
>             if (toFileObject != null) {
>                 try {
>                     toFileObject.close();
>                 } catch (FileSystemException ex) {
>                 }
>             }
>         }
> And the output,
> File exists:true
> File exists:false
> org.apache.commons.vfs2.FileSystemException: Could not rename "ftp://*/test/test.txt" to "ftp://*/test1/test1.txt".
> 	at org.apache.commons.vfs2.provider.AbstractFileObject.moveTo(AbstractFileObject.java:1902)
> 	at TestFTP.main(TestFTP.java:59)
> Caused by: org.apache.commons.vfs2.FileSystemException: Could not rename FTP file "ftp://*/test/test.txt" to "ftp://*/test1/test1.txt".
> 	at org.apache.commons.vfs2.provider.ftp.FtpFileObject.doRename(FtpFileObject.java:524)
> 	at org.apache.commons.vfs2.provider.AbstractFileObject.moveTo(AbstractFileObject.java:1887)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)