You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/12 14:30:40 UTC
[GitHub] [shardingsphere] soulasuna opened a new pull request, #22123: Optimize shadow rule configuration
soulasuna opened a new pull request, #22123:
URL: https://github.com/apache/shardingsphere/pull/22123
## Optimize shadow rule configuration
Changes proposed in this pull request:
- Optimize shadow rule configuration
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22123: Optimize shadow rule configuration
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22123:
URL: https://github.com/apache/shardingsphere/pull/22123#issuecomment-1312511735
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22123?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22123](https://codecov.io/gh/apache/shardingsphere/pull/22123?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec55c40) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a2d9dad8b7bd718361d67b507fe292980dd09983?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a2d9dad) will **increase** coverage by `0.09%`.
> The diff coverage is `49.57%`.
```diff
@@ Coverage Diff @@
## master #22123 +/- ##
============================================
+ Coverage 61.05% 61.14% +0.09%
Complexity 2544 2544
============================================
Files 4109 4108 -1
Lines 57270 57176 -94
Branches 9683 9683
============================================
- Hits 34964 34963 -1
+ Misses 19355 19261 -94
- Partials 2951 2952 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../rewrite/condition/impl/EncryptEqualCondition.java](https://codecov.io/gh/apache/shardingsphere/pull/22123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvY29uZGl0aW9uL2ltcGwvRW5jcnlwdEVxdWFsQ29uZGl0aW9uLmphdmE=) | `59.09% <0.00%> (ø)` | |
| [...ypt/rewrite/condition/impl/EncryptInCondition.java](https://codecov.io/gh/apache/shardingsphere/pull/22123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvY29uZGl0aW9uL2ltcGwvRW5jcnlwdEluQ29uZGl0aW9uLmphdmE=) | `65.38% <0.00%> (ø)` | |
| [...t/rewrite/condition/impl/EncryptLikeCondition.java](https://codecov.io/gh/apache/shardingsphere/pull/22123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvY29uZGl0aW9uL2ltcGwvRW5jcnlwdExpa2VDb25kaXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/rewriter/EncryptAssignmentParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/22123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvcGFyYW1ldGVyL3Jld3JpdGVyL0VuY3J5cHRBc3NpZ25tZW50UGFyYW1ldGVyUmV3cml0ZXIuamF2YQ==) | `5.40% <0.00%> (ø)` | |
| [...ertOnDuplicateKeyUpdateValueParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/22123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvcGFyYW1ldGVyL3Jld3JpdGVyL0VuY3J5cHRJbnNlcnRPbkR1cGxpY2F0ZUtleVVwZGF0ZVZhbHVlUGFyYW1ldGVyUmV3cml0ZXIuamF2YQ==) | `2.63% <0.00%> (ø)` | |
| [.../rewriter/EncryptInsertValueParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/22123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvcGFyYW1ldGVyL3Jld3JpdGVyL0VuY3J5cHRJbnNlcnRWYWx1ZVBhcmFtZXRlclJld3JpdGVyLmphdmE=) | `1.92% <0.00%> (ø)` | |
| [...er/rewriter/EncryptPredicateParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/22123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvcGFyYW1ldGVyL3Jld3JpdGVyL0VuY3J5cHRQcmVkaWNhdGVQYXJhbWV0ZXJSZXdyaXRlci5qYXZh) | `4.76% <0.00%> (ø)` | |
| [...ere/shadow/api/config/ShadowRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/22123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2FwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L2FwaS9jb25maWcvU2hhZG93UnVsZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...hadow/yaml/config/YamlShadowRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/22123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYWRvdy95YW1sL2NvbmZpZy9ZYW1sU2hhZG93UnVsZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `80.00% <ø> (ø)` | |
| [...ml/swapper/YamlShadowRuleConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/22123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYWRvdy95YW1sL3N3YXBwZXIvWWFtbFNoYWRvd1J1bGVDb25maWd1cmF0aW9uU3dhcHBlci5qYXZh) | `11.42% <0.00%> (-4.71%)` | :arrow_down: |
| ... and [112 more](https://codecov.io/gh/apache/shardingsphere/pull/22123/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #22123: Optimize shadow rule configuration
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #22123:
URL: https://github.com/apache/shardingsphere/pull/22123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org