[jira] [Comment Edited] (DERBY-6453) Remove dead code in InsertResultSet and flag skipCheckConstraints

["Dag H. Wanvik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-6453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866619#comment-13866619 ] 

Dag H. Wanvik edited comment on DERBY-6453 at 1/9/14 1:00 PM:
--------------------------------------------------------------

Attaching version 2 which adds a test case that exercises a previously untested according to JaCoCo: check constraint during bulk import. Also adds a test for IMPORT in the presence of triggers (which turns off bulk import mode). 
Regressions ran ok.



was (Author: dagw):
Attaching version 2 which adds a test case that exercises a previously untested according to JaCoCo: check constraint buring bulk import. Also addes a test for IMPORT in the presence of triggers (which turns off buld import mode). 
Regressions ran ok.


> Remove dead code in InsertResultSet and flag skipCheckConstraints
> -----------------------------------------------------------------
>
>                 Key: DERBY-6453
>                 URL: https://issues.apache.org/jira/browse/DERBY-6453
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>            Priority: Minor
>         Attachments: cleanup-misc-2.diff, cleanup-misc-2.stat, cleanup-misc.diff, cleanup-misc.stat
>
>
> I identified some unused code; a flag that is always false, and code for handling triggers in bulk insert which is unused (by inspection and corroborated by JaCoCo results for our regression tests): we disable bulk insert if there are triggers present, cf. 
> * DMLModStatementNode#getAllRelevantTriggers ->
>   adjustDeferredFlag(true)
> * InsertResultSet#bulkInsert:
>   bulkInsert = verifyBulkInsert()->
>       :
>       // bulk insert is disabled for deferred mode inserts
>       if (constants.deferred)
>       return false;



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)