You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <da...@elego.de> on 2013/08/09 19:51:38 UTC

Re: svn commit: r1512319 - /subversion/trunk/subversion/tests/libsvn_fs_x/fs-x-pack-test.c

stefan2@apache.org wrote on Fri, Aug 09, 2013 at 14:22:21 -0000:
> Author: stefan2
> Date: Fri Aug  9 14:22:20 2013
> New Revision: 1512319
> 
> URL: http://svn.apache.org/r1512319
> Log:
> Disable FSX utiltiy class test for anything non-FSX because it creates
> a repository and that may or may not fail depending on test parameters.
> 
> * subversion/tests/libsvn_fs_x/fs-x-pack-test.c
>   (test_reps): run for 1.9+ FSX only
> 
> +  /* Bail (with success) on known-untestable scenarios */
> +  if ((strcmp(opts->fs_type, "fsx") != 0)
> +      || (opts->server_minor_version && (opts->server_minor_version < 8)))

s/8/9/

> +    return SVN_NO_ERROR;

Re: svn commit: r1512319 - /subversion/trunk/subversion/tests/libsvn_fs_x/fs-x-pack-test.c

Posted by Stefan Fuhrmann <st...@wandisco.com>.
On Fri, Aug 9, 2013 at 7:51 PM, Daniel Shahaf <da...@elego.de> wrote:

> stefan2@apache.org wrote on Fri, Aug 09, 2013 at 14:22:21 -0000:
> > Author: stefan2
> > Date: Fri Aug  9 14:22:20 2013
> > New Revision: 1512319
> >
> > URL: http://svn.apache.org/r1512319
> > Log:
> > Disable FSX utiltiy class test for anything non-FSX because it creates
> > a repository and that may or may not fail depending on test parameters.
> >
> > * subversion/tests/libsvn_fs_x/fs-x-pack-test.c
> >   (test_reps): run for 1.9+ FSX only
> >
> > +  /* Bail (with success) on known-untestable scenarios */
> > +  if ((strcmp(opts->fs_type, "fsx") != 0)
> > +      || (opts->server_minor_version && (opts->server_minor_version <
> 8)))
>
> s/8/9/
>
> > +    return SVN_NO_ERROR;
>

Fixed in several places with r1513012.
Thanks for the review!

-- Stefan^2.

Re: svn commit: r1512319 - /subversion/trunk/subversion/tests/libsvn_fs_x/fs-x-pack-test.c

Posted by Stefan Fuhrmann <st...@wandisco.com>.
On Fri, Aug 9, 2013 at 7:51 PM, Daniel Shahaf <da...@elego.de> wrote:

> stefan2@apache.org wrote on Fri, Aug 09, 2013 at 14:22:21 -0000:
> > Author: stefan2
> > Date: Fri Aug  9 14:22:20 2013
> > New Revision: 1512319
> >
> > URL: http://svn.apache.org/r1512319
> > Log:
> > Disable FSX utiltiy class test for anything non-FSX because it creates
> > a repository and that may or may not fail depending on test parameters.
> >
> > * subversion/tests/libsvn_fs_x/fs-x-pack-test.c
> >   (test_reps): run for 1.9+ FSX only
> >
> > +  /* Bail (with success) on known-untestable scenarios */
> > +  if ((strcmp(opts->fs_type, "fsx") != 0)
> > +      || (opts->server_minor_version && (opts->server_minor_version <
> 8)))
>
> s/8/9/
>
> > +    return SVN_NO_ERROR;
>

Fixed in several places with r1513012.
Thanks for the review!

-- Stefan^2.