[jira] Created: (MPJNLP-23) maven.jnlp.jardiff and maven.jnlp.usejarversions aren't mutually exclusive

[ji...@codehaus.org]

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPJNLP-23

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPJNLP-23
    Summary: maven.jnlp.jardiff and maven.jnlp.usejarversions aren't mutually exclusive
       Type: Bug

     Status: Open
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-jnlp-plugin
   Fix Fors:
             1.5
   Versions:
             1.4.1

   Assignee: Emmanuel Venisse
   Reporter: Xanthros

    Created: Tue, 11 Jan 2005 12:01 AM
    Updated: Tue, 11 Jan 2005 12:01 AM

Description:
If maven.jnlp.usejarversions=true and maven.jnlp.jardiff=true

then the version.xml file is created and the jar files are renamed using the filename based convention instead of the version based.

This is incorrect.  If both are true then the version.xml file should be used and not the filename based convention.  By using the filename based convention the version based has no chance of working since it can't match the value in the <file> tag that is put in the version.xml.

When the jars are being signed, it renames the jars using the filename based convention, thereby making the version.xml useless.

Also the version.xml is newly created everytime and therefore doesn't have the previous resources.

jnlp descriptor snippet:
  <resources>
    <jar version="1.14" href="test-core.jar">
    </jar>
    <jar version="1.05" href="test-service.jar">
    </jar>
  </resources>

version.xml snippet:

<jnlp-versions>
  <resource>
    <pattern>
      <name>test-core.jar</name>
      <version-id>1.13</version-id>
    </pattern>
    <file>blah.jar</file>
  </resource>
  <resource>
    <pattern>
      <name>test-core.jar</name>
      <version-id>1.14</version-id>
    </pattern>
    <file>blah245.jar</file>
  </resource>
  <resource>
    <pattern>
      <name>test-service.jar</name>
      <version-id>1.04</version-id>
    </pattern>
    <file>sample.jar</file>
  </resource>
  <resource>
    <pattern>
      <name>test-service.jar</name>
      <version-id>1.05</version-id>
    </pattern>
    <file>sample1.jar</file>
  </resource>
<jnlp-versions>

The value of the href has to match the <name> in the version.xml file.
Currently this is also incorrect.

The plugin produces a version.xml file like this:

<jnlp-versions>
  <resource>
    <pattern>
      <name>test-core-1.14.jar</name>
      <version-id>1.14</version-id>
    </pattern>
    <file>test-core-1.14.jar</file>
  </resource>
  <resource>
    <pattern>
      <name>test-service-1.05.jar</name>
      <version-id>1.05</version-id>
    </pattern>
    <file>test-service-1.05.jar</file>
  </resource>
<jnlp-versions>


The <file> tag has to exactly match a file on the file system.  It can be named anything as long as it exists.

This is probably two-three issues that are all linked.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org