You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gengliangwang <gi...@git.apache.org> on 2018/10/17 06:19:54 UTC
[GitHub] spark pull request #22753: [SPARK-25754][DOC] Change CDN for MathJax
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/22753
[SPARK-25754][DOC] Change CDN for MathJax
## What changes were proposed in this pull request?
Currently when we open our doc site: https://spark.apache.org/docs/latest/index.html , there is one warning
This PR is to change the CDN as per the migration tips: https://www.mathjax.org/cdn-shutting-down/
This is very very trivial. But it would be good to follow the suggestion from MathJax team and remove the warning, in case one day the original CDN is no longer available.
## How was this patch tested?
Manual check.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gengliangwang/spark migrateMathJax
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22753.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22753
----
commit e700c82338d3f0123629a77afc2fb5bd1ac466f8
Author: Gengliang Wang <ge...@...>
Date: 2018-10-17T06:08:44Z
change cdn for MathJax
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22753: [SPARK-25754][DOC] Change CDN for MathJax
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22753#discussion_r225809921
--- Diff: docs/_layouts/global.html ---
@@ -184,7 +184,8 @@ <h1 class="title">{{ page.title }}</h1>
});
};
script.src = ('https:' == document.location.protocol ? 'https://' : 'http://') +
- 'cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS-MML_HTMLorMML';
+ 'cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.1/MathJax.js' +
--- End diff --
No, according to the suggestion of the migration guide(https://www.mathjax.org/cdn-shutting-down/):
> Note If you have been using https://cdn.mathjax.org/mathjax/latest/, we suggest to switch to a fixed version going forward as this represents best practices to avoid unexpected changes. That is, you will have to change the address manually to a higher number when new versions become available.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22753: [SPARK-25754][DOC] Change CDN for MathJax
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22753
**[Test build #97481 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97481/testReport)** for PR 22753 at commit [`e700c82`](https://github.com/apache/spark/commit/e700c82338d3f0123629a77afc2fb5bd1ac466f8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22753: [SPARK-25754][DOC] Change CDN for MathJax
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22753
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4053/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22753: [SPARK-25754][DOC] Change CDN for MathJax
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22753
@srowen
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22753: [SPARK-25754][DOC] Change CDN for MathJax
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22753
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22753: [SPARK-25754][DOC] Change CDN for MathJax
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22753
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97481/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22753: [SPARK-25754][DOC] Change CDN for MathJax
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22753
Merged to master/2.4/2.3
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22753: [SPARK-25754][DOC] Change CDN for MathJax
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22753#discussion_r225810815
--- Diff: docs/_layouts/global.html ---
@@ -184,7 +184,8 @@ <h1 class="title">{{ page.title }}</h1>
});
};
script.src = ('https:' == document.location.protocol ? 'https://' : 'http://') +
- 'cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS-MML_HTMLorMML';
+ 'cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.1/MathJax.js' +
--- End diff --
I had the same concern..But I think we can use the current version unless there is important change in MathJax.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22753: [SPARK-25754][DOC] Change CDN for MathJax
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22753
**[Test build #97481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97481/testReport)** for PR 22753 at commit [`e700c82`](https://github.com/apache/spark/commit/e700c82338d3f0123629a77afc2fb5bd1ac466f8).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22753: [SPARK-25754][DOC] Change CDN for MathJax
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22753
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22753: [SPARK-25754][DOC] Change CDN for MathJax
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22753
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22753: [SPARK-25754][DOC] Change CDN for MathJax
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22753#discussion_r225792435
--- Diff: docs/_layouts/global.html ---
@@ -184,7 +184,8 @@ <h1 class="title">{{ page.title }}</h1>
});
};
script.src = ('https:' == document.location.protocol ? 'https://' : 'http://') +
- 'cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS-MML_HTMLorMML';
+ 'cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.1/MathJax.js' +
--- End diff --
should we avoid hardcoding the version inline?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org