You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by harshach <gi...@git.apache.org> on 2016/04/28 05:14:18 UTC
[GitHub] storm pull request: STORM-1736. Change KafkaTestBroker.buildKafkaC...
GitHub user harshach opened a pull request:
https://github.com/apache/storm/pull/1376
STORM-1736. Change KafkaTestBroker.buildKafkaConfig to new KafkaConfig api.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/harshach/incubator-storm STORM-1736
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1376.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1376
----
commit 68bdcc53d5ea88e6ee84bcea3a0aa5fcfe0979d5
Author: Sriharsha Chintalapani <ha...@hortonworks.com>
Date: 2016-04-28T02:50:28Z
STORM-1736. Change KafkaTestBroker.buildKafkaConfig to new KafkaConfig api.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1736. Change KafkaTestBroker.buildKafkaC...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/1376#issuecomment-216590606
@abhishekagarwal87 commented on your PR https://github.com/apache/storm/pull/1386 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1376: STORM-1736. Change KafkaTestBroker.buildKafkaConfi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1376
---
[GitHub] storm pull request: STORM-1736. Change KafkaTestBroker.buildKafkaC...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1376#issuecomment-215303147
The patch looks okay to me, but I would like to know why it's necessary. I can't reproduce the issuue from the branch or rc2 build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1736. Change KafkaTestBroker.buildKafkaC...
Posted by abhishekagarwal87 <gi...@git.apache.org>.
Github user abhishekagarwal87 commented on the pull request:
https://github.com/apache/storm/pull/1376#issuecomment-216587066
@harshach - with this change, test compilation will fail once the #1386 is merged. Since this is the internal class used only in test, do we really need to make it compatible with 0.10 branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1736. Change KafkaTestBroker.buildKafkaC...
Posted by abhishekagarwal87 <gi...@git.apache.org>.
Github user abhishekagarwal87 commented on the pull request:
https://github.com/apache/storm/pull/1376#issuecomment-216560931
This would also break the compatibility of storm 1.0.0 with 0.8.x kafka client API.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1736. Change KafkaTestBroker.buildKafkaC...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1376#issuecomment-216467060
I also don't encounter this through 1.0.1 RC1 to 1.0.1 RC3. Did you set the custom Kafka version while building?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1736. Change KafkaTestBroker.buildKafkaC...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/1376#issuecomment-216579561
@HeartSaVioR @abhishekagarwal87 this issues happens with Kafka 0.10 branch.
Yes it does break test compatability with 0.8.x . Keep in mind that KafkaConfig is an internal kafka class that we use to start a in-process kafka broker. We shouldn't be calling it as breaking comptability with client api. Also this change will work with Kafka 0.9.x on wards
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---