You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:25:13 UTC
[GitHub] [airflow] jomar83 opened a new pull request #17933: enable setting of pod specific annotations
jomar83 opened a new pull request #17933:
URL: https://github.com/apache/airflow/pull/17933
Allow for pod specific annotations.
Our specific use case requires this for scraping additional openmetrics exposed via plugin by the airflow webserver.
The webserver pod requires annotations that are picked up by our datadog agents to enable and configure the scraping.
For consistency this PR also enables specific pod annotations for scheduler, triggerer and flower.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17933: enable setting of pod specific annotations
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17933:
URL: https://github.com/apache/airflow/pull/17933#issuecomment-950021523
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17933: enable setting of pod specific annotations
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #17933:
URL: https://github.com/apache/airflow/pull/17933#issuecomment-914403356
Good idea @jomar83, thanks.
What do you think about using `merge` on the pod specific annotations and the global annotations so that the former can override the latter, e.g. something like this:
```
{{ $annotations := merge .Values.scheduler.podAnnotations .Values.airflowPodAnnotations }}
{{- if $annotations }}
{{- toYaml $annotations | nindent 8 }}
{{- end }}
```
We also need tests for this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #17933: enable setting of pod specific annotations
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #17933:
URL: https://github.com/apache/airflow/pull/17933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org