You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/09/23 16:13:27 UTC

[GitHub] [activemq-artemis] gemmellr commented on pull request #3768: [ARTEMIS-3494]: ActiveMQClientProtocolManagerFactory shouldn't have a…

gemmellr commented on pull request #3768:
URL: https://github.com/apache/activemq-artemis/pull/3768#issuecomment-925958580


   Seems unusual to explicitly render the static method unused in the Artemis codebase and then not modify it in some way (e.g deprecation, or removal). As is anyone could just choose to remove it as 'unused', though it sounds like you may have existing code that was relying on it. Its also now unused and untested for anyone else still relying on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org