You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Mike Riley (JIRA)" <ji...@apache.org> on 2012/06/23 03:35:42 UTC
[jira] [Created] (THRIFT-1636) Can we remove the closing tags from
generated PHP sources?
Mike Riley created THRIFT-1636:
----------------------------------
Summary: Can we remove the closing tags from generated PHP sources?
Key: THRIFT-1636
URL: https://issues.apache.org/jira/browse/THRIFT-1636
Project: Thrift
Issue Type: Improvement
Components: PHP - Compiler
Reporter: Mike Riley
Priority: Minor
Closing PHP tags are unnecessary in virtually all environments and in many cases actually cause problems when not used properly. Right now we're generating the closing tags followed by a newline, if output buffering isn't running at the point that such a source is included, PHP will go ahead and print it.
In my experience it's best to leave the closing PHP tags off of the end of sources, any objections to removing them here?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1636) Can we remove the closing tags
from generated PHP sources?
Posted by "Andrew Grumet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399795#comment-13399795 ]
Andrew Grumet commented on THRIFT-1636:
---------------------------------------
+1
> Can we remove the closing tags from generated PHP sources?
> ----------------------------------------------------------
>
> Key: THRIFT-1636
> URL: https://issues.apache.org/jira/browse/THRIFT-1636
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler
> Reporter: Mike Riley
> Priority: Minor
>
> Closing PHP tags are unnecessary in virtually all environments and in many cases actually cause problems when not used properly. Right now we're generating the closing tags followed by a newline, if output buffering isn't running at the point that such a source is included, PHP will go ahead and print it.
> In my experience it's best to leave the closing PHP tags off of the end of sources, any objections to removing them here?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira