You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Enrico Olivelli <eo...@gmail.com> on 2019/12/28 08:52:47 UTC
[DISCUSS] Dropping Twitter modules
Hi folks,
I propose to drop the four modules that contain Twitter specific stuff.
Those modules did not receive changes for long time, nor issues/questions
from users.
We recently added a new Maven profile (-Dtwitter) to skip them from build.
The modules are:
- Http Server:
https://github.com/apache/bookkeeper/blob/master/bookkeeper-http/twitter-http-server/pom.xml
- Finagle Stats Provider
https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-finagle-provider/pom.xml
- Science Stats Provider
https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-science-provider/pom.xml
- Ostrich Stats Provider
https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-ostrich-provider/pom.xml
Best regards
Enrico
Re: [DISCUSS] Dropping Twitter modules
Posted by David Rusek <da...@gmail.com>.
Hey sorry, still on vacation I thought I did approve it, sorry.
On Fri, Jan 3, 2020 at 9:45 PM Sijie Guo <gu...@gmail.com> wrote:
> LGTM. +1
>
> On Fri, Jan 3, 2020 at 10:25 PM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Thank you Dave
> >
> > can you please "Approve" the pull request ?
> > Unfortunately Travis has problems and the build fails, I have started
> > another thread to fix the problem
> >
> > Enrico
> >
> > Il giorno ven 3 gen 2020 alle ore 15:24 David Rusek <
> dave.rusek@gmail.com>
> > ha scritto:
> >
> > > Confirming what I said on slack, it’s not worth us maintaining these
> > > modules.
> > >
> > > On Fri, Jan 3, 2020 at 5:54 AM Jia Zhai <zh...@gmail.com> wrote:
> > >
> > > > +1 to remove it.
> > > >
> > > > Best Regards.
> > > >
> > > >
> > > > Jia Zhai
> > > >
> > > > Beijing, China
> > > >
> > > > Mobile: +86 15810491983
> > > >
> > > >
> > > >
> > > >
> > > > On Fri, Jan 3, 2020 at 6:37 PM Enrico Olivelli <eo...@gmail.com>
> > > > wrote:
> > > >
> > > >> This is the patch
> > > >> https://github.com/apache/bookkeeper/pull/2232
> > > >>
> > > >> @Sijie @Dave please take a look
> > > >>
> > > >> Enrico
> > > >>
> > > >> Il giorno ven 3 gen 2020 alle ore 11:00 Enrico Olivelli <
> > > >> eolivelli@gmail.com>
> > > >> ha scritto:
> > > >>
> > > >> > Hi,
> > > >> > on slack Dave Rusek told me it is useless to keep this stuff.
> > > >> > It seems that he did not receive this message, I am posting this
> > > message
> > > >> > just to let him confirm
> > > >> >
> > > >> > btw I am preparing a patch that drops all of this stuff
> > > >> >
> > > >> > Enrico
> > > >> >
> > > >> > Enrico
> > > >> >
> > > >> > Il giorno sab 28 dic 2019 alle ore 09:52 Enrico Olivelli <
> > > >> > eolivelli@gmail.com> ha scritto:
> > > >> >
> > > >> >> Hi folks,
> > > >> >> I propose to drop the four modules that contain Twitter specific
> > > stuff.
> > > >> >> Those modules did not receive changes for long time, nor
> > > >> issues/questions
> > > >> >> from users.
> > > >> >>
> > > >> >> We recently added a new Maven profile (-Dtwitter) to skip them
> from
> > > >> build.
> > > >> >>
> > > >> >> The modules are:
> > > >> >> - Http Server:
> > > >> >>
> > > >>
> > >
> >
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-http/twitter-http-server/pom.xml
> > > >> >> - Finagle Stats Provider
> > > >> >>
> > > >>
> > >
> >
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-finagle-provider/pom.xml
> > > >> >> - Science Stats Provider
> > > >> >>
> > > >>
> > >
> >
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-science-provider/pom.xml
> > > >> >> - Ostrich Stats Provider
> > > >> >>
> > > >>
> > >
> >
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-ostrich-provider/pom.xml
> > > >> >>
> > > >> >> Best regards
> > > >> >>
> > > >> >> Enrico
> > > >> >>
> > > >> >
> > > >>
> > > > --
> > >
> > > Dave Rusek
> > > dave.rusek@gmail.com
> > > @davidjrusek
> > >
> >
>
--
Dave Rusek
dave.rusek@gmail.com
@davidjrusek
Re: [DISCUSS] Dropping Twitter modules
Posted by Sijie Guo <gu...@gmail.com>.
LGTM. +1
On Fri, Jan 3, 2020 at 10:25 PM Enrico Olivelli <eo...@gmail.com> wrote:
> Thank you Dave
>
> can you please "Approve" the pull request ?
> Unfortunately Travis has problems and the build fails, I have started
> another thread to fix the problem
>
> Enrico
>
> Il giorno ven 3 gen 2020 alle ore 15:24 David Rusek <da...@gmail.com>
> ha scritto:
>
> > Confirming what I said on slack, it’s not worth us maintaining these
> > modules.
> >
> > On Fri, Jan 3, 2020 at 5:54 AM Jia Zhai <zh...@gmail.com> wrote:
> >
> > > +1 to remove it.
> > >
> > > Best Regards.
> > >
> > >
> > > Jia Zhai
> > >
> > > Beijing, China
> > >
> > > Mobile: +86 15810491983
> > >
> > >
> > >
> > >
> > > On Fri, Jan 3, 2020 at 6:37 PM Enrico Olivelli <eo...@gmail.com>
> > > wrote:
> > >
> > >> This is the patch
> > >> https://github.com/apache/bookkeeper/pull/2232
> > >>
> > >> @Sijie @Dave please take a look
> > >>
> > >> Enrico
> > >>
> > >> Il giorno ven 3 gen 2020 alle ore 11:00 Enrico Olivelli <
> > >> eolivelli@gmail.com>
> > >> ha scritto:
> > >>
> > >> > Hi,
> > >> > on slack Dave Rusek told me it is useless to keep this stuff.
> > >> > It seems that he did not receive this message, I am posting this
> > message
> > >> > just to let him confirm
> > >> >
> > >> > btw I am preparing a patch that drops all of this stuff
> > >> >
> > >> > Enrico
> > >> >
> > >> > Enrico
> > >> >
> > >> > Il giorno sab 28 dic 2019 alle ore 09:52 Enrico Olivelli <
> > >> > eolivelli@gmail.com> ha scritto:
> > >> >
> > >> >> Hi folks,
> > >> >> I propose to drop the four modules that contain Twitter specific
> > stuff.
> > >> >> Those modules did not receive changes for long time, nor
> > >> issues/questions
> > >> >> from users.
> > >> >>
> > >> >> We recently added a new Maven profile (-Dtwitter) to skip them from
> > >> build.
> > >> >>
> > >> >> The modules are:
> > >> >> - Http Server:
> > >> >>
> > >>
> >
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-http/twitter-http-server/pom.xml
> > >> >> - Finagle Stats Provider
> > >> >>
> > >>
> >
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-finagle-provider/pom.xml
> > >> >> - Science Stats Provider
> > >> >>
> > >>
> >
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-science-provider/pom.xml
> > >> >> - Ostrich Stats Provider
> > >> >>
> > >>
> >
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-ostrich-provider/pom.xml
> > >> >>
> > >> >> Best regards
> > >> >>
> > >> >> Enrico
> > >> >>
> > >> >
> > >>
> > > --
> >
> > Dave Rusek
> > dave.rusek@gmail.com
> > @davidjrusek
> >
>
Re: [DISCUSS] Dropping Twitter modules
Posted by Enrico Olivelli <eo...@gmail.com>.
Thank you Dave
can you please "Approve" the pull request ?
Unfortunately Travis has problems and the build fails, I have started
another thread to fix the problem
Enrico
Il giorno ven 3 gen 2020 alle ore 15:24 David Rusek <da...@gmail.com>
ha scritto:
> Confirming what I said on slack, it’s not worth us maintaining these
> modules.
>
> On Fri, Jan 3, 2020 at 5:54 AM Jia Zhai <zh...@gmail.com> wrote:
>
> > +1 to remove it.
> >
> > Best Regards.
> >
> >
> > Jia Zhai
> >
> > Beijing, China
> >
> > Mobile: +86 15810491983
> >
> >
> >
> >
> > On Fri, Jan 3, 2020 at 6:37 PM Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> >> This is the patch
> >> https://github.com/apache/bookkeeper/pull/2232
> >>
> >> @Sijie @Dave please take a look
> >>
> >> Enrico
> >>
> >> Il giorno ven 3 gen 2020 alle ore 11:00 Enrico Olivelli <
> >> eolivelli@gmail.com>
> >> ha scritto:
> >>
> >> > Hi,
> >> > on slack Dave Rusek told me it is useless to keep this stuff.
> >> > It seems that he did not receive this message, I am posting this
> message
> >> > just to let him confirm
> >> >
> >> > btw I am preparing a patch that drops all of this stuff
> >> >
> >> > Enrico
> >> >
> >> > Enrico
> >> >
> >> > Il giorno sab 28 dic 2019 alle ore 09:52 Enrico Olivelli <
> >> > eolivelli@gmail.com> ha scritto:
> >> >
> >> >> Hi folks,
> >> >> I propose to drop the four modules that contain Twitter specific
> stuff.
> >> >> Those modules did not receive changes for long time, nor
> >> issues/questions
> >> >> from users.
> >> >>
> >> >> We recently added a new Maven profile (-Dtwitter) to skip them from
> >> build.
> >> >>
> >> >> The modules are:
> >> >> - Http Server:
> >> >>
> >>
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-http/twitter-http-server/pom.xml
> >> >> - Finagle Stats Provider
> >> >>
> >>
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-finagle-provider/pom.xml
> >> >> - Science Stats Provider
> >> >>
> >>
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-science-provider/pom.xml
> >> >> - Ostrich Stats Provider
> >> >>
> >>
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-ostrich-provider/pom.xml
> >> >>
> >> >> Best regards
> >> >>
> >> >> Enrico
> >> >>
> >> >
> >>
> > --
>
> Dave Rusek
> dave.rusek@gmail.com
> @davidjrusek
>
Re: [DISCUSS] Dropping Twitter modules
Posted by David Rusek <da...@gmail.com>.
Confirming what I said on slack, it’s not worth us maintaining these
modules.
On Fri, Jan 3, 2020 at 5:54 AM Jia Zhai <zh...@gmail.com> wrote:
> +1 to remove it.
>
> Best Regards.
>
>
> Jia Zhai
>
> Beijing, China
>
> Mobile: +86 15810491983
>
>
>
>
> On Fri, Jan 3, 2020 at 6:37 PM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
>> This is the patch
>> https://github.com/apache/bookkeeper/pull/2232
>>
>> @Sijie @Dave please take a look
>>
>> Enrico
>>
>> Il giorno ven 3 gen 2020 alle ore 11:00 Enrico Olivelli <
>> eolivelli@gmail.com>
>> ha scritto:
>>
>> > Hi,
>> > on slack Dave Rusek told me it is useless to keep this stuff.
>> > It seems that he did not receive this message, I am posting this message
>> > just to let him confirm
>> >
>> > btw I am preparing a patch that drops all of this stuff
>> >
>> > Enrico
>> >
>> > Enrico
>> >
>> > Il giorno sab 28 dic 2019 alle ore 09:52 Enrico Olivelli <
>> > eolivelli@gmail.com> ha scritto:
>> >
>> >> Hi folks,
>> >> I propose to drop the four modules that contain Twitter specific stuff.
>> >> Those modules did not receive changes for long time, nor
>> issues/questions
>> >> from users.
>> >>
>> >> We recently added a new Maven profile (-Dtwitter) to skip them from
>> build.
>> >>
>> >> The modules are:
>> >> - Http Server:
>> >>
>> https://github.com/apache/bookkeeper/blob/master/bookkeeper-http/twitter-http-server/pom.xml
>> >> - Finagle Stats Provider
>> >>
>> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-finagle-provider/pom.xml
>> >> - Science Stats Provider
>> >>
>> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-science-provider/pom.xml
>> >> - Ostrich Stats Provider
>> >>
>> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-ostrich-provider/pom.xml
>> >>
>> >> Best regards
>> >>
>> >> Enrico
>> >>
>> >
>>
> --
Dave Rusek
dave.rusek@gmail.com
@davidjrusek
Re: [DISCUSS] Dropping Twitter modules
Posted by Jia Zhai <zh...@gmail.com>.
+1 to remove it.
Best Regards.
Jia Zhai
Beijing, China
Mobile: +86 15810491983
On Fri, Jan 3, 2020 at 6:37 PM Enrico Olivelli <eo...@gmail.com> wrote:
> This is the patch
> https://github.com/apache/bookkeeper/pull/2232
>
> @Sijie @Dave please take a look
>
> Enrico
>
> Il giorno ven 3 gen 2020 alle ore 11:00 Enrico Olivelli <
> eolivelli@gmail.com>
> ha scritto:
>
> > Hi,
> > on slack Dave Rusek told me it is useless to keep this stuff.
> > It seems that he did not receive this message, I am posting this message
> > just to let him confirm
> >
> > btw I am preparing a patch that drops all of this stuff
> >
> > Enrico
> >
> > Enrico
> >
> > Il giorno sab 28 dic 2019 alle ore 09:52 Enrico Olivelli <
> > eolivelli@gmail.com> ha scritto:
> >
> >> Hi folks,
> >> I propose to drop the four modules that contain Twitter specific stuff.
> >> Those modules did not receive changes for long time, nor
> issues/questions
> >> from users.
> >>
> >> We recently added a new Maven profile (-Dtwitter) to skip them from
> build.
> >>
> >> The modules are:
> >> - Http Server:
> >>
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-http/twitter-http-server/pom.xml
> >> - Finagle Stats Provider
> >>
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-finagle-provider/pom.xml
> >> - Science Stats Provider
> >>
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-science-provider/pom.xml
> >> - Ostrich Stats Provider
> >>
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-ostrich-provider/pom.xml
> >>
> >> Best regards
> >>
> >> Enrico
> >>
> >
>
Re: [DISCUSS] Dropping Twitter modules
Posted by Enrico Olivelli <eo...@gmail.com>.
This is the patch
https://github.com/apache/bookkeeper/pull/2232
@Sijie @Dave please take a look
Enrico
Il giorno ven 3 gen 2020 alle ore 11:00 Enrico Olivelli <eo...@gmail.com>
ha scritto:
> Hi,
> on slack Dave Rusek told me it is useless to keep this stuff.
> It seems that he did not receive this message, I am posting this message
> just to let him confirm
>
> btw I am preparing a patch that drops all of this stuff
>
> Enrico
>
> Enrico
>
> Il giorno sab 28 dic 2019 alle ore 09:52 Enrico Olivelli <
> eolivelli@gmail.com> ha scritto:
>
>> Hi folks,
>> I propose to drop the four modules that contain Twitter specific stuff.
>> Those modules did not receive changes for long time, nor issues/questions
>> from users.
>>
>> We recently added a new Maven profile (-Dtwitter) to skip them from build.
>>
>> The modules are:
>> - Http Server:
>> https://github.com/apache/bookkeeper/blob/master/bookkeeper-http/twitter-http-server/pom.xml
>> - Finagle Stats Provider
>> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-finagle-provider/pom.xml
>> - Science Stats Provider
>> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-science-provider/pom.xml
>> - Ostrich Stats Provider
>> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-ostrich-provider/pom.xml
>>
>> Best regards
>>
>> Enrico
>>
>
Re: [DISCUSS] Dropping Twitter modules
Posted by Enrico Olivelli <eo...@gmail.com>.
Hi,
on slack Dave Rusek told me it is useless to keep this stuff.
It seems that he did not receive this message, I am posting this message
just to let him confirm
btw I am preparing a patch that drops all of this stuff
Enrico
Enrico
Il giorno sab 28 dic 2019 alle ore 09:52 Enrico Olivelli <
eolivelli@gmail.com> ha scritto:
> Hi folks,
> I propose to drop the four modules that contain Twitter specific stuff.
> Those modules did not receive changes for long time, nor issues/questions
> from users.
>
> We recently added a new Maven profile (-Dtwitter) to skip them from build.
>
> The modules are:
> - Http Server:
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-http/twitter-http-server/pom.xml
> - Finagle Stats Provider
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-finagle-provider/pom.xml
> - Science Stats Provider
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-science-provider/pom.xml
> - Ostrich Stats Provider
> https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-ostrich-provider/pom.xml
>
> Best regards
>
> Enrico
>