You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@felix.apache.org by "J. Brébec (Jira)" <ji...@apache.org> on 2022/01/03 10:31:00 UTC

[jira] [Commented] (FELIX-6461) Felix fileinstall doesn't test if files is null, causing retry failure

    [ https://issues.apache.org/jira/browse/FELIX-6461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467890#comment-17467890 ] 

J. Brébec commented on FELIX-6461:
----------------------------------

I don't think the fix is correct : if the "files" is empty, process(files) should be called. in this method, the "failed" files are added and rechecked. If you don't call process(), then the failed files will not be processed again until a file is changed.

 

An artefact can be in the failure state if a transformer is registered after the file is seen by file install.

> Felix fileinstall doesn't test if files is null, causing retry failure
> ----------------------------------------------------------------------
>
>                 Key: FELIX-6461
>                 URL: https://issues.apache.org/jira/browse/FELIX-6461
>             Project: Felix
>          Issue Type: Bug
>          Components: File Install
>    Affects Versions: fileinstall-3.7.0
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Jean-Baptiste Onofré
>            Priority: Major
>             Fix For: fileinstall-3.7.2
>
>
> The following commit basically breaks the file retry logic:
> [https://github.com/apache/felix-dev/commit/101a360248311817e1ad4645c549ea77773b0481#diff-263cdbacfd163ef5ce31dcbb1db83138f78d88eab353f1f587a10199e8ef3817L315]
> FileInstall should test null.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)