You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/03/01 18:13:23 UTC
Re: Review Request 43916: Modified testcase to test
`--cgroups_net_cls_secondary_handles` flag.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43916/#review121449
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer/isolator_tests.cpp (line 385)
<https://reviews.apache.org/r/43916/#comment183152>
Can you add a comment in the preview patch about why we want to use uint32_t for the handles?
src/tests/containerizer/isolator_tests.cpp (line 387)
<https://reviews.apache.org/r/43916/#comment183153>
I think we set a default for the secondary so that you don't have to do this here?
src/tests/containerizer/isolator_tests.cpp (lines 434 - 439)
<https://reviews.apache.org/r/43916/#comment183154>
I would align it like the following:
```
NetClsHandleManager manager(
IntervalSet<uint32_t>(
(Bound...
Bound...)),
IntervalSet<uint32_t>(
(Bound...
Bound...)));
```
- Jie Yu
On Feb. 29, 2016, 10:16 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43916/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 10:16 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4700
> https://issues.apache.org/jira/browse/MESOS-4700
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.
>
>
> Diffs
> -----
>
> src/tests/containerizer/isolator_tests.cpp 653b037c489072f43e53dec01a811a9249dcd660
>
> Diff: https://reviews.apache.org/r/43916/diff/
>
>
> Testing
> -------
>
> make check and sudo make check (for NetClsIsolator)
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 43916: Modified testcase to test
`--cgroups_net_cls_secondary_handles` flag.
Posted by Avinash sridharan <av...@mesosphere.io>.
> On March 1, 2016, 5:13 p.m., Jie Yu wrote:
> > src/tests/containerizer/isolator_tests.cpp, line 387
> > <https://reviews.apache.org/r/43916/diff/3/?file=1274697#file1274697line387>
> >
> > I think we set a default for the secondary so that you don't have to do this here?
Updated the constructutor to take in a default value. This is reflected in the previous patch.
- Avinash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43916/#review121449
-----------------------------------------------------------
On March 1, 2016, 7:59 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43916/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 7:59 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4700
> https://issues.apache.org/jira/browse/MESOS-4700
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.
>
>
> Diffs
> -----
>
> src/tests/containerizer/isolator_tests.cpp 7b257de2afbc66f63c47a80c1f828e3e95bd602d
>
> Diff: https://reviews.apache.org/r/43916/diff/
>
>
> Testing
> -------
>
> make check and sudo make check (for NetClsIsolator)
>
>
> Thanks,
>
> Avinash sridharan
>
>