You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/21 12:37:10 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32273: [SPARK-35143][ML]Add whether the path is dir

HyukjinKwon commented on a change in pull request #32273:
URL: https://github.com/apache/spark/pull/32273#discussion_r617492608



##########
File path: python/pyspark/tests/test_readwrite.py
##########
@@ -122,7 +122,8 @@ def test_converters(self):
 
     def test_binary_files(self):
         path = os.path.join(self.tempdir.name, "binaryfiles")
-        os.mkdir(path)
+        if not os.path.isdir(path):

Review comment:
       It's a tempfile so it's hardly likely already existent.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org