You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Mamta A. Satoor (JIRA)" <ji...@apache.org> on 2011/02/08 23:58:57 UTC
[jira] Created: (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Tests should restore the timeout values to default after they are done running.
-------------------------------------------------------------------------------
Key: DERBY-5014
URL: https://issues.apache.org/jira/browse/DERBY-5014
Project: Derby
Issue Type: Bug
Components: Test
Affects Versions: 10.7.1.1
Reporter: Mamta A. Satoor
There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
Following are some additional tests that should be fixed
1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Tiago R. Espinha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043028#comment-13043028 ]
Tiago R. Espinha commented on DERBY-5014:
-----------------------------------------
There's something I just noticed and I'd like to clear before committing the patch. There's two more tests that weren't converted nor mentioned here in the comments:
- ResultSetsFromPreparedStatementTest.java
This one seems to have its own mechanism to restore the lock timeout to the default.
Mamta & Knut, did this test get flagged somewhere? On a very quick visual inspection, it seems like the timeouts are restored.
- DatabaseMetaDataTest.java
This test already uses the DatabasePropertyTestSetup decorator. Why was it included in this issue?
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Assignee: Siddharth Srivastava
> Labels: derby_triage10_8
> Attachments: d5014_1.diff, d5014_1.diff
>
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Tiago R. Espinha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041731#comment-13041731 ]
Tiago R. Espinha commented on DERBY-5014:
-----------------------------------------
Hi Siddharth,
It seems like the patch has passed but I have a few questions/remarks about the patch.
1) As mentioned before, please avoid whitespace changes. In this patch, we're patching DatabasePropertyTestSetup.java unnecessarily.
2) Why do we need to import java.util.Properties into ResultSetsFromPreparedStatementTest.java?
In the end, is SysinfoTest.java the only one that needs to be changed? If so and if no one else objects, I'm going to change the patch to remove the unnecessary chunks and commit it.
I should also mention (and Siddharth, in the future it's also good practice to do so on JIRA upon posting a patch) that regressions were ran (suites.All) for this patch and it succeeded without any failures.
--
As for what you mentioned about creating a test to check whether the default values have been reset, I think that can be very difficult. The main challenge is: *when* do you run this test? Would you run it after every single test in JUnit? That would be incredibly time consuming.
Since these are just tests, we usually just trust that: if suites.All passes, then all the values are being reset, or if they aren't, it's not serious enough that it is not making the whole suite collapse.
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Assignee: Siddharth Srivastava
> Labels: derby_triage10_8
> Attachments: d5014_1.diff
>
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044743#comment-13044743 ]
Knut Anders Hatlen commented on DERBY-5014:
-------------------------------------------
I don't think there's anything that needs to be fixed in those two tests. Perhaps it would have been better if ResultSetsFromPreparedStatementTest had cleared the timeout property (by setting it to NULL) instead of setting it to 60, since that would do the right thing even if we at some point change the default timeout, but at least it does reset the timeout to the current default.
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Assignee: Siddharth Srivastava
> Labels: derby_triage10_8
> Attachments: d5014_1.diff, d5014_1.diff
>
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037777#comment-13037777 ]
Siddharth Srivastava commented on DERBY-5014:
---------------------------------------------
Just went through ErrorMessageTest.java and StressMultiTest.java. Don't they already restore the default timeout and property values or I am misunderstanding something ?
They use DatabasePropertyTestSetup which resets the values on tearDown.
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Assignee: Siddharth Srivastava
> Labels: derby_triage10_8
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden reopened DERBY-5014:
-----------------------------------
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Assignee: Siddharth Srivastava
> Labels: derby_triage10_8
> Fix For: 10.9.0.0
>
> Attachments: d5014_1.diff, d5014_1.diff
>
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-5014:
----------------------------------
Fix Version/s: 10.9.0.0
I think this would be a good candidate for backport
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Assignee: Siddharth Srivastava
> Labels: derby_triage10_8
> Fix For: 10.9.0.0
>
> Attachments: d5014_1.diff, d5014_1.diff
>
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden resolved DERBY-5014.
-----------------------------------
Resolution: Fixed
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Assignee: Siddharth Srivastava
> Labels: derby_triage10_8
> Fix For: 10.9.0.0
>
> Attachments: d5014_1.diff, d5014_1.diff
>
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004569#comment-13004569 ]
Siddharth Srivastava commented on DERBY-5014:
---------------------------------------------
Any views on including this as Derby Test and Fix project in GSoC 2011 ? (I am considering it to be in mine :) )
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Labels: derby_triage10_8
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Srivastava updated DERBY-5014:
----------------------------------------
Attachment: d5014_1.diff
Attached is the fix for this issue.
While fixing this I was thinking, where are the default values specified ?
Is it feasible to have a test to check if the default values have been reset or not ?
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Assignee: Siddharth Srivastava
> Labels: derby_triage10_8
> Attachments: d5014_1.diff
>
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004676#comment-13004676 ]
Kathey Marsden commented on DERBY-5014:
---------------------------------------
I think this would be great as part of a GSOC test and fix project or even before if you want to start working on it.
showing in your application that you have already started working on some of the issues is always good.
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Labels: derby_triage10_8
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Tiago R. Espinha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045123#comment-13045123 ]
Tiago R. Espinha commented on DERBY-5014:
-----------------------------------------
suites.All was a go, so I went ahead and committed this patch with revision 1132747.
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Assignee: Siddharth Srivastava
> Labels: derby_triage10_8
> Attachments: d5014_1.diff, d5014_1.diff
>
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Tiago R. Espinha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tiago R. Espinha resolved DERBY-5014.
-------------------------------------
Resolution: Fixed
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Assignee: Siddharth Srivastava
> Labels: derby_triage10_8
> Attachments: d5014_1.diff, d5014_1.diff
>
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Tiago R. Espinha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tiago R. Espinha updated DERBY-5014:
------------------------------------
Attachment: d5014_1.diff
Removed unnecessary patch hunks.
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Assignee: Siddharth Srivastava
> Labels: derby_triage10_8
> Attachments: d5014_1.diff, d5014_1.diff
>
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren updated DERBY-5014:
--------------------------------------
Issue & fix info: [Known fix, Newcomer]
Urgency: Normal
Labels: derby_triage10_8 (was: )
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Labels: derby_triage10_8
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Srivastava reassigned DERBY-5014:
-------------------------------------------
Assignee: Siddharth Srivastava
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Assignee: Siddharth Srivastava
> Labels: derby_triage10_8
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren reopened DERBY-5014:
---------------------------------------
reopening for backport to 10.8
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Assignee: Siddharth Srivastava
> Labels: derby_triage10_8
> Fix For: 10.9.0.0
>
> Attachments: d5014_1.diff, d5014_1.diff
>
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren closed DERBY-5014.
-------------------------------------
Resolution: Fixed
Fix Version/s: 10.8.1.6
backported this change to 10.8 with revision 1160474.
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Assignee: Siddharth Srivastava
> Labels: derby_triage10_8
> Fix For: 10.8.1.6, 10.9.0.0
>
> Attachments: d5014_1.diff, d5014_1.diff
>
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Srivastava closed DERBY-5014.
---------------------------------------
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Assignee: Siddharth Srivastava
> Labels: derby_triage10_8
> Attachments: d5014_1.diff, d5014_1.diff
>
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5014) Tests should restore the timeout
values to default after they are done running.
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037797#comment-13037797 ]
Knut Anders Hatlen commented on DERBY-5014:
-------------------------------------------
Hi Siddharth,
ErrorMessageTest and StressMultiTest look fine to me too. I don't think those tests need to be changed. Sttest is a standalone test that doesn't run under the JUnit framework, so I don't think resetting the properties is necessary in that test either. I haven't checked the last three tests mentioned in the bug description.
> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
> Key: DERBY-5014
> URL: https://issues.apache.org/jira/browse/DERBY-5014
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.7.1.1
> Reporter: Mamta A. Satoor
> Assignee: Siddharth Srivastava
> Labels: derby_triage10_8
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273
> Following are some additional tests that should be fixed
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira