You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/02/16 19:21:12 UTC
[GitHub] [hive] risdenk commented on a change in pull request #1969: HIVE-24768: Using jackson bom everywhere, so that it'll be easy to ma…
risdenk commented on a change in pull request #1969:
URL: https://github.com/apache/hive/pull/1969#discussion_r577075893
##########
File path: standalone-metastore/pom.xml
##########
@@ -123,6 +123,13 @@
<artifactId>orc-core</artifactId>
<version>${orc.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson</groupId>
+ <artifactId>jackson-bom</artifactId>
+ <version>${jackson.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
Review comment:
After adding the `dependencyManagement` section, the `jackson.version` for `jackson-databind` can be removed.
##########
File path: standalone-metastore/pom.xml
##########
@@ -123,6 +123,13 @@
<artifactId>orc-core</artifactId>
<version>${orc.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson</groupId>
+ <artifactId>jackson-bom</artifactId>
+ <version>${jackson.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
Review comment:
This needs to be moved to a new `dependencyManagement` section above `dependencies`.
##########
File path: testutils/ptest2/pom.xml
##########
@@ -115,20 +115,24 @@ limitations under the License.
<artifactId>velocity</artifactId>
<version>1.7</version>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson</groupId>
+ <artifactId>jackson-bom</artifactId>
+ <version>${jackson.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
Review comment:
This needs to be moved to a `dependencyManagement` section above `dependencies`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org