[GitHub] [spark] martin-g commented on a change in pull request #35639: [WIP][SPARK-38188][K8S] Support priority scheduling with Volcano implementations

[GitBox <gi...@apache.org>]

martin-g commented on a change in pull request #35639:
URL: https://github.com/apache/spark/pull/35639#discussion_r813670391



##########
File path: docs/running-on-kubernetes.md
##########
@@ -1356,6 +1356,16 @@ See the [configuration page](configuration.html) for information on Spark config
   </td>
   <td>3.3.0</td>
 </tr>
+<tr>
+  <td><code>spark.kubernetes.job.priorityClassName</code></td>
+  <td><code>(none)</code></td>
+  <td>
+    The name of the queue to which the job is submitted.

Review comment:
       `queue` ? looks like a copy/paste error

##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -292,6 +292,14 @@ private[spark] object Config extends Logging {
       .stringConf
       .createOptional
 
+  val KUBERNETES_JOB_PRIORITY = ConfigBuilder("spark.kubernetes.job.priorityClassName")
+    .doc("The name of the queue to which the job is submitted. This info " +

Review comment:
       again the doc talks about `queue` (https://volcano.sh/en/docs/vcjob/#queue) while it should be https://volcano.sh/en/docs/vcjob/#priorityclassname




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org