[GitHub] [airflow] npodewitz commented on pull request #25002: Fix backwards incompatible change for group id naming check

[GitBox <gi...@apache.org>]

npodewitz commented on PR #25002:
URL: https://github.com/apache/airflow/pull/25002#issuecomment-1182874348

   Hi,
   
   thanks for the quick response. I did not consider subdags before.
   
   However, I respectfully would like to point out:
   1. Maybe I got this wrong but I thought that "." is used to separate dags from subdags in the dag id. How is this relevant to task and group ids?
   2. Disregarding subdags, a task id like "A.B.C" can be created in 4 different ways (see picture above), 3 of which are valid and one is not (since Airflow 2.1.3, prior to 2.1.3 all 4 cases were valid). You cannot derive the task groups from the task id alone so I do not understand why "." is not allowed in the group id.
   3. Case 4 was valid and working up until Airflow 2.1.3 and did break a lot of things for us when we did the upgrade (that is why we created and use this patch)
   
   
   I am sorry to bother you again with this issue and I would be gratefull if you would reconsider this pr. In any case I would like to thank you for your time and work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org