You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2024/01/26 07:23:15 UTC

[Impala-ASF-CR] IMPALA-12699: Set recv timeout for GetPartialCatalogObject Thrift RPC

Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20957


Change subject: IMPALA-12699: Set recv timeout for GetPartialCatalogObject Thrift RPC
......................................................................

IMPALA-12699: Set recv timeout for GetPartialCatalogObject Thrift RPC

GetPartialCatalogObject RPCs was seen to hang in coordinator side
caused by networking issue. Due to the piggyback mechanism of fetching
metadata in local-catalog mode, a hanging RPC on shared metadata
could block other queries.

Since GetPartialCatalogObject RPCs are read-only requestsm, they can
be cleanly retried. This patch creates a dedicated catalogd client
cache for GetPartialCatalogObject RPC and set an appropriate timeout
for the underlying socket.

Change-Id: I23995af4869e7ab8d826a1dd4d1197a21e738169
---
M be/src/exec/catalog-op-executor.cc
M be/src/runtime/client-cache.cc
M be/src/runtime/client-cache.h
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
M common/thrift/metrics.json
6 files changed, 45 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/20957/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I23995af4869e7ab8d826a1dd4d1197a21e738169
Gerrit-Change-Number: 20957
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-12699: Set recv timeout for GetPartialCatalogObject Thrift RPC

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20957 )

Change subject: IMPALA-12699: Set recv timeout for GetPartialCatalogObject Thrift RPC
......................................................................

IMPALA-12699: Set recv timeout for GetPartialCatalogObject Thrift RPC

GetPartialCatalogObject RPCs was seen to hang in coordinator side
caused by networking issue. Due to the piggyback mechanism of fetching
metadata in local-catalog mode, a hanging RPC on shared metadata
could block other queries.

Since GetPartialCatalogObject RPCs are read-only requests, they can
be cleanly retried. This patch creates a dedicated catalogd client
cache for GetPartialCatalogObject RPC, and defines a flag variable for
the RPC timeout.

Testing:
 - Manually verified the metrics of the new catalogd client cache.
 - Passed the core tests.

Change-Id: I23995af4869e7ab8d826a1dd4d1197a21e738169
---
M be/src/exec/catalog-op-executor.cc
M be/src/runtime/client-cache.cc
M be/src/runtime/client-cache.h
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
M common/thrift/metrics.json
6 files changed, 48 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/20957/3
-- 
To view, visit http://gerrit.cloudera.org:8080/20957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I23995af4869e7ab8d826a1dd4d1197a21e738169
Gerrit-Change-Number: 20957
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-12699: Set recv timeout for GetPartialCatalogObject Thrift RPC

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20957 )

Change subject: IMPALA-12699: Set recv timeout for GetPartialCatalogObject Thrift RPC
......................................................................

IMPALA-12699: Set recv timeout for GetPartialCatalogObject Thrift RPC

GetPartialCatalogObject RPCs was seen to hang in coordinator side
caused by networking issue. Due to the piggyback mechanism of fetching
metadata in local-catalog mode, a hanging RPC on shared metadata
could block other queries.

Since GetPartialCatalogObject RPCs are read-only requests, they can
be cleanly retried. This patch creates a dedicated catalogd client
cache for GetPartialCatalogObject RPC and set an appropriate timeout
for the underlying socket.

Change-Id: I23995af4869e7ab8d826a1dd4d1197a21e738169
---
M be/src/exec/catalog-op-executor.cc
M be/src/runtime/client-cache.cc
M be/src/runtime/client-cache.h
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
M common/thrift/metrics.json
6 files changed, 45 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/20957/2
-- 
To view, visit http://gerrit.cloudera.org:8080/20957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I23995af4869e7ab8d826a1dd4d1197a21e738169
Gerrit-Change-Number: 20957
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-12699: Set recv timeout for GetPartialCatalogObject Thrift RPC

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20957 )

Change subject: IMPALA-12699: Set recv timeout for GetPartialCatalogObject Thrift RPC
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/15064/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23995af4869e7ab8d826a1dd4d1197a21e738169
Gerrit-Change-Number: 20957
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 08:09:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12699: Set recv timeout for GetPartialCatalogObject Thrift RPC

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20957 )

Change subject: IMPALA-12699: Set recv timeout for GetPartialCatalogObject Thrift RPC
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/15063/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23995af4869e7ab8d826a1dd4d1197a21e738169
Gerrit-Change-Number: 20957
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 08:10:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12699: Set recv timeout for GetPartialCatalogObject Thrift RPC

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20957 )

Change subject: IMPALA-12699: Set recv timeout for GetPartialCatalogObject Thrift RPC
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/15078/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23995af4869e7ab8d826a1dd4d1197a21e738169
Gerrit-Change-Number: 20957
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 27 Jan 2024 06:10:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12699: Set recv timeout for GetPartialCatalogObject Thrift RPC

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has abandoned this change. ( http://gerrit.cloudera.org:8080/20957 )

Change subject: IMPALA-12699: Set recv timeout for GetPartialCatalogObject Thrift RPC
......................................................................


Abandoned
-- 
To view, visit http://gerrit.cloudera.org:8080/20957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I23995af4869e7ab8d826a1dd4d1197a21e738169
Gerrit-Change-Number: 20957
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>