You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/04 01:40:40 UTC

[GitHub] [airflow] josh-fell commented on pull request #25416: Hide unused fields for Amazon Web Services connection

josh-fell commented on PR #25416:
URL: https://github.com/apache/airflow/pull/25416#issuecomment-1204662024

   >Again, my personal thought, I still would suggest to hide host because it never (at least since Airflow 1.9) use in AwsHook. And might be better replace extra['host'] by extra['endpoint_url'] for maintain uniformity with boto3.client and boto3.resource.
   
   Sounds reasonable. As part of #25494, `host` could simply be renamed to `endpoint_url` and the placeholder in `Extra` for `host` and just be moved up accordingly should that PR be something that should be implemented. I'll defer to you all with this though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org