You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Markus Wiederkehr (JIRA)" <se...@james.apache.org> on 2008/12/18 14:29:44 UTC
[jira] Created: (MIME4J-92) Replace Base64InputStream with a faster
version
Replace Base64InputStream with a faster version
-----------------------------------------------
Key: MIME4J-92
URL: https://issues.apache.org/jira/browse/MIME4J-92
Project: JAMES Mime4j
Issue Type: Improvement
Affects Versions: 0.5
Reporter: Markus Wiederkehr
Assignee: Markus Wiederkehr
Fix For: 0.6
The current Base64InputStream does not make use of block operations. It overrides InputStream.read() instead of InputStream.read(byte[]) and also uses the single-byte read method to read from the underlying input stream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Resolved: (MIME4J-92) Replace Base64InputStream with a
faster version
Posted by "Markus Wiederkehr (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Markus Wiederkehr resolved MIME4J-92.
-------------------------------------
Resolution: Fixed
> Replace Base64InputStream with a faster version
> -----------------------------------------------
>
> Key: MIME4J-92
> URL: https://issues.apache.org/jira/browse/MIME4J-92
> Project: JAMES Mime4j
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Markus Wiederkehr
> Assignee: Markus Wiederkehr
> Fix For: 0.6
>
> Attachments: Base64InputStreamSpeedTest.java
>
>
> The current Base64InputStream does not make use of block operations. It overrides InputStream.read() instead of InputStream.read(byte[]) and also uses the single-byte read method to read from the underlying input stream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (MIME4J-92) Replace Base64InputStream with a faster
version
Posted by "Markus Wiederkehr (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Markus Wiederkehr updated MIME4J-92:
------------------------------------
Attachment: Base64InputStreamSpeedTest.java
Added performance test.
> Replace Base64InputStream with a faster version
> -----------------------------------------------
>
> Key: MIME4J-92
> URL: https://issues.apache.org/jira/browse/MIME4J-92
> Project: JAMES Mime4j
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Markus Wiederkehr
> Assignee: Markus Wiederkehr
> Fix For: 0.6
>
> Attachments: Base64InputStreamSpeedTest.java
>
>
> The current Base64InputStream does not make use of block operations. It overrides InputStream.read() instead of InputStream.read(byte[]) and also uses the single-byte read method to read from the underlying input stream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-92) Replace Base64InputStream with a
faster version
Posted by "Oleg Kalnichevski (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658551#action_12658551 ]
Oleg Kalnichevski commented on MIME4J-92:
-----------------------------------------
Hi Markus,
Sorry for getting back to you so late. Been busy getting a new release of HttpClient out the door.
Overall, great stuff. I just one minor nitpick, which is not terribly important. I generally prefer something like IllegalStateException to asserts, as lots of people out there do not have them enabled per default, which kind of makes them pointless. Feel free to ignore.
Oleg
PS: Actually we should also consider fixing QuotedPrintableInputStream, which has the same problem of reading one byte at a time.
> Replace Base64InputStream with a faster version
> -----------------------------------------------
>
> Key: MIME4J-92
> URL: https://issues.apache.org/jira/browse/MIME4J-92
> Project: JAMES Mime4j
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Markus Wiederkehr
> Assignee: Markus Wiederkehr
> Fix For: 0.6
>
> Attachments: Base64InputStreamSpeedTest.java
>
>
> The current Base64InputStream does not make use of block operations. It overrides InputStream.read() instead of InputStream.read(byte[]) and also uses the single-byte read method to read from the underlying input stream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-92) Replace Base64InputStream with a
faster version
Posted by "Markus Wiederkehr (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657788#action_12657788 ]
Markus Wiederkehr commented on MIME4J-92:
-----------------------------------------
New version committed, please review. If nobody objects I'll close this issue in a few days.
> Replace Base64InputStream with a faster version
> -----------------------------------------------
>
> Key: MIME4J-92
> URL: https://issues.apache.org/jira/browse/MIME4J-92
> Project: JAMES Mime4j
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Markus Wiederkehr
> Assignee: Markus Wiederkehr
> Fix For: 0.6
>
> Attachments: Base64InputStreamSpeedTest.java
>
>
> The current Base64InputStream does not make use of block operations. It overrides InputStream.read() instead of InputStream.read(byte[]) and also uses the single-byte read method to read from the underlying input stream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org