[GitHub] [lucene-solr] iverase commented on a change in pull request #1258: LUCENE-9225: Rectangle should extend LatLonGeometry

[GitBox <gi...@apache.org>]

iverase commented on a change in pull request #1258: LUCENE-9225: Rectangle should extend LatLonGeometry
URL: https://github.com/apache/lucene-solr/pull/1258#discussion_r386822636
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/document/LatLonShapeBoundingBoxQuery.java
 ##########
 @@ -108,4 +115,385 @@ public String toString(String field) {
     sb.append(rectangle.toString());
     return sb.toString();
   }
+
+  /** Holds spatial logic for a bounding box that works in the encoded space */
+  private static class EncodedRectangle {
 
 Review comment:
   This class is an specialisation for bounding box queries working on the encoded space. As such it feels like the correct place to package this logic is in the query itself. I am pushing this change, if you disagree we can re-think how to package this logic later on.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org