You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Brandon Li (Created) (JIRA)" <ji...@apache.org> on 2012/02/23 20:00:50 UTC

[jira] [Created] (HDFS-3003) DFSUtil is a better palce for method getHostPortString() than NameNode

DFSUtil is a better palce for method getHostPortString() than NameNode
----------------------------------------------------------------------

                 Key: HDFS-3003
                 URL: https://issues.apache.org/jira/browse/HDFS-3003
             Project: Hadoop HDFS
          Issue Type: Improvement
            Reporter: Brandon Li
            Assignee: Brandon Li
            Priority: Trivial


The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3003) DFSUtil is a better palce for method getHostPortString() than NameNode

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215013#comment-13215013 ] 

Hadoop QA commented on HDFS-3003:
---------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12515780/HDFS-3003.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 21 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1896//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1896//console

This message is automatically generated.
                
> DFSUtil is a better palce for method getHostPortString() than NameNode
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>         Attachments: HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3003) Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()

Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Srinivas updated HDFS-3003:
----------------------------------

    Target Version/s: 0.24.0, 0.23.3  (was: 0.24.0)
       Fix Version/s: 0.23.3
    
> Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>             Fix For: 0.24.0, 0.23.3
>
>         Attachments: HDFS-3003.patch, HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3003) DFSUtil is a better palce for method getHostPortString() than NameNode

Posted by "Brandon Li (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215123#comment-13215123 ] 

Brandon Li commented on HDFS-3003:
----------------------------------

Agree. NetUtils in common seems to be a more generic location. 
                
> DFSUtil is a better palce for method getHostPortString() than NameNode
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>         Attachments: HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3003) Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225005#comment-13225005 ] 

Hudson commented on HDFS-3003:
------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #1926 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1926/])
    Moving HDFS-3036, HDFS-3014, HDFS-3003, HDFS-2878, HDFS-208, HDFS-2764, HDFS-2410, HDFS-2285, HDFS-2507 to 0.23.3 section (Revision 1298274)

     Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298274
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

                
> Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>             Fix For: 0.24.0, 0.23.3
>
>         Attachments: HDFS-3003.patch, HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3003) DFSUtil is a better palce for method getHostPortString() than NameNode

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215132#comment-13215132 ] 

Hadoop QA commented on HDFS-3003:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12515832/HDFS-3003.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 21 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1898//console

This message is automatically generated.
                
> DFSUtil is a better palce for method getHostPortString() than NameNode
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>         Attachments: HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3003) DFSUtil is a better palce for method getHostPortString() than NameNode

Posted by "Brandon Li (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Li updated HDFS-3003:
-----------------------------

    Attachment: HDFS-3003.patch
    
> DFSUtil is a better palce for method getHostPortString() than NameNode
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>         Attachments: HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3003) DFSUtil is a better palce for method getHostPortString() than NameNode

Posted by "Brandon Li (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Li updated HDFS-3003:
-----------------------------

          Component/s: name-node
    Affects Version/s: 0.24.0
    
> DFSUtil is a better palce for method getHostPortString() than NameNode
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3003) DFSUtil is a better palce for method getHostPortString() than NameNode

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215733#comment-13215733 ] 

Hadoop QA commented on HDFS-3003:
---------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12515859/HDFS-3003.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 21 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1901//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1901//console

This message is automatically generated.
                
> DFSUtil is a better palce for method getHostPortString() than NameNode
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>         Attachments: HDFS-3003.patch, HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3003) DFSUtil is a better palce for method getHostPortString() than NameNode

Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215018#comment-13215018 ] 

Aaron T. Myers commented on HDFS-3003:
--------------------------------------

Hey Brandon, I agree that moving the method out of NameNode makes sense. One question - have you considered perhaps moving it somewhere even *more* generic? Perhaps somewhere in Common? This functionality doesn't seem DFS-specific to me, either.
                
> DFSUtil is a better palce for method getHostPortString() than NameNode
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>         Attachments: HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3003) Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216451#comment-13216451 ] 

Hudson commented on HDFS-3003:
------------------------------

Integrated in Hadoop-Mapreduce-trunk #1001 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1001/])
    HDFS-3003. Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString(). Contributed by Brandon Li. (Revision 1293338)

     Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293338
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileChecksumServlets.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileDataServlet.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDatanodeJsp.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStreamFile.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestTransferFsImage.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestGetConf.java

                
> Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>             Fix For: 0.24.0
>
>         Attachments: HDFS-3003.patch, HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3003) DFSUtil is a better palce for method getHostPortString() than NameNode

Posted by "Brandon Li (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Li updated HDFS-3003:
-----------------------------

    Attachment: HDFS-3003.patch
    
> DFSUtil is a better palce for method getHostPortString() than NameNode
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>         Attachments: HDFS-3003.patch, HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3003) Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215776#comment-13215776 ] 

Hudson commented on HDFS-3003:
------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #1782 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1782/])
    HDFS-3003. Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString(). Contributed by Brandon Li. (Revision 1293338)

     Result = ABORTED
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293338
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileChecksumServlets.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileDataServlet.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDatanodeJsp.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStreamFile.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestTransferFsImage.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestGetConf.java

                
> Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>             Fix For: 0.24.0
>
>         Attachments: HDFS-3003.patch, HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3003) DFSUtil is a better palce for method getHostPortString() than NameNode

Posted by "Brandon Li (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Li updated HDFS-3003:
-----------------------------

    Status: Patch Available  (was: Open)
    
> DFSUtil is a better palce for method getHostPortString() than NameNode
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>         Attachments: HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3003) Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215749#comment-13215749 ] 

Hudson commented on HDFS-3003:
------------------------------

Integrated in Hadoop-Common-trunk-Commit #1771 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1771/])
    HDFS-3003. Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString(). Contributed by Brandon Li. (Revision 1293338)

     Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293338
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileChecksumServlets.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileDataServlet.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDatanodeJsp.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStreamFile.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestTransferFsImage.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestGetConf.java

                
> Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>             Fix For: 0.24.0
>
>         Attachments: HDFS-3003.patch, HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3003) Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225044#comment-13225044 ] 

Hudson commented on HDFS-3003:
------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #1860 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1860/])
    Moving HDFS-3036, HDFS-3014, HDFS-3003, HDFS-2878, HDFS-208, HDFS-2764, HDFS-2410, HDFS-2285, HDFS-2507 to 0.23.3 section (Revision 1298274)

     Result = ABORTED
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298274
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

                
> Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>             Fix For: 0.24.0, 0.23.3
>
>         Attachments: HDFS-3003.patch, HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3003) DFSUtil is a better palce for method getHostPortString() than NameNode

Posted by "Brandon Li (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Li updated HDFS-3003:
-----------------------------

    Status: Patch Available  (was: Open)
    
> DFSUtil is a better palce for method getHostPortString() than NameNode
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>         Attachments: HDFS-3003.patch, HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3003) Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()

Posted by "Aaron T. Myers (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron T. Myers updated HDFS-3003:
---------------------------------

    Summary: Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()  (was: DFSUtil is a better palce for method getHostPortString() than NameNode)
    
> Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>         Attachments: HDFS-3003.patch, HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3003) DFSUtil is a better palce for method getHostPortString() than NameNode

Posted by "Brandon Li (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Li updated HDFS-3003:
-----------------------------

    Status: Patch Available  (was: Open)
    
> DFSUtil is a better palce for method getHostPortString() than NameNode
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>         Attachments: HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3003) Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224894#comment-13224894 ] 

Hudson commented on HDFS-3003:
------------------------------

Integrated in Hadoop-Mapreduce-0.23-Commit #668 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/668/])
    HDFS-3003. Merge r1293338 from trunk to 0.23 (Revision 1298242)

     Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298242
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileChecksumServlets.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileDataServlet.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDatanodeJsp.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStreamFile.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestTransferFsImage.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestGetConf.java

                
> Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>             Fix For: 0.24.0
>
>         Attachments: HDFS-3003.patch, HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3003) DFSUtil is a better palce for method getHostPortString() than NameNode

Posted by "Brandon Li (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Li updated HDFS-3003:
-----------------------------

    Attachment: HDFS-3003.patch

Moved getHostPortString from NameNode to DFSUtils and updated all the places where this method was invoked.
                
> DFSUtil is a better palce for method getHostPortString() than NameNode
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>         Attachments: HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3003) DFSUtil is a better palce for method getHostPortString() than NameNode

Posted by "Brandon Li (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Li updated HDFS-3003:
-----------------------------

    Status: Open  (was: Patch Available)
    
> DFSUtil is a better palce for method getHostPortString() than NameNode
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>         Attachments: HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3003) DFSUtil is a better palce for method getHostPortString() than NameNode

Posted by "Brandon Li (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215267#comment-13215267 ] 

Brandon Li commented on HDFS-3003:
----------------------------------

Looks like the change in Common can't be applied in HDFS JIRA. Attached patch has only HDFS changes.
                
> DFSUtil is a better palce for method getHostPortString() than NameNode
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>         Attachments: HDFS-3003.patch, HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3003) Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()

Posted by "Aaron T. Myers (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron T. Myers updated HDFS-3003:
---------------------------------

          Resolution: Fixed
       Fix Version/s: 0.24.0
    Target Version/s: 0.24.0
        Hadoop Flags: Reviewed
              Status: Resolved  (was: Patch Available)

I've just committed this patch to trunk. Thanks a lot, Brandon.
                
> Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>             Fix For: 0.24.0
>
>         Attachments: HDFS-3003.patch, HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3003) Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216417#comment-13216417 ] 

Hudson commented on HDFS-3003:
------------------------------

Integrated in Hadoop-Hdfs-trunk #966 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/966/])
    HDFS-3003. Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString(). Contributed by Brandon Li. (Revision 1293338)

     Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293338
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileChecksumServlets.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileDataServlet.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDatanodeJsp.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStreamFile.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestTransferFsImage.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestGetConf.java

                
> Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>             Fix For: 0.24.0
>
>         Attachments: HDFS-3003.patch, HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3003) Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215747#comment-13215747 ] 

Hudson commented on HDFS-3003:
------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #1845 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1845/])
    HDFS-3003. Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString(). Contributed by Brandon Li. (Revision 1293338)

     Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293338
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileChecksumServlets.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileDataServlet.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDatanodeJsp.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStreamFile.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestTransferFsImage.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestGetConf.java

                
> Remove getHostPortString() from NameNode, replace it with NetUtils.getHostPortString()
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>             Fix For: 0.24.0
>
>         Attachments: HDFS-3003.patch, HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3003) DFSUtil is a better palce for method getHostPortString() than NameNode

Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215735#comment-13215735 ] 

Aaron T. Myers commented on HDFS-3003:
--------------------------------------

+1, the patch looks good to me. I'll commit this momentarily.
                
> DFSUtil is a better palce for method getHostPortString() than NameNode
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>         Attachments: HDFS-3003.patch, HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3003) DFSUtil is a better palce for method getHostPortString() than NameNode

Posted by "Brandon Li (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Li updated HDFS-3003:
-----------------------------

    Status: Open  (was: Patch Available)
    
> DFSUtil is a better palce for method getHostPortString() than NameNode
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3003
>                 URL: https://issues.apache.org/jira/browse/HDFS-3003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>         Attachments: HDFS-3003.patch, HDFS-3003.patch
>
>
> The method getHostPortString() is not directly related with NameNode, and it's more of a utility method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira