You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by kl...@apache.org on 2023/11/14 06:53:37 UTC
(incubator-devlake) branch kw-docs-apikey-page updated (c91d64e70 -> c6334b30a)
This is an automated email from the ASF dual-hosted git repository.
klesh pushed a change to branch kw-docs-apikey-page
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
discard c91d64e70 feat: skip building plugins when DEVLAKE_PLUGINS=none
discard caa05897c docs: page and pageSize is not required
new fb2a79e67 docs: page and pageSize should not be required
new c6334b30a feat: skip building plugins when DEVLAKE_PLUGINS=none
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (c91d64e70)
\
N -- N -- N refs/heads/kw-docs-apikey-page (c6334b30a)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
(incubator-devlake) 02/02: feat: skip building plugins when DEVLAKE_PLUGINS=none
Posted by kl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
klesh pushed a commit to branch kw-docs-apikey-page
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
commit c6334b30aa55bae75280f7fea78252addd2e36ce
Author: Klesh Wong <zh...@merico.dev>
AuthorDate: Tue Nov 14 14:51:09 2023 +0800
feat: skip building plugins when DEVLAKE_PLUGINS=none
---
backend/scripts/build-plugins.sh | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/backend/scripts/build-plugins.sh b/backend/scripts/build-plugins.sh
index 5a92bce93..3c31404e6 100755
--- a/backend/scripts/build-plugins.sh
+++ b/backend/scripts/build-plugins.sh
@@ -34,6 +34,12 @@ echo "Usage: "
echo " build all plugins: $0 [golang build flags...]"
echo " build and keep specified plugins only: DEVLAKE_PLUGINS=github,jira $0 [golang build flags...]"
+
+if [ "$DEVLAKE_PLUGINS" = "none" ]; then
+ echo "skip building plugins" > &2
+ exit 0
+fi
+
ROOT_DIR=$(dirname $(dirname "$0"))
EXTRA=""
PLUGIN_SRC_DIR=$ROOT_DIR/plugins
(incubator-devlake) 01/02: docs: page and pageSize should not be required
Posted by kl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
klesh pushed a commit to branch kw-docs-apikey-page
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
commit fb2a79e677c3fbeddd0bb03908f518f99c5a4e6b
Author: Klesh Wong <zh...@merico.dev>
AuthorDate: Tue Nov 14 14:50:38 2023 +0800
docs: page and pageSize should not be required
---
backend/server/api/apikeys/apikeys.go | 9 +++++----
backend/server/api/project/project.go | 4 ++--
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/backend/server/api/apikeys/apikeys.go b/backend/server/api/apikeys/apikeys.go
index c8d307052..4c24967ea 100644
--- a/backend/server/api/apikeys/apikeys.go
+++ b/backend/server/api/apikeys/apikeys.go
@@ -18,14 +18,15 @@ limitations under the License.
package apikeys
import (
+ "net/http"
+ "strconv"
+
"github.com/apache/incubator-devlake/core/errors"
"github.com/apache/incubator-devlake/core/models"
"github.com/apache/incubator-devlake/impls/logruslog"
"github.com/apache/incubator-devlake/server/api/shared"
"github.com/apache/incubator-devlake/server/services"
"github.com/gin-gonic/gin"
- "net/http"
- "strconv"
)
type PaginatedApiKeys struct {
@@ -36,8 +37,8 @@ type PaginatedApiKeys struct {
// @Summary Get list of api keys
// @Description GET /api-keys?page=1&pageSize=10
// @Tags framework/api-keys
-// @Param page query int true "query"
-// @Param pageSize query int true "query"
+// @Param page query int false "query"
+// @Param pageSize query int false "query"
// @Success 200 {object} PaginatedApiKeys
// @Failure 400 {string} errcode.Error "Bad Request"
// @Failure 500 {string} errcode.Error "Internal Error"
diff --git a/backend/server/api/project/project.go b/backend/server/api/project/project.go
index 9e4b9e543..3bd9f573f 100644
--- a/backend/server/api/project/project.go
+++ b/backend/server/api/project/project.go
@@ -56,8 +56,8 @@ func GetProject(c *gin.Context) {
// @Summary Get list of projects
// @Description GET /projects?page=1&pageSize=10
// @Tags framework/projects
-// @Param page query int true "query"
-// @Param pageSize query int true "query"
+// @Param page query int false "query"
+// @Param pageSize query int false "query"
// @Success 200 {object} PaginatedProjects
// @Failure 400 {string} errcode.Error "Bad Request"
// @Failure 500 {string} errcode.Error "Internal Error"